Skip to content

Expose recovery/coredump configuration from sysfs

Rishabh Bhatnagar linux-remoteproc lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v23 patches 14 repliesSuperseded

v3 -> v2 from the cover letter

- Remove the coredump/recovery entries from debugfs
- Expose recovery/coredump from sysfs under a feature flag

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3remoteproc: Expose remoteproc configuration through sysfsdrivers/remoteproc/Kconfig+11 -02 replies
2/3remoteproc: Add coredump configuration to sysfsDocumentation/ABI/testing/sysfs-class-remoteproc drivers/remoteproc/remoteproc_debugfs.c drivers/remoteproc/remoteproc_sysfs.c+92 -900 replies
3/3remoteproc: Add recovery configuration to sysfsDocumentation/ABI/testing/sysfs-class-remoteproc drivers/remoteproc/remoteproc_debugfs.c drivers/remoteproc/remoteproc_sysfs.c+78 -780 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] Expose recovery/coredump configuration from sysfs

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. This patch series removes the recovery/coredump entries from debugfs and adds a configurable option to expose these interfaces from sysfs.
'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. Coredump configuration needs to be set to "inline" in debug/test build and "disabled" in production builds. Whereas recovery needs to be "disabled" for debugging purposes and "enabled" on production builds.

Changelog:

v3 -> v2:
- Remove the coredump/recovery entries from debugfs
- Expose recovery/coredump from sysfs under a feature flag

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Expose remoteproc configuration through sysfs
remoteproc: Add coredump configuration to sysfs
remoteproc: Add recovery configuration to sysfs

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
 drivers/remoteproc/Kconfig                       |  12 +++
 drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
 drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
 4 files changed, 190 insertions(+), 2 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project