Skip to content

Fix TC35894 gpio interrupt bug

[email protected] linux-gpio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

1 change V1[1] patch's Fixes tag
2 add DIRECTx register configuration in tc3589x_gpio_irq_sync_unlock()
to active general purpose gpio mode, else can't read correct GPIOMISx to identify which interrupt

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2gpio: tc35894: fix up tc35894 interrupt configurationdrivers/gpio/gpio-tc3589x.c+1 -11 reply
2/2gpio: tc35894: Disable Direct KBD interrupts to enable gpio irqdrivers/gpio/gpio-tc3589x.c include/linux/mfd/tc3589x.h+22 -22 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchLee Jones
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH: V2 0/2] Fix TC35894 gpio interrupt bug

From: dillon min <[email protected]>

This patchset intend to fix two bug on tc35894

V2:
1 change V1[1] patch's Fixes tag
2 add DIRECTx register configuration in tc3589x_gpio_irq_sync_unlock()
to active general purpose gpio mode, else can't read correct GPIOMISx to identify which interrupt

V1:

1 offset counting is wrong in tc3589x_gpio_irq_sync_unlock() 2 disable Direct KBD interrupts in gpio-tc3589x's probe(),
at least have to do this on tc35894, if not, after chip reset, IRQST(0x91) will always be 0x20, IRQN always low level, can't be cleared. need more test on other tc3589x.

dillon min (2):
gpio: tc35894: fix up tc35894 interrupt configuration
gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq

 drivers/gpio/gpio-tc3589x.c | 20 +++++++++++++++++---
 include/linux/mfd/tc3589x.h |  6 ++++++
 2 files changed, 23 insertions(+), 3 deletions(-)