Skip to content

Enable dynamic config of subport bandwidth

Savinay Dharmappa dpdk-dev 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest8 patches 6 repliesIn review
  2. v88 patches 1 replySuperseded
  3. v78 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v68 patches1 replySuperseded
v59 patches0 repliesSuperseded
v49 patches2 repliesSuperseded
v39 patches0 repliesSuperseded
v210 patches2 repliesSuperseded

Changes in v9 from the cover letter

- updated ABI section in release notes.
- Addressed review comments from patch 8

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8sched: add support profile tabledoc/guides/rel_notes/release_20_11.rst lib/librte_sched/rte_sched.c lib/librte_sched/rte_sched.h+222 -30 replies
2/8sched: introduce subport profile add functionlib/librte_sched/rte_sched.c lib/librte_sched/rte_sched.h lib/librte_sched/rte_sched_version.map+91 -00 replies
3/8sched: update subport rate dynamicallyapp/test/test_sched.c doc/guides/rel_notes/deprecation.rst doc/guides/rel_notes/release_20_11.rst +5 more+213 -2470 replies
4/8example/qos_sched: update subport rate dynamicallyexamples/qos_sched/cfg_file.c examples/qos_sched/cfg_file.h examples/qos_sched/init.c +2 more+110 -690 replies
5/8example/ip_pipeline: update subport rate dynamicallyexamples/ip_pipeline/cli.c examples/ip_pipeline/tmgr.c examples/ip_pipeline/tmgr.h+134 -600 replies
6/8drivers/softnic: update subport rate dynamicallydrivers/net/softnic/rte_eth_softnic_internals.h drivers/net/softnic/rte_eth_softnic_tm.c+195 -590 replies
7/8app/test_sched: update subport rate dynamicallyapp/test/test_sched.c+11 -20 replies
8/8sched: remove redundant codedoc/guides/rel_notes/release_20_11.rst lib/librte_sched/rte_sched.h+3 -120 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchCristian Dumitrescu
SeriesSeries-acked-by
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [dpdk-dev] [PATCH v9 0/8] Enable dynamic config of subport bandwidth

DPDK sched library allows runtime configuration of the pipe profiles to the pipes of the subport once scheduler hierarchy is constructed. However, to change the subport level bandwidth, existing hierarchy needs to be dismantled and whole process of building hierarchy under subport nodes needs to be repeated which might result in router downtime. Furthermore, due to lack of dynamic configuration of the subport bandwidth profile configuration (shaper and Traffic class rates), the user application is unable to dynamically re-distribute the excess-bandwidth of one subport among other subports in the scheduler hierarchy. Therefore, it is also not possible to adjust the subport bandwidth profile in sync with dynamic changes in pipe profiles of subscribers who want to consume higher bandwidth opportunistically.

This patch series implements dynamic configuration of the subport bandwidth profile to overcome the runtime situation when group of subscribers are not using the allotted bandwidth and dynamic bandwidth re-distribution is needed the without making any structural changes in the hierarchy.

The implementation work includes refactoring the existing api and data structures defined for port and subport level, new APIs for adding subport level bandwidth profiles that can be used in runtime.

---
v8 -> v9
- updated ABI section in release notes.
- Addressed review comments from patch 8

     of v8.

v7 -> v8
- Fix doxygen and clang build error.

v6 -> v7
- Fix checkpatch warning
and patch apply issue.

v5 -> v6
- Fix build warning.
- change cli of tmgr :
* remove queue size and pipes per subport
from cmdline argument to add traffic
manager subport profile.

* add pipes per subport as cmdline argument to create traffic manger port.

v4 -> v5
- Review comments from patch 3 & 6
from v4 are addressed.

v3 -> v4
- Fix patch apply issue.

v2 -> v3
- Review comments from patch 3 & 5
from v2 are addressed.

v1 -> v2
- Fix checkpatch warnings.
---

Savinay Dharmappa (8):
sched: add support profile table
sched: introduce subport profile add function
sched: update subport rate dynamically example/qos_sched: update subport rate dynamically example/ip_pipeline: update subport rate dynamically drivers/softnic: update subport rate dynamically app/test_sched: update subport rate dynamically
sched: remove redundant code

 app/test/test_sched.c                         |  15 +-
 doc/guides/rel_notes/deprecation.rst          |   6 -
 doc/guides/rel_notes/release_20_11.rst        |  15 +
 .../net/softnic/rte_eth_softnic_internals.h   |  11 +-
 drivers/net/softnic/rte_eth_softnic_tm.c      | 243 +++++--
 examples/ip_pipeline/cli.c                    |  68 +-
 examples/ip_pipeline/tmgr.c                   | 121 +++-
 examples/ip_pipeline/tmgr.h                   |   5 +-
 examples/qos_sched/cfg_file.c                 | 151 ++--
 examples/qos_sched/cfg_file.h                 |   4 +
 examples/qos_sched/init.c                     |  21 +-
 examples/qos_sched/main.h                     |   1 +
 examples/qos_sched/profile.cfg                |   3 +
 lib/librte_sched/rte_sched.c                  | 678 ++++++++++++------
 lib/librte_sched/rte_sched.h                  |  73 +-
 lib/librte_sched/rte_sched_version.map        |   2 +
 16 files changed, 972 insertions(+), 445 deletions(-)
Signature · 1 line
2.17.1