Skip to content

Add DLB PMD

Timothy McDaniel dpdk-dev 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v16 Latest23 patches 2 repliesIn review
  2. v1523 patches 8 repliesSuperseded
  3. v1423 patches 18 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v1323 patches2 repliesSuperseded
v1223 patches0 repliesSuperseded
v1123 patches0 repliesSuperseded
v1023 patches9 repliesSuperseded
v923 patches0 repliesSuperseded
v823 patches0 repliesSuperseded
v723 patches1 replySuperseded
v623 patches4 repliesSuperseded
v522 patches10 repliesSuperseded
v422 patches24 repliesSuperseded

Patches in v16 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23event/dlb: add documentation and meson infrastructureMAINTAINERS config/rte_config.h doc/guides/eventdevs/dlb.rst +5 more+72 -10 replies
2/23event/dlb: add dynamic loggingdrivers/event/dlb/dlb.c drivers/event/dlb/dlb_log.h drivers/event/dlb/meson.build+33 -20 replies
3/23event/dlb: add private data structures and constantsdrivers/event/dlb/dlb_priv.h+508 -00 replies
4/23event/dlb: add definitions shared with LKM or shared codedrivers/event/dlb/dlb_user.h+814 -00 replies
5/23event/dlb: add inline functionsdrivers/event/dlb/dlb_inline_fns.h+36 -00 replies
6/23event/dlb: add eventdev probedrivers/event/dlb/dlb.c drivers/event/dlb/dlb_priv.h drivers/event/dlb/meson.build +10 more+5586 -10 replies
7/23event/dlb: add flexible interfacedrivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c drivers/event/dlb/dlb_iface.h +2 more+57 -00 replies
8/23event/dlb: add probe-time hardware initdrivers/event/dlb/dlb.c drivers/event/dlb/meson.build drivers/event/dlb/pf/base/dlb_resource.c +2 more+561 -80 replies
9/23event/dlb: add xstatsdrivers/event/dlb/dlb.c drivers/event/dlb/dlb_xstats.c drivers/event/dlb/meson.build+1241 -00 replies
10/23event/dlb: add infos get and configuredoc/guides/eventdevs/dlb.rst drivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c +3 more+4562 -930 replies
11/23event/dlb: add queue and port default confdrivers/event/dlb/dlb.c+29 -00 replies
12/23event/dlb: add queue setupdoc/guides/eventdevs/dlb.rst drivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c +3 more+819 -00 replies
13/23event/dlb: add port setupdoc/guides/eventdevs/dlb.rst drivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c +3 more+2223 -40 replies
14/23event/dlb: add port linkdrivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c drivers/event/dlb/dlb_iface.h +2 more+1034 -00 replies
15/23event/dlb: add port unlink and port unlinks in progressdrivers/event/dlb/dlb.c+166 -00 replies
16/23event/dlb: add eventdev startdrivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c drivers/event/dlb/dlb_iface.h +2 more+351 -440 replies
17/23event/dlb: add enqueue and its burst variantsdoc/guides/eventdevs/dlb.rst drivers/event/dlb/dlb.c+728 -00 replies
18/23event/dlb: add dequeue and its burst variantsdoc/guides/eventdevs/dlb.rst drivers/event/dlb/dlb.c+740 -01 reply
19/23event/dlb: add eventdev stop and closedrivers/event/dlb/dlb.c drivers/event/dlb/dlb_iface.c drivers/event/dlb/dlb_iface.h +2 more+393 -110 replies
20/23event/dlb: add PMD's token pop public interfacedoc/api/doxy-api-index.md doc/api/doxy-api.conf.in drivers/event/dlb/dlb.c +5 more+309 -110 replies
21/23event/dlb: add PMD self-testsapp/test/test_eventdev.c drivers/event/dlb/dlb.c drivers/event/dlb/dlb_selftest.c +1 more+1548 -00 replies
22/23event/dlb: add queue and port releasedrivers/event/dlb/dlb.c+27 -00 replies
23/23event/dlb: add timeout ticks entry pointdrivers/event/dlb/dlb.c+13 -00 replies

Reviews trailers per patch

All 23 patches have a Reviewed-by or Acked-by.

PatchGage EadsAnatoly Burakov
1/23R-b
2/23R-b
3/23R-b
4/23R-b
5/23R-b
6/23R-b
7/23R-b
8/23R-b
9/23R-b
10/23R-b
11/23R-b
12/23R-b
13/23R-b
14/23R-b
15/23R-b
16/23R-b
17/23R-b
18/23R-b A-b
19/23R-b
20/23R-b
21/23R-b
22/23R-b
23/23R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v16 thread

Cover letter [dpdk-dev] [PATCH v16 00/23] Add DLB PMD

The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that connect producer and consumer cores, and implements load-balanced queueing features including:
- Lock-free multi-producer/multi-consumer operation.
- Multiple priority levels for varying traffic types.
- 'Direct' traffic (i.e. multi-producer/single-consumer)
- Simple unordered load-balanced distribution.
- Atomic lock-free load balancing across multiple consumers.
- Queue element reordering feature allowing ordered load-balanced distribution.

The DLB hardware supports both load balanced and directed ports and queues. Unlike other eventdev devices already in the repo, not all DLB ports and queues are equally capable. In particular, directed ports are limited to a single link, and must be connected to a directed queue.
Additionally, even though LDB ports may link multiple queues, the number of queues that may be linked is limited by hardware. Another difference is that DLB does not have a straightforward way of carrying the flow_id in the queue elements (QE) that the hardware operates on.

While reviewing the code, please be aware that this PMD has full control over the DLB hardware. Intel will be extending the DLB PMD in the future (not as part of this first series) with a mode that we refer to as the bifurcated PMD. The bifurcated PMD communicates with a kernel driver to configure the device, ports, and queues, and memory maps device MMIO so datapath operations occur purely in user-space.

The framework to support both the PF PMD and bifurcated PMD exists in this patchset, and is why the iface.[ch] layer is present.

Major changes in V16
====================
Address additional comments from David Marchand:
- converted printfs in dlb/pf/dlb_main.c to DLB_LOG
- fixed a repeated word error in dlb/pf/base/osdep_bitmap.h
- caught up with marking the patches that Gage reviewed

Major changes in V15
====================
Address comments from David Marchand:
- this patch-set is based on Nov 1, 2020 dpdk-next-eventdev
- fix docs build (doxy-api.conf.in and doxy-api-index.md)
- restore blank line in MAINTAINERS file
- move dlb announcement in release_20_11.rst after ethdev
- use headers = files() for exported meson public headers
- fix a typo in 'add documentation ..." commit message
- use eal version of cldemote
- convert a couple of printfs to LOG messages
- fix missing "~" in dlb documentation
- delay introduction of _delayed token pop functions to token pop commit (fixes 8 or so unused function errors)
- all patches build incrementally (gcc), and checkpatches reports success
- I am not able to run clang locally. If clang errors are still present I will ask IT to install clang on a build server tomorrow.

Major changes in V14
====================
- Fixed format errors in doc/api/doxy-api-index.md
- Delayed introduction of dlb2_consume_qe_immediate until add-dequeue-and-its-burst-variants.patch
- Delayed introduction of dlb2_construct_token_pop_qe until add-PMD-s-token-pop-public-interface.patch
- Delayed introduction of dlb_equeue_*_delayed until add dequeue and its burst variants.patch

Major changes in V13
====================
- removed now unused functions dlb_umwait and dlb_umonitor

Major changes in V12
====================
- Fix CENTOS build error: use __m128i instead of __v2di with _mm_stream_si128

Major changes in V11
====================
- removed unused function, fixing build error
- fixed typo in port_setup commit message
- this patch series is based on dpdk-next-eventdev

Major changes in v10
=====================
- convert to use rte_power_monitor patches
- replace __builtin_ia32_movntdq() with _mm_stream_si128()
- remove unused functions in dlb_selftest.c

Major changes in v9
=====================
- fixed a build error due to __rte_cache_aligned being placed after the ";" character, instead of before it.

Major changes in v8 after dpdk reviews
=====================
- moved introduction of dlb in relnotes_20_11 to first patch in series
- fixed underlines in dlb.rst that were too short
- note that the code still uses its private byte-encoded versions of umonitor/umwait, rather than the new functions in the power patch that are built on top of those intrinsics. This is intentional.

Major changes in v7 after dpdk reviews
=====================
- updated MAINTAINERS file to alphabetically insert DLB
- don't create RTE_ symbols in PMD
- converted to use version.map scheme
- converted to use .._master_lcore instead of .._main_lcore
- this patch set is based on dpdk-next-eventdev

Major changes in v6 after dpdk reviews:
=====================
- fixed meson conditional build. Moved test into driver’s meson.build file instead of event/meson.build
- documentation is populated as associated code is introduced
- add log_register in add dynamic logging patch
- rename RTE_xxx symbol(s) as DLB2_xxx
- replaced function ptr enqueue_four with direct call to movdir64b
- remove unused port_pages
- broke up probe patch into 3 smaller patches for easier review
- changed param order of movdir64b/movntdq to match intrinsics
- added self to MAINTAINERS files
- squashed announcement of availability into last patch in series
- correct spelling errors and delete repeated words
- DPDK_21.0 -> DPDK 21 in map file
- add experimental banner to public structs and APIs
- implemented other suggestions from code reviews of DLB2 PMD. The software is very similar in form so some DLB2 reviews comments were applicable to DLB as well

Major changes in v5 after dpdk reviews and additional internal reviews by colleagues at Intel:
================
- implement changes requested in code reviews by Gage Eads and Mike Chen
- fix a memzone leak
- convert to use eal rte-cpuflags patch from Liang Ma

Major changes in v4 after dpdk reviews and additional internal reviews by colleagues at Intel:
================
- Remove make infrastructure
- shared code (pf/base) is now added incrementally
- flexible interface (iface.[ch]) is now added incrementally
- removed calls to rte_panic
- do not call pthread_create directly
- remove unused internal API, os_time
- convert rte_atomic to __atomic builtins
- broke out eventdev ABI changes, test/api changes, and new internal PCI named probe API
- relocated enqueue logic to enqueue patch

Major Changes in V3:
================
- Fixed a memory corruption issue due to not allocating enough CQ memory for depths < 8. Hardware requires minimum allocation to be at least 8 entries.
- Address review comments from Gage and Mattias.
- Remove versioning
- minor formatting changes

Major changes in V2:
================
- Correct ABI break that was present in V1.
- Address some of the review comments received from Mattias. I will address the remaining items identified by Mattias in the next patch delivery.
- General code cleanup based on internal code reviews

Depends-on: patch-82202 ("eventdev: increase MAX QUEUES PER DEV to 255")

Timothy McDaniel (23):
event/dlb: add documentation and meson infrastructure event/dlb: add dynamic logging
event/dlb: add private data structures and constants event/dlb: add definitions shared with LKM or shared code event/dlb: add inline functions
event/dlb: add eventdev probe
event/dlb: add flexible interface
event/dlb: add probe-time hardware init event/dlb: add xstats
event/dlb: add infos get and configure event/dlb: add queue and port default conf event/dlb: add queue setup
event/dlb: add port setup
event/dlb: add port link
event/dlb: add port unlink and port unlinks in progress event/dlb: add eventdev start
event/dlb: add enqueue and its burst variants event/dlb: add dequeue and its burst variants event/dlb: add eventdev stop and close event/dlb: add PMD's token pop public interface event/dlb: add PMD self-tests
event/dlb: add queue and port release
event/dlb: add timeout ticks entry point

 MAINTAINERS                                  |    5 +
 app/test/test_eventdev.c                     |    7 +
 config/rte_config.h                          |    6 +
 doc/api/doxy-api-index.md                    |    3 +-
 doc/api/doxy-api.conf.in                     |    1 +
 doc/guides/eventdevs/dlb.rst                 |  341 ++
 doc/guides/eventdevs/index.rst               |    1 +
 doc/guides/rel_notes/release_20_11.rst       |    5 +
 drivers/event/dlb/dlb.c                      | 4079 +++++++++++++++
 drivers/event/dlb/dlb_iface.c                |   79 +
 drivers/event/dlb/dlb_iface.h                |   82 +
 drivers/event/dlb/dlb_inline_fns.h           |   36 +
 drivers/event/dlb/dlb_log.h                  |   25 +
 drivers/event/dlb/dlb_priv.h                 |  513 ++
 drivers/event/dlb/dlb_selftest.c             | 1539 ++++++
 drivers/event/dlb/dlb_user.h                 |  814 +++
 drivers/event/dlb/dlb_xstats.c               | 1217 +++++
 drivers/event/dlb/meson.build                |   22 +
 drivers/event/dlb/pf/base/dlb_hw_types.h     |  334 ++
 drivers/event/dlb/pf/base/dlb_osdep.h        |  310 ++
 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h |  441 ++
 drivers/event/dlb/pf/base/dlb_osdep_list.h   |  131 +
 drivers/event/dlb/pf/base/dlb_osdep_types.h  |   31 +
 drivers/event/dlb/pf/base/dlb_regs.h         | 2368 +++++++++
 drivers/event/dlb/pf/base/dlb_resource.c     | 6904 ++++++++++++++++++++++++++
 drivers/event/dlb/pf/base/dlb_resource.h     |  876 ++++
 drivers/event/dlb/pf/dlb_main.c              |  586 +++
 drivers/event/dlb/pf/dlb_main.h              |   47 +
 drivers/event/dlb/pf/dlb_pf.c                |  750 +++
 drivers/event/dlb/rte_pmd_dlb.c              |   38 +
 drivers/event/dlb/rte_pmd_dlb.h              |   77 +
 drivers/event/dlb/version.map                |    9 +
 drivers/event/meson.build                    |    2 +-
 33 files changed, 21677 insertions(+), 2 deletions(-)
 create mode 100644 doc/guides/eventdevs/dlb.rst
 create mode 100644 drivers/event/dlb/dlb.c
 create mode 100644 drivers/event/dlb/dlb_iface.c
 create mode 100644 drivers/event/dlb/dlb_iface.h
 create mode 100644 drivers/event/dlb/dlb_inline_fns.h
 create mode 100644 drivers/event/dlb/dlb_log.h
 create mode 100644 drivers/event/dlb/dlb_priv.h
 create mode 100644 drivers/event/dlb/dlb_selftest.c
 create mode 100644 drivers/event/dlb/dlb_user.h
 create mode 100644 drivers/event/dlb/dlb_xstats.c
 create mode 100644 drivers/event/dlb/meson.build
 create mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_regs.h
 create mode 100644 drivers/event/dlb/pf/base/dlb_resource.c
 create mode 100644 drivers/event/dlb/pf/base/dlb_resource.h
 create mode 100644 drivers/event/dlb/pf/dlb_main.c
 create mode 100644 drivers/event/dlb/pf/dlb_main.h
 create mode 100644 drivers/event/dlb/pf/dlb_pf.c
 create mode 100644 drivers/event/dlb/rte_pmd_dlb.c
 create mode 100644 drivers/event/dlb/rte_pmd_dlb.h
 create mode 100644 drivers/event/dlb/version.map
Signature · 1 line
2.6.4