Skip to content

Move recovery/coredump configuration to sysfs

Rishabh Bhatnagar linux-remoteproc lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 0 repliesNew
  2. v63 patches 6 repliesSuperseded
  3. v52 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v42 patches0 repliesSuperseded

v7 -> v6 from the cover letter

- Keep the debugfs entries intact for now.
- Reorder the patches to have a consistent sysfs interface.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3remoteproc: Change default dump configuration to "disabled"drivers/remoteproc/remoteproc_coredump.c drivers/remoteproc/remoteproc_debugfs.c include/linux/remoteproc.h+18 -190 replies
2/3remoteproc: Add coredump as part of sysfs interfaceDocumentation/ABI/testing/sysfs-class-remoteproc drivers/remoteproc/remoteproc_sysfs.c+87 -00 replies
3/3remoteproc: Add recovery configuration to the sysfs interfaceDocumentation/ABI/testing/sysfs-class-remoteproc drivers/remoteproc/remoteproc_sysfs.c+76 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 0/3] Move recovery/coredump configuration to sysfs

From Android R onwards Google has restricted access to debugfs in user and user-debug builds. This restricts access to most of the features exposed through debugfs. 'Coredump' and 'Recovery' are critical interfaces that are required for remoteproc to work on Qualcomm Chipsets. This patch series adds recovery/coredump configuration to sysfs interface and disables coredump collection by default. Having coredump disabled by default on production devices makes sense.

Changelog:

v7 -> v6:
- Keep the debugfs entries intact for now.
- Reorder the patches to have a consistent sysfs interface.

v6 -> v5:
- Disable coredump collection by default
- Rename the "default" configuration to "enabled" to avoid confusion

v5 -> v4:
- Fix the cover-letter of tha patch series.

v4 -> v3:
- Remove the feature flag to expose recovery/coredump

v3 -> v2:
- Remove the coredump/recovery entries from debugfs
- Expose recovery/coredump from sysfs under a feature flag

v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.

Rishabh Bhatnagar (3):
remoteproc: Change default dump configuration to "disabled"
remoteproc: Add coredump as part of sysfs interface
remoteproc: Add recovery configuration to the sysfs interface

 Documentation/ABI/testing/sysfs-class-remoteproc |  44 +++++++++
 drivers/remoteproc/remoteproc_coredump.c         |   6 +-
 drivers/remoteproc/remoteproc_debugfs.c          |  23 +++--
 drivers/remoteproc/remoteproc_sysfs.c            | 119 +++++++++++++++++++++++
 include/linux/remoteproc.h                       |   8 +-
 5 files changed, 181 insertions(+), 19 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project