Skip to content

Bug fixes and improvements for MHI power operations

Bhaumik Bhatt linux-arm-msm lkml 4 versions – Applied

Status from this message: This series was applied to qcom/linux.git (refs/heads/for-next):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 3 repliesApplied 12/12
  2. v312 patches 14 repliesSuperseded
  3. v212 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches19 repliesSuperseded

Changes in v4 from the cover letter

-Fixed up bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability patch by removing check for EE as well since a previous guard to check if MHI pm_state allows event ring access is already present. Event ring access should not be allowed at the time and hence the check is safe to remove.

Patches in v4 All 12 applied

#Subject and filesSizeRepliesApplied
1/12bus: mhi: core: Use appropriate names for firmware load functionsdrivers/bus/mhi/core/boot.c+10 -90 repliesApplied
2/12bus: mhi: core: Move to using high priority workqueuedrivers/bus/mhi/core/init.c drivers/bus/mhi/core/pm.c include/linux/mhi.h+12 -10 repliesApplied
3/12bus: mhi: core: Skip device wake in error or shutdown statesdrivers/bus/mhi/core/pm.c+4 -00 repliesApplied
4/12bus: mhi: core: Move to SYS_ERROR regardless of RDDM capabilitydrivers/bus/mhi/core/main.c+0 -51 replyApplied
5/12bus: mhi: core: Prevent sending multiple RDDM entry callbacksdrivers/bus/mhi/core/main.c+4 -00 repliesApplied
6/12bus: mhi: core: Move to an error state on any firmware load failuredrivers/bus/mhi/core/boot.c+20 -150 repliesApplied
7/12bus: mhi: core: Use appropriate label in firmware load handler APIdrivers/bus/mhi/core/boot.c+3 -30 repliesApplied
8/12bus: mhi: core: Move to an error state on mission mode failuredrivers/bus/mhi/core/pm.c+6 -20 repliesApplied
9/12bus: mhi: core: Check for IRQ availability during registrationdrivers/bus/mhi/core/init.c drivers/bus/mhi/core/pm.c+1 -40 repliesApplied
10/12bus: mhi: core: Separate system error and power down handlingdrivers/bus/mhi/core/pm.c+137 -221 replyApplied
11/12bus: mhi: core: Mark and maintain device states early on after power downdrivers/bus/mhi/core/pm.c+33 -440 repliesApplied
12/12bus: mhi: core: Remove MHI event ring IRQ handlers when powering downdrivers/bus/mhi/core/pm.c+2 -10 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchManivannan Sadhasivam
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] Bug fixes and improvements for MHI power operations

Bug fixes and improvements for MHI powerup and shutdown handling. Firmware load function names are updated to accurately reflect their purpose. Closed certain design gaps where the host (MHI bus) would allow clients to operate after a power down or error detection.
Move to an error state sooner based on different scenarios.

These patches were tested on arm64 and X86_64 architectures.

v4:
-Fixed up bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability patch by removing check for EE as well since a previous guard to check if MHI pm_state allows event ring access is already present. Event ring access should not be allowed at the time and hence the check is safe to remove.

v3:
-Fixed bus: mhi: core: Remove MHI event ring IRQ handlers when powering down -Mistakenly placed the free_irq() calls in mhi_pm_sys_error_transition() -Moved it to mhi_pm_disable_transition()

v2:
-Addressed patches based on review comments and made improvements -Added bus: mhi: core: Check for IRQ availability during registration -Dropped bus: mhi: core: Use the IRQF_ONESHOT flag for the BHI interrupt line -Split bus: mhi: core: Move to an error state on any firmware load failure -Modified the following patches:
-bus: mhi: core: Disable IRQs when powering down
-bus: mhi: core: Improve shutdown handling after link down detection -bus: mhi: core: Mark device inactive soon after host issues a shutdown -bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability -Addressed the above as follow-up patches with improvements:
-bus: mhi: core: Prevent sending multiple RDDM entry callbacks -bus: mhi: core: Separate system error and power down handling -bus: mhi: core: Remove MHI event ring IRQ handlers when powering down

Bhaumik Bhatt (12):
bus: mhi: core: Use appropriate names for firmware load functions
bus: mhi: core: Move to using high priority workqueue
bus: mhi: core: Skip device wake in error or shutdown states
bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability
bus: mhi: core: Prevent sending multiple RDDM entry callbacks
bus: mhi: core: Move to an error state on any firmware load failure
bus: mhi: core: Use appropriate label in firmware load handler API
bus: mhi: core: Move to an error state on mission mode failure
bus: mhi: core: Check for IRQ availability during registration
bus: mhi: core: Separate system error and power down handling
bus: mhi: core: Mark and maintain device states early on after power
down
bus: mhi: core: Remove MHI event ring IRQ handlers when powering down

 drivers/bus/mhi/core/boot.c |  60 ++++++-----
 drivers/bus/mhi/core/init.c |  11 ++-
 drivers/bus/mhi/core/main.c |   9 +-
 drivers/bus/mhi/core/pm.c   | 236 ++++++++++++++++++++++++++++++++------------
 include/linux/mhi.h         |   2 +
 5 files changed, 222 insertions(+), 96 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project