staging: media: bring back zoran driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest47 patches 6 repliesIn review
- v149 patches 6 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/47 | staging: media: Revert "media: zoran: remove deprecated driver"Documentation/ drivers/ drivers/ +19 more | +11284 | 1 reply | |
| 2/47 | MAINTAINERS: change maintainer of the zoran driverDocumentation/ MAINTAINERS drivers/ +3 more | +17 | 0 replies | |
| 3/47 | staging: media: zoran: datasheet is no longer available from zoran.comdrivers/ | +0 | 0 replies | |
| 4/47 | staging: media: zoran: Documentation: fix typoDocumentation/ | +2 | 0 replies | |
| 5/47 | staging: media: zoran: fix checkpatch issuedrivers/ drivers/ drivers/ +13 more | +740 | 0 replies | |
| 6/47 | staging: media: zoran: do not forward declare zr36057_init_vfedrivers/ | +21 | 0 replies | |
| 7/47 | staging: media: zoran: convert all error dprintk to pci_err/pr_errdrivers/ drivers/ drivers/ +5 more | +145 | 0 replies | |
| 8/47 | staging: media: zoran: convert dprintk warndrivers/ drivers/ drivers/ | +14 | 0 replies | |
| 9/47 | staging: media: zoran: convert dprintk info to pci_infodrivers/ drivers/ drivers/ | +36 | 0 replies | |
| 10/47 | staging: media: zoran: convert dprintk debugdrivers/ drivers/ drivers/ +1 more | +21 | 0 replies | |
| 11/47 | staging: media: zoran: zoran_device.c: convert pr_x to pci_xdrivers/ | +5 | 1 reply | |
| 12/47 | staging: media: zoran: remove proc_fsdrivers/ drivers/ drivers/ +4 more | +1 | 0 replies | |
| 13/47 | staging: media: zoran: use VFL_TYPE_VIDEOdrivers/ | +1 | 0 replies | |
| 14/47 | staging: media: zoran: use v4l2_buffer_set_timestampdrivers/ | +2 | 0 replies | |
| 15/47 | staging: media: zoran: do not print random guest 0drivers/ | +7 | 0 replies | |
| 16/47 | staging: media: zoran: move buffer_size out of zoran_fhdrivers/ drivers/ drivers/ | +35 | 0 replies | |
| 17/47 | staging: media: zoran: move v4l_settings out of zoran_fhdrivers/ drivers/ | +17 | 0 replies | |
| 18/47 | staging: media: zoran: move jpg_settings out of zoran_fhdrivers/ drivers/ | +47 | 0 replies | |
| 19/47 | staging: media: zoran: move overlay_settings out of zoran_fhdrivers/ drivers/ drivers/ | +21 | 0 replies | |
| 20/47 | staging: media: zoran: Use video_drvdata to get struct zorandrivers/ | +14 | 0 replies | |
| 21/47 | staging: media: zoran: Change zoran_v4l_set_format parameter from zoran_fh to zorandrivers/ | +2 | 0 replies | |
| 22/47 | staging: media: zoran: remove overlaydrivers/ drivers/ drivers/ +1 more | +12 | 0 replies | |
| 23/47 | staging: media: zoran: Use DMA coherent for stat_comdrivers/ drivers/ drivers/ | +18 | 0 replies | |
| 24/47 | staging: media: zoran: use ZR_NORMdrivers/ drivers/ drivers/ | +11 | 0 replies | |
| 25/47 | staging: media: zoran: zoran does not support STD_ALLdrivers/ | +1 | 0 replies | |
| 26/47 | staging: media: zoran: convert irq to pci irqdrivers/ | +3 | 0 replies | |
| 27/47 | staging: media: zoran: convert zoran alloc to devmdrivers/ | +1 | 0 replies | |
| 28/47 | staging: media: zoran: convert mdelay to udelaydrivers/ | +2 | 1 reply | |
| 29/47 | staging: media: zoran: use devm for videocodec_master allocdrivers/ | +5 | 0 replies | |
| 30/47 | staging: media: zoran: use pci_request_regionsdrivers/ | +8 | 0 replies | |
| 31/47 | staging: media: zoran: use devm_ioremapdrivers/ | +2 | 0 replies | |
| 32/47 | staging: media: zoran: add stat_com bufferdrivers/ drivers/ | +14 | 0 replies | |
| 33/47 | staging: media: zoran: constify struct tvnormdrivers/ drivers/ drivers/ +4 more | +22 | 0 replies | |
| 34/47 | staging: media: zoran: constify codec_namedrivers/ | +3 | 0 replies | |
| 35/47 | staging: media: zoran: Add more check for compliancedrivers/ | +17 | 0 replies | |
| 36/47 | staging: media: zoran: Add vb_queuedrivers/ drivers/ drivers/ +1 more | +271 | 0 replies | |
| 37/47 | staging: media: zoran: disable outputdrivers/ drivers/ | +14 | 0 replies | |
| 38/47 | staging: media: zoran: device support only 32bit DMA addressdrivers/ | +6 | 0 replies | |
| 39/47 | staging: media: zoran: enable makefiledrivers/ | +1 | 0 replies | |
| 40/47 | staging: media: zoran: remove framebuffer supportdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 41/47 | staging: media: zoran: add vidioc_g_parmdrivers/ | +9 | 0 replies | |
| 42/47 | staging: media: zoran: remove test_interruptsdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 43/47 | staging: media: zoran: fix use of buffer_size and sizeimagedrivers/ drivers/ | +8 | 0 replies | |
| 44/47 | staging: media: zoran: fix some compliance testdrivers/ | +11 | 0 replies | |
| 45/47 | staging: media: zoran: remove deprecated .vidioc_g_jpegcompdrivers/ drivers/ | +22 | 0 replies | |
| 46/47 | staging: media: zoran: convert to vb2drivers/ drivers/ drivers/ +2 more | +137 | 0 replies | |
| 47/47 | staging: media: zoran: update TODOdrivers/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver
Hello
The zoran driver was removed in 5.3
The main reason of the removing was lack of motivation to convert it to VB2
Since I need it, I worked on bringing it back.
So the plan to achieve it was:
- clean up the coding style.
- convert old usage/API
- clean unused code
- convert to VB2
I have tried to split a bit the VB2 patch (by adding/removing code in another patch), but the result is unfortunately still a big patch.
The result of this serie is a working zoran driver. Furthermore it is now compliant to v4l-compliance.
In the process some old (useless) feature (fbuf, overlay) was removed for simplifying maintenance.
The zoran hardware support MJPEG decompression, but this feature is temporarily disabled by this serie.
But basically, this feature was unusable, since the only tool which permitted to use it was a mplayer option.
But this mplayer option no longer compile (probably since a long time) and is such a hack (a copy of some private ffmpeg structure) that it is unfixable.
Happily, when I started to work on zoran, a patch was posted on ffmpeg ML which permit it to output non-raw video stream (and so MJPEG for zoran case).
But the zoran hw does not like some part of JPEG header it receives, so a filter need to be written.
Anyway, this disabling is not a regression, since this feature was not usable since a long time.
Since the driver was in staging, I targeted staging, but probably the driver is in a sufficient good shape to target media and bypass staging.
This driver is tested on a DC10+ (on x86). Tests on different hardware are welcome.
I would like to thanks all people that helped me to achieve this (mostly #v4l)
Regards
PS: this serie is resent a bit soon since linux-media didnt get some patch and cover letter
Changes since RFC1
- removed fallthough patch
- removed unsplit lines patch
- fixed line size in "Use DMA coherent for stat_com" patch
Corentin Labbe (47):
staging: media: Revert "media: zoran: remove deprecated driver"
MAINTAINERS: change maintainer of the zoran driver
staging: media: zoran: datasheet is no longer available from zoran.com
staging: media: zoran: Documentation: fix typo
staging: media: zoran: fix checkpatch issue
staging: media: zoran: do not forward declare zr36057_init_vfe
staging: media: zoran: convert all error dprintk to pci_err/pr_err
staging: media: zoran: convert dprintk warn
staging: media: zoran: convert dprintk info to pci_info
staging: media: zoran: convert dprintk debug
staging: media: zoran: zoran_device.c: convert pr_x to pci_x
staging: media: zoran: remove proc_fs
staging: media: zoran: use VFL_TYPE_VIDEO
staging: media: zoran: use v4l2_buffer_set_timestamp
staging: media: zoran: do not print random guest 0
staging: media: zoran: move buffer_size out of zoran_fh
staging: media: zoran: move v4l_settings out of zoran_fh
staging: media: zoran: move jpg_settings out of zoran_fh
staging: media: zoran: move overlay_settings out of zoran_fh
staging: media: zoran: Use video_drvdata to get struct zoran
staging: media: zoran: Change zoran_v4l_set_format parameter from
zoran_fh to zoran
staging: media: zoran: remove overlay
staging: media: zoran: Use DMA coherent for stat_com
staging: media: zoran: use ZR_NORM
staging: media: zoran: zoran does not support STD_ALL
staging: media: zoran: convert irq to pci irq
staging: media: zoran: convert zoran alloc to devm
staging: media: zoran: convert mdelay to udelay
staging: media: zoran: use devm for videocodec_master alloc
staging: media: zoran: use pci_request_regions
staging: media: zoran: use devm_ioremap
staging: media: zoran: add stat_com buffer
staging: media: zoran: constify struct tvnorm
staging: media: zoran: constify codec_name
staging: media: zoran: Add more check for compliance
staging: media: zoran: Add vb_queue
staging: media: zoran: disable output
staging: media: zoran: device support only 32bit DMA address
staging: media: zoran: enable makefile
staging: media: zoran: remove framebuffer support
staging: media: zoran: add vidioc_g_parm
staging: media: zoran: remove test_interrupts
staging: media: zoran: fix use of buffer_size and sizeimage
staging: media: zoran: fix some compliance test
staging: media: zoran: remove deprecated .vidioc_g_jpegcomp
staging: media: zoran: convert to vb2
staging: media: zoran: update TODO
Documentation/media/v4l-drivers/zoran.rst | 575 +++++++++ MAINTAINERS | 10 + drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile | 1 + drivers/staging/media/zoran/Kconfig | 76 ++ drivers/staging/media/zoran/Makefile | 7 + drivers/staging/media/zoran/TODO | 19 + drivers/staging/media/zoran/videocodec.c | 330 +++++ drivers/staging/media/zoran/videocodec.h | 308 +++++ drivers/staging/media/zoran/zoran.h | 320 +++++ drivers/staging/media/zoran/zoran_card.c | 1333 ++++++++++++++++++++ drivers/staging/media/zoran/zoran_card.h | 30 + drivers/staging/media/zoran/zoran_device.c | 1013 +++++++++++++++ drivers/staging/media/zoran/zoran_device.h | 64 + drivers/staging/media/zoran/zoran_driver.c | 1038 +++++++++++++++ drivers/staging/media/zoran/zr36016.c | 433 +++++++ drivers/staging/media/zoran/zr36016.h | 92 ++ drivers/staging/media/zoran/zr36050.c | 842 +++++++++++++ drivers/staging/media/zoran/zr36050.h | 163 +++ drivers/staging/media/zoran/zr36057.h | 154 +++ drivers/staging/media/zoran/zr36060.c | 872 +++++++++++++ drivers/staging/media/zoran/zr36060.h | 201 +++ 22 files changed, 7883 insertions(+) create mode 100644 Documentation/media/v4l-drivers/zoran.rst create mode 100644 drivers/staging/media/zoran/Kconfig create mode 100644 drivers/staging/media/zoran/Makefile create mode 100644 drivers/staging/media/zoran/TODO create mode 100644 drivers/staging/media/zoran/videocodec.c create mode 100644 drivers/staging/media/zoran/videocodec.h create mode 100644 drivers/staging/media/zoran/zoran.h create mode 100644 drivers/staging/media/zoran/zoran_card.c create mode 100644 drivers/staging/media/zoran/zoran_card.h create mode 100644 drivers/staging/media/zoran/zoran_device.c create mode 100644 drivers/staging/media/zoran/zoran_device.h create mode 100644 drivers/staging/media/zoran/zoran_driver.c create mode 100644 drivers/staging/media/zoran/zr36016.c create mode 100644 drivers/staging/media/zoran/zr36016.h create mode 100644 drivers/staging/media/zoran/zr36050.c create mode 100644 drivers/staging/media/zoran/zr36050.h create mode 100644 drivers/staging/media/zoran/zr36057.h create mode 100644 drivers/staging/media/zoran/zr36060.c create mode 100644 drivers/staging/media/zoran/zr36060.h
Signature · 1 line
2.26.2