Skip to content

s390x: css: pv: css test adaptation for PV

Pierre Morel kvm linux-s390 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 10 repliesIn review
  2. v43 patches 21 repliesSuperseded
  3. v33 patches 9 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches8 repliesSuperseded
v14 patches3 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3s390x: pv: implement routine to share/unshare memorylib/s390x/asm/uv.h+39 -02 replies
2/3s390x: define UV compatible I/O allocationlib/s390x/malloc_io.c lib/s390x/malloc_io.h s390x/Makefile+117 -06 replies
3/3s390x: css: pv: css test adaptation for PVlib/s390x/css.h lib/s390x/css_lib.c s390x/css.c+40 -340 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckThomas HuthJanosch Frank
1/3A-b A-b R-b
2/3R-b A-b A-b
3/3R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [kvm-unit-tests PATCH v5 0/3] s390x: css: pv: css test adaptation for PV

Hi all,

To adapt the CSS I/O tests to protected virtualisation we need utilities to:

1- allocate the I/O buffers in a private page using (patch 2)
It must be in a dedicated page to avoid exporting code or guest private data to the host.
We accept a size in byte and flags and allocate page integral memory to handle the Protected Virtualization.

2- share the I/O buffers with the host (patch 1)
This patch uses the page allocator reworked by Claudio.

The 2 first patches are the implementation of the tools, patch 3 is the modification of the css.c test for PV.

The checkpatch always asked me to modify MAINTAINERS, so I added me as reviewer to be in copy for CSS at least. May be we could create a finer grain MAINTAINERS in the future.

regards,
Pierre

Pierre Morel (3):
s390x: pv: implement routine to share/unshare memory
s390x: define UV compatible I/O allocation
s390x: css: pv: css test adaptation for PV

 lib/s390x/asm/uv.h    | 39 ++++++++++++++++++++++++
 lib/s390x/css.h       |  3 +-
 lib/s390x/css_lib.c   | 28 +++++------------
 lib/s390x/malloc_io.c | 71 +++++++++++++++++++++++++++++++++++++++++++
 lib/s390x/malloc_io.h | 45 +++++++++++++++++++++++++++
 s390x/Makefile        |  1 +
 s390x/css.c           | 43 ++++++++++++++++++--------
 7 files changed, 196 insertions(+), 34 deletions(-)
 create mode 100644 lib/s390x/malloc_io.c
 create mode 100644 lib/s390x/malloc_io.h
Signature · 53 lines
2.17.1

changelog:

from v4:

- better SPDX license
  (Thomast, Janosch)

- use get_order instead of a false calculation
  (Thomas)

- rename functions malloc_io_pages to malloc_io_mem
  (Thomas)

- Explicit error sentence for share errors
  (Janosch)

- use UVC_RC_EXECUTED instead of bare hexa in share
  (Janosch)

- removed MAINTAINERS changes, will be in another patch if ever
  (Janosch, Thomas)

from v3:
- add failure report to the new allocations in css.c
  (Thomas)

- rework alloc_io_page and free_io_page
  (Thomas, Claudio)

- add SPDX licenses
  (Thomas)

- add comment for the functions declaration.

- add me as reviewer for the CSS

from v2:

- use the page allocator reworked by Claudio

from v1:

- add the kvm-unit-test header

- correct checks for errors on Set/Remove Shared Access

- Add report for uv Set/Remove Shared Access

- zero the allocated I/O page before use

- free the page on error.