Skip to content

net/mlx5: support multiple-thread flow operations

Suanming Mou dpdk-dev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/234 patches 1 replyIn review
  2. v5 posting 1/234 patches 0 repliesSuperseded
  3. v434 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v334 patches0 repliesSuperseded
v225 patches0 repliesSuperseded
v125 patches0 repliesSuperseded

Changes in v5 from the cover letter

- fix table refcnt leak issue.

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34net/mlx5: use thread safe index pool for flow objectsdrivers/net/mlx5/mlx5.c+11 -111 reply
2/34net/mlx5: use thread specific flow workspacedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h +4 more+171 -890 replies
3/34net/mlx5: reuse flow Id as hairpin Iddrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.c +1 more+10 -380 replies
4/34net/mlx5: indexed pool supports zero size entrydrivers/net/mlx5/mlx5_utils.c+2 -20 replies
5/34net/mlx5: use indexed pool as ID generatordrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h +4 more+78 -2070 replies
6/34net/mlx5: make rte flow list thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.c+10 -20 replies
7/34net/mlx5: make meter action thread safedrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_meter.c+39 -350 replies
8/34net/mlx5: make VLAN network interface thread safedrivers/common/mlx5/linux/mlx5_nl.h drivers/net/mlx5/linux/mlx5_vlan_os.c+6 -00 replies
9/34net/mlx5: create global jump actiondrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+17 -410 replies
10/34net/mlx5: create global default miss actiondrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow_dv.c+13 -930 replies
11/34net/mlx5: create global drop actiondrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_flow_dv.c +1 more+26 -600 replies
12/34net/mlx5: support concurrent access for hash listdrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_flow.c +3 more+287 -880 replies
13/34net/mlx5: add flow table tunnel offload attributedrivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+3 -10 replies
14/34net/mlx5: make flow table cache thread safedrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.c +2 more+181 -2120 replies
15/34net/mlx5: fix redundant Direct Verbs resources allocatedrivers/net/mlx5/linux/mlx5_os.c+5 -20 replies
16/34net/mlx5: make flow tag list thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+56 -520 replies
17/34net/mlx5: make flow modify action list thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+102 -1150 replies
18/34net/mlx5: remove unused mreg copy codedrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow.h+0 -1890 replies
19/34net/mlx5: make metadata copy flow list thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow.h+99 -740 replies
20/34net/mlx5: make header reformat action thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+116 -840 replies
21/34net/mlx5: introduce thread safe linked list cachedrivers/net/mlx5/mlx5_utils.c drivers/net/mlx5/mlx5_utils.h+343 -00 replies
22/34net/mlx5: optimize shared RSS list operationdrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_rxq.c drivers/net/mlx5/mlx5_rxtx.h+39 -250 replies
23/34net/mlx5: make Rx queue thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h +5 more+228 -2180 replies
24/34net/mlx5: make matcher list thread safedrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c+129 -1040 replies
25/34net/mlx5: make port ID action cache thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.h +1 more+94 -730 replies
26/34net/mlx5: make push VLAN action cache thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.h +1 more+102 -790 replies
27/34net/mlx5: simplify sample attributesdrivers/net/mlx5/mlx5_flow_dv.c+14 -150 replies
28/34net/mlx5: fix sample register error flowdrivers/net/mlx5/mlx5_flow_dv.c+60 -570 replies
29/34net/mlx5: make sample and mirror action thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow.h +1 more+260 -1830 replies
30/34net/mlx5: make tunnel offloading table thread safedrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow_dv.c+61 -420 replies
31/34net/mlx5: remove unused hash list operationsdrivers/net/mlx5/mlx5_utils.c drivers/net/mlx5/mlx5_utils.h+0 -1040 replies
32/34net/mlx5: make tunnel hub list thread safedrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow.h+18 -30 replies
33/34net/mlx5: make shared action list thread safedrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_flow_dv.c+7 -00 replies
34/34net/mlx5: remove shared context lockdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_20_11.rst drivers/net/mlx5/linux/mlx5_os.c +2 more+27 -1890 replies

Reviews trailers per patch

All 34 patches have a Reviewed-by or Acked-by.

PatchMatan Azrad
1/34A-b
2/34A-b
3/34A-b
4/34A-b
5/34A-b
6/34A-b
7/34A-b
8/34A-b
9/34A-b
10/34A-b
11/34A-b
12/34A-b
13/34A-b
14/34A-b
15/34A-b
16/34A-b
17/34A-b
18/34A-b
19/34A-b
20/34A-b
21/34A-b
22/34A-b
23/34A-b
24/34A-b
25/34A-b
26/34A-b
27/34A-b
28/34A-b
29/34A-b
30/34A-b
31/34A-b
32/34A-b
33/34A-b
34/34A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 00/34] net/mlx5: support multiple-thread flow operations

This patch set contains multiple-thread flow operations support for the flow objects.

Suanming Mou (19):
net/mlx5: use thread safe index pool for flow objects net/mlx5: make meter action thread safe net/mlx5: make VLAN network interface thread safe net/mlx5: create global jump action
net/mlx5: create global default miss action net/mlx5: create global drop action
net/mlx5: add flow table tunnel offload attribute net/mlx5: fix redundant Direct Verbs resources allocate net/mlx5: remove unused mreg copy code net/mlx5: make header reformat action thread safe net/mlx5: optimize shared RSS list operation net/mlx5: make Rx queue thread safe
net/mlx5: simplify sample attributes
net/mlx5: fix sample register error flow net/mlx5: make sample and mirror action thread safe net/mlx5: make tunnel offloading table thread safe net/mlx5: remove unused hash list operations net/mlx5: make tunnel hub list thread safe net/mlx5: make shared action list thread safe

Xueming Li (15):
net/mlx5: use thread specific flow workspace net/mlx5: reuse flow Id as hairpin Id net/mlx5: indexed pool supports zero size entry net/mlx5: use indexed pool as ID generator net/mlx5: make rte flow list thread safe net/mlx5: support concurrent access for hash list net/mlx5: make flow table cache thread safe net/mlx5: make flow tag list thread safe net/mlx5: make flow modify action list thread safe net/mlx5: make metadata copy flow list thread safe net/mlx5: introduce thread safe linked list cache net/mlx5: make matcher list thread safe net/mlx5: make port ID action cache thread safe net/mlx5: make push VLAN action cache thread safe net/mlx5: remove shared context lock
---

v5:
- fix table refcnt leak issue.

v4:
- rebase the code on top of the latest code to fix the conflict.

v3:
- rebase the code on top of the new added features.
- New feature code adaption for multiple-thread support.

v2:
- fix review comments.
- remove unused mreg copy code.
- drop the sh lock removing patch as new feature still not fully updated.

---

 doc/guides/nics/mlx5.rst               |    1 +
 doc/guides/rel_notes/release_20_11.rst |    1 +
 drivers/common/mlx5/linux/mlx5_nl.h    |    1 +
 drivers/net/mlx5/linux/mlx5_os.c       |  119 +-
 drivers/net/mlx5/linux/mlx5_vlan_os.c  |    5 +
 drivers/net/mlx5/mlx5.c                |  278 +---
 drivers/net/mlx5/mlx5.h                |   69 +-
 drivers/net/mlx5/mlx5_flow.c           |  756 +++++------
 drivers/net/mlx5/mlx5_flow.h           |  164 ++-
 drivers/net/mlx5/mlx5_flow_dv.c        | 2259 ++++++++++++++------------------
 drivers/net/mlx5/mlx5_flow_meter.c     |   72 +-
 drivers/net/mlx5/mlx5_flow_verbs.c     |   86 +-
 drivers/net/mlx5/mlx5_rxq.c            |  302 +++--
 drivers/net/mlx5/mlx5_rxtx.h           |   23 +-
 drivers/net/mlx5/mlx5_utils.c          |  345 ++++-
 drivers/net/mlx5/mlx5_utils.h          |  320 ++++-
 16 files changed, 2464 insertions(+), 2337 deletions(-)
Signature · 1 line
1.8.3.1