Skip to content

UIO support for dfl devices

Xu Yilun linux-fpga lkml 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest2 patches 4 repliesIn review
  2. v11 posting 2/22 patches 3 repliesSuperseded
  3. v11 posting 1/22 patches 5 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v102 patches3 repliesSuperseded
v92 patches8 repliesSuperseded
v82 patches0 repliesSuperseded
v72 patches2 repliesSuperseded
v62 patches9 repliesSuperseded
v52 patches13 repliesSuperseded
v42 patches2 repliesSuperseded
v33 patches10 repliesSuperseded
v22 patches6 repliesSuperseded
v12 patches21 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2uio: uio_dfl: add userspace i/o driver for DFL busMAINTAINERS drivers/uio/Kconfig drivers/uio/Makefile +1 more+85 -00 replies
2/2Documentation: fpga: dfl: Add description for DFL UIO supportDocumentation/fpga/dfl.rst+26 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTom RixWu Hao
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 0/2] UIO support for dfl devices

This patchset supports some dfl device drivers written in userspace.

There are some Q&A about why UIO driver is needed in v11:

From Greg:
Why are you saying that an ethernet driver should be using the UIO interface?

And why can't you use the existing UIO drivers that bind to memory regions specified by firmware? Without an interrupt being used, why is UIO needed at all?

From Moritz:
Essentially I see two options:
- Have a DFL bus driver instantiate a platform driver (uio_pdrv_genirq) which I *think* you described above?
- What this patch implements -- a UIO driver on the DFL bus

These FPGA devices can on the fly change their contents and -- even if just for test -- being able to expose a bunch of registers via UIO can be extremely useful.

Whether a device should expose registers or not should be up to the implemeneter of the FPGA design I think (policy). This patch (or the previous version) provides a mechanism to do so via DFL.

This is similar in nature to uio_pdrv_genirq on a DT based platform, to expose the registers you instantiate the DT node.

Re-implementing a new driver for each of these instances doesn't seem desirable and tying DFL as enumeration mechanism to UIO seems like a good compromise for enabling this kind of functionality.

Note this is *not* an attempt to bypass the network stack or other existing subsystems.

See the original message in:
https://lore.kernel.org/linux-fpga/[email protected]/T/#m66ba2c96848e3dea38d1a4f16dfea3cb291f7975

From Yilun:
The ETH GROUP IP is not designed as the full functional ethernet controller. It is specially developed for the Intel N3000 NIC. Since it is an FPGA based card, it is designed for the users to runtime reload part of the MAC layer logic developed by themselves, while the ETH GROUP is another part of the MAC which is not expected to be reloaded by customers, but it provides some configurations for software to work with the user logic.

So I category the feature as the devices that "designed for specific purposes and does not fit into one of the standard kernel subsystems". Some related description could be found in Patch #2, to illustrate why using UIO for some DFL devices.

There are now UIO drivers for PCI or platform devices, but in this case we are going to export a DFL(Device Feature List) bus device to userspace, a DFL driver for UIO is needed to bind to it.

See the original message in:
https://lore.kernel.org/linux-fpga/[email protected]/T/#m91b303fd61485644353fad1e1e9c11d528844684

Xu Yilun (2):
uio: uio_dfl: add userspace i/o driver for DFL bus
Documentation: fpga: dfl: Add description for DFL UIO support

 Documentation/fpga/dfl.rst | 26 ++++++++++++++++++
 MAINTAINERS                |  1 +
 drivers/uio/Kconfig        | 17 ++++++++++++
 drivers/uio/Makefile       |  1 +
 drivers/uio/uio_dfl.c      | 66 ++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 111 insertions(+)
 create mode 100644 drivers/uio/uio_dfl.c
Signature · 1 line
2.7.4