Minor bug fixes and clean-up for MHI host driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 3 repliesIn review
- v16 patches 6 repliesSuperseded
Changes in v2 from the cover letter
-Removed the declaration for mhi_get_exec_env() from internal.h -Improved on the error log message in RDDM download exit case due to unknown EE
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()drivers/ | +0 | 0 replies | |
| 2/6 | bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state()drivers/ | +1 | 0 replies | |
| 3/6 | bus: mhi: core: Expose mhi_get_exec_env() API for controllersdrivers/ drivers/ include/ | +7 | 1 reply | |
| 4/6 | bus: mhi: core: Remove unused mhi_fw_load_worker() declarationdrivers/ | +0 | 0 replies | |
| 5/6 | bus: mhi: core: Rename RDDM download function to use proper wordsdrivers/ include/ | +5 | 0 replies | |
| 6/6 | bus: mhi: core: Skip RDDM download for unknown execution environmentdrivers/ | +7 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Manivannan Sadhasivam |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver
This patch series serves to clean up the MHI host driver by removing an unnecessary counter and an unused function. It also renames a function to make it clearly worded. There is currently no user of this exported function which makes it is safe to do so now.
Bug fixes include adding a missing EXPORT_SYMBOL_GPL to a function, and adding a return value check to bail out of RDDM download in kernel panic path.
An outlier among the group exports the mhi_get_exec_env() API for use by controller drivers, in case they need to determine behavior on the basis of the current execution environment.
This set of patches was tested on arm64.
v2:
-Removed the declaration for mhi_get_exec_env() from internal.h -Improved on the error log message in RDDM download exit case due to unknown EE
Bhaumik Bhatt (6):
bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state()
bus: mhi: core: Expose mhi_get_exec_env() API for controllers
bus: mhi: core: Remove unused mhi_fw_load_worker() declaration
bus: mhi: core: Rename RDDM download function to use proper words
bus: mhi: core: Skip RDDM download for unknown execution environment
drivers/bus/mhi/core/boot.c | 15 +++++++++------ drivers/bus/mhi/core/internal.h | 2 -- drivers/bus/mhi/core/main.c | 2 ++ include/linux/mhi.h | 12 +++++++++--- 4 files changed, 20 insertions(+), 11 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project