Serialize execution environment changes for MHI
Status from this message: This series was applied to qcom/linux.git (refs/heads/for-next):
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest4 patches 12 repliesApplied 4/4
- v53 patches 0 repliesSuperseded
- v43 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 0 replies | Superseded | |
| v2 | 3 patches | 5 replies | Superseded | |
| v1 | 2 patches | 0 replies | Superseded |
Changes in v6 from the cover letter
-Add patch to improve debug message
-Fix switch-case fall through warning for EE serialization patch -Address review comments and update commit text
Patches in v6 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | bus: mhi: core: Destroy SBL devices when moving to mission modedrivers/ drivers/ | +28 | 3 replies | Applied |
| 2/4 | bus: mhi: core: Download AMSS image from appropriate functiondrivers/ drivers/ drivers/ | +27 | 1 reply | Applied |
| 3/4 | bus: mhi: core: Process execution environment changes seriallydrivers/ drivers/ | +25 | 6 replies | Applied |
| 4/4 | bus: mhi: core: Update debug prints to include local device statedrivers/ | +4 | 1 reply | Applied |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Manivannan Sadhasivam | Hemant Kumar | Loic Poulain |
|---|---|---|---|
| 1/4 | R-b | R-b | R-b |
| 2/4 | R-b | R-b | |
| 3/4 | R-b | R-b | |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/4] Serialize execution environment changes for MHI
v6:
-Add patch to improve debug message
-Fix switch-case fall through warning for EE serialization patch -Address review comments and update commit text
v5:
-Update commit text for "clear devices when moving execution environments" patch -Added test platform details that were missed out in the cover letter -Merged two if checks in to a single one for EE serialization patch
v4:
-Addressed review comments for additional info logging for EE movements -Updated switch case for EE handling in mhi_intvec_threaded_handler()
v3:
-Update commit text to accurately reflect changes and reasoning based on reviews
v2:
-Add patch to clear devices when moving execution environments
Note: This patch is first in series of execution environment related changes.
During full boot chain firmware download, the PM state worker downloads the AMSS image after waiting for the SBL execution environment change in PBL mode itself. Since getting rid of the firmware load worker thread, this design needs to change and MHI host must download the AMSS image from the SBL mode of PM state worker thread instead of blocking waits for SBL EE in PBL transition processing.
Ensure that EE changes are handled only from appropriate places and occur one after another and handle only PBL or RDDM EE changes as critical events directly from the interrupt handler and the status callback is given to the controller drivers promptly.
When moving from SBL to AMSS EE, clear SBL specific client devices by calling remove callbacks for them so they are not left opened in a different execution environment.
This patchset was tested on ARM64.
Bhaumik Bhatt (4):
bus: mhi: core: Destroy SBL devices when moving to mission mode
bus: mhi: core: Download AMSS image from appropriate function
bus: mhi: core: Process execution environment changes serially
bus: mhi: core: Update debug prints to include local device state
drivers/bus/mhi/core/boot.c | 51 +++++++++++++-------------- drivers/bus/mhi/core/internal.h | 1 + drivers/bus/mhi/core/main.c | 76 +++++++++++++++++++++++++++-------------- drivers/bus/mhi/core/pm.c | 10 ++++-- 4 files changed, 83 insertions(+), 55 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project