Skip to content

XDP Redirect implementation for ENA driver

[email protected] netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 9 repliesIn review
  2. v39 patches 4 repliesSuperseded
  3. v2 RFC9 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 patches2 repliesSuperseded

Changes in v4 from the cover letter

-----------
Added an explanation to the decision of using netdev_* prints in functions that are also called before netdev is registered.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: ena: use constant value for net_device allocationdrivers/net/ethernet/amazon/ena/ena_netdev.c+23 -230 replies
2/9net: ena: add device distinct log prefix to filesdrivers/net/ethernet/amazon/ena/ena_com.c drivers/net/ethernet/amazon/ena/ena_com.h drivers/net/ethernet/amazon/ena/ena_eth_com.c +2 more+312 -1840 replies
3/9net: ena: add explicit casting to variablesdrivers/net/ethernet/amazon/ena/ena_com.c+5 -53 replies
4/9net: ena: fix coding style nitsdrivers/net/ethernet/amazon/ena/ena_eth_com.c drivers/net/ethernet/amazon/ena/ena_ethtool.c drivers/net/ethernet/amazon/ena/ena_netdev.h+6 -50 replies
5/9net: ena: aggregate stats increase into a functiondrivers/net/ethernet/amazon/ena/ena_netdev.c+68 -990 replies
6/9net: ena: use xdp_frame in XDP TX flowdrivers/net/ethernet/amazon/ena/ena_netdev.c+23 -232 replies
7/9net: ena: introduce XDP redirect implementationdrivers/net/ethernet/amazon/ena/ena_ethtool.c drivers/net/ethernet/amazon/ena/ena_netdev.c drivers/net/ethernet/amazon/ena/ena_netdev.h+47 -292 replies
8/9net: ena: use xdp_return_frame() to free xdp framesdrivers/net/ethernet/amazon/ena/ena_netdev.c drivers/net/ethernet/amazon/ena/ena_netdev.h+1 -80 replies
9/9net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECTdrivers/net/ethernet/amazon/ena/ena_netdev.c drivers/net/ethernet/amazon/ena/ena_netdev.h+72 -122 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH V4 net-next 0/9] XDP Redirect implementation for ENA driver

From: Arthur Kiyanovski <[email protected]>

V4 Changes:
-----------
Added an explanation to the decision of using netdev_* prints in functions that are also called before netdev is registered.

V3 Changes:
-----------
1. Removed RFC, the commits that this patchset relies on where merged from net already so no more conflicts are expected.

2. Fixed checkpatch errors.

V2 Changes:
---------------
1. Changed this to RFC, since we are waiting for the recently merged net patches to be merged so there will be no merge conflicts. But still would like to get review comments beforehand.

2. Removed the word "atomic" from the name of ena_increase_stat_atomic(), as it is indeed not atomic.

V1 Cover Letter:
----------------
Hi all,
ENA is adding XDP Redirect support for its driver and some other small tweaks.

This series adds the following:

- Make log messages in the driver have a uniform format using netdev_* function
- Improve code readability and add explicit masking
- Add support for XDP Redirect

Arthur Kiyanovski (9):
net: ena: use constant value for net_device allocation
net: ena: add device distinct log prefix to files
net: ena: add explicit casting to variables
net: ena: fix coding style nits
net: ena: aggregate stats increase into a function
net: ena: use xdp_frame in XDP TX flow
net: ena: introduce XDP redirect implementation
net: ena: use xdp_return_frame() to free xdp frames
net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECT

 drivers/net/ethernet/amazon/ena/ena_com.c     | 394 ++++++++++-------
 drivers/net/ethernet/amazon/ena/ena_com.h     |  21 +
 drivers/net/ethernet/amazon/ena/ena_eth_com.c |  71 ++--
 drivers/net/ethernet/amazon/ena/ena_eth_com.h |  23 +-
 drivers/net/ethernet/amazon/ena/ena_ethtool.c |   3 +-
 drivers/net/ethernet/amazon/ena/ena_netdev.c  | 395 ++++++++++--------
 drivers/net/ethernet/amazon/ena/ena_netdev.h  |  12 +-
 7 files changed, 544 insertions(+), 375 deletions(-)
Signature · 1 line
2.23.3