hw/ssi: imx_spi: Fix various bugs in the imx_spi model
Status from this message: Applied to target-arm.next, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest10 patches 2 repliesApplied
- v810 patches 17 repliesSuperseded
- v56 patches 0 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 6 patches | 11 replies | Superseded | |
| v3 | 6 patches | 5 replies | Superseded | |
| v2 posting 2/2 | 4 patches | 0 replies | Superseded | |
| v2 posting 1/2 | 2 patches | 11 replies | Superseded | |
| v1 | 2 patches | 2 replies | Superseded |
Changes in v9 from the cover letter
- Add a 'common_reset' function that does most of reset operation, leaving ECSPI_CONREG clear in imx_spi_reset().
- Do the LOG_UNIMP when the unsupported burst length value is written, rather than where it is used.
- Squash the 2 LOG_UNIMP warnings down into one line
Patches in v9 Applied
Reviews trailers per patch
9 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Alistair Francis | Philippe Mathieu-Daudé | Juan Quintela | Bin Meng | Peter Maydell |
|---|---|---|---|---|---|
| 1/10 | R-b | R-b | R-b | ||
| 2/10 | R-b | ||||
| 3/10 | R-b | R-b | |||
| 4/10 | R-b | ||||
| 5/10 | R-b | R-b | |||
| 6/10 | R-b | ||||
| 7/10 | R-b | ||||
| 8/10 | |||||
| 9/10 | R-b | ||||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v9 00/10] hw/ssi: imx_spi: Fix various bugs in the imx_spi model
From: Bin Meng <[email protected]>
Starting from v8, the series is based on the following 2 versions:
- v5 series sent from Bin
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=223919
- v7 series sent from Philippe
http://patchwork.ozlabs.org/project/qemu-devel/list/?series=224612
This series fixes a bunch of bugs in current implementation of the imx spi controller, including the following issues:
- remove imx_spi_update_irq() in imx_spi_reset()
- chip select signal was not lower down when spi controller is disabled
- round up the tx burst length to be multiple of 8
- transfer incorrect data when the burst length is larger than 32 bit
- spi controller tx and rx fifo endianness is incorrect
- remove pointless variable (s->burst_length) initialization (Philippe)
- rework imx_spi_reset() to keep CONREG register value (Philippe)
- rework imx_spi_read() to handle block disabled (Philippe)
- rework imx_spi_write() to handle block disabled (Philippe)
Tested with upstream U-Boot v2020.10 (polling mode) and VxWorks 7 (interrupt mode).
Changes in v9:
- Add a 'common_reset' function that does most of reset operation, leaving ECSPI_CONREG clear in imx_spi_reset().
- Do the LOG_UNIMP when the unsupported burst length value is written, rather than where it is used.
- Squash the 2 LOG_UNIMP warnings down into one line
Changes in v8:
- keep the controller disable logic in the ECSPI_CONREG case in imx_spi_write()
Changes in v7:
- remove the RFC tag
- remove the RFC tag
- remove the RFC tag
- remove the RFC tag
Changes in v6:
- new patch: [RFC] remove pointless variable initialization
- new patch: [RFC] rework imx_spi_reset() to keep CONREG register value
- new patch: [RFC] rework imx_spi_read() to handle block disabled
- new patch: [RFC] rework imx_spi_write() to handle block disabled
Changes in v5:
- rename imx_spi_hard_reset() to imx_spi_soft_reset()
- round up the burst length to be multiple of 8
Changes in v4:
- adujst the patch 2,3 order
- rename imx_spi_soft_reset() to imx_spi_hard_reset() to avoid confusion
- s/normal/common/ in the commit message
- log the burst length value in the log message
Changes in v3:
- new patch: remove imx_spi_update_irq() in imx_spi_reset()
- Move the chip selects disable out of imx_spi_reset()
- new patch: log unimplemented burst length
- Simplify the tx fifo endianness handling
Changes in v2:
- Fix the "Fixes" tag in the commit message
- Use ternary operator as Philippe suggested
Bin Meng (5):
hw/ssi: imx_spi: Use a macro for number of chip selects supported hw/ssi: imx_spi: Remove imx_spi_update_irq() in imx_spi_reset() hw/ssi: imx_spi: Round up the burst length to be multiple of 8 hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic hw/ssi: imx_spi: Correct tx and rx fifo endianness
Philippe Mathieu-Daudé (4):
hw/ssi: imx_spi: Remove pointless variable initialization hw/ssi: imx_spi: Rework imx_spi_reset() to keep CONREG register value hw/ssi: imx_spi: Rework imx_spi_read() to handle block disabled hw/ssi: imx_spi: Rework imx_spi_write() to handle block disabled
Xuzhou Cheng (1):
hw/ssi: imx_spi: Disable chip selects when controller is disabled
include/hw/ssi/imx_spi.h | 5 +- hw/ssi/imx_spi.c | 153 +++++++++++++++++++++++++-------------- 2 files changed, 101 insertions(+), 57 deletions(-)
Signature · 1 line
2.25.1