RFC s390x/pci: Fixing s390 vfio-pci ISM support
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | linux-headers: update against 5.10-rc7include/ include/ include/ +3 more | +52 | 0 replies | |
| 2/8 | s390x/pci: MSI-X isn't strictly required for passthroughhw/ | +8 | 4 replies | |
| 3/8 | s390x/pci: fix pcistb lengthhw/ | +2 | 3 replies | |
| 4/8 | s390x/pci: Introduce the ZpciOps structurehw/ hw/ include/ +1 more | +185 | 0 replies | |
| 5/8 | s390x/pci: Fix memory_region_access_valid callhw/ | +5 | 1 reply | |
| 6/8 | s390x/pci: Handle devices that support relaxed alignmenthw/ hw/ include/ | +24 | 0 replies | |
| 7/8 | s390x/pci: PCISTB via the vfio zPCI I/O regionhw/ hw/ hw/ +3 more | +149 | 0 replies | |
| 8/8 | s390x/pci: PCILG via the vfio zPCI I/O regionhw/ hw/ include/ +1 more | +64 | 0 replies |
Reviews trailers per patch
2 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Pierre Morel |
|---|---|
| 1/8 | |
| 2/8 | R-b |
| 3/8 | R-b |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC 0/8] s390x/pci: Fixing s390 vfio-pci ISM support
Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate) MSI-X check. Removing this fence, however, reveals additional deficiencies in the s390x PCI interception layer that prevent ISM devices from working correctly. Namely, ISM block write operations have particular requirements in regards to the alignment, size and order of writes performed that cannot be guaranteed when breaking up write operations through the typical vfio_pci_bar_rw paths. Furthermore, ISM requires that legacy/non-MIO s390 PCI instructions are used, which is also not guaranteed when the I/O is passed through the typical userspace channels.
This patchset provides a set of fixes related to enabling ISM device passthrough and includes patches to enable use of a new vfio region that will allow s390x PCI pass-through devices to perform s390 PCI instructions in such a way that the same instruction issued on the guest is re-issued on the host.
The region is intended for use with ISM devices specifically, as they do not implement MSI-X and thus transferring I/O in this manner will not interfere with vfio-pci MSI-X masking. If someone can think of a good way to also make this MSI-X compatible (and thus usable by other device types besides ISM), I'm open to suggestions...
Associated kernel patchset:
https://lkml.org/lkml/2020/12/9/1059
Matthew Rosato (8):
linux-headers: update against 5.10-rc7 s390x/pci: MSI-X isn't strictly required for passthrough s390x/pci: fix pcistb length
s390x/pci: Introduce the ZpciOps structure s390x/pci: Fix memory_region_access_valid call s390x/pci: Handle devices that support relaxed alignment s390x/pci: PCISTB via the vfio zPCI I/O region s390x/pci: PCILG via the vfio zPCI I/O region
hw/s390x/s390-pci-bus.c | 32 ++- hw/s390x/s390-pci-inst.c | 289 ++++++++++++++------- hw/s390x/s390-pci-vfio.c | 164 ++++++++++++ include/hw/s390x/s390-pci-bus.h | 24 ++ include/hw/s390x/s390-pci-clp.h | 1 + include/hw/s390x/s390-pci-inst.h | 3 + include/hw/s390x/s390-pci-vfio.h | 23 ++ include/standard-headers/asm-x86/kvm_para.h | 1 + .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- include/standard-headers/linux/vhost_types.h | 9 + linux-headers/linux/vfio.h | 4 + linux-headers/linux/vfio_zdev.h | 33 +++ linux-headers/linux/vhost.h | 4 + 13 files changed, 486 insertions(+), 103 deletions(-)
Signature · 1 line
1.8.3.1