Skip to content

RFC support global syntax

Xueming Li dpdk-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9devargs: fix data buffer storage typeexamples/vdpa/main.c lib/librte_eal/common/eal_common_dev.c lib/librte_eal/include/rte_dev.h +1 more+7 -6116 replies
2/9devargs: fix memory leak on parsing errorlib/librte_eal/common/eal_common_devargs.c+5 -00 replies
3/9devargs: fix memory leak in legacy parserlib/librte_eal/common/eal_common_devargs.c+4 -30 replies
4/9devargs: fix buffer data memory leakapp/test-pmd/config.c app/test-pmd/testpmd.c drivers/bus/vdev/vdev.c +7 more+25 -220 replies
5/9kvargs: add get by key functionlib/librte_kvargs/rte_kvargs.c lib/librte_kvargs/rte_kvargs.h lib/librte_kvargs/version.map+35 -00 replies
6/9devargs: support new global device syntaxlib/librte_eal/common/eal_common_devargs.c+17 -00 replies
7/9bus/pci: add new global device syntax supportdrivers/bus/pci/pci_common.c+15 -30 replies
8/9common/mlx5: support device global syntaxdrivers/common/mlx5/mlx5_common_pci.c+5 -10 replies
9/9net/mlx5: support new device global syntaxdrivers/net/mlx5/linux/mlx5_os.c drivers/net/mlx5/mlx5.c+21 -30 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchViacheslav OvsiienkoGaetan RivetRay Kinsella
1/9A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b R-b A-b A-b A-b
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [dpdk-dev] [RFC 0/9] support global syntax

New Global device syntax [1] is used to identify a device with full bus, class and driver description, example:
-a bus=pci,id=82:00.0/class=eth/driver=mlx5,dv_flow_en=1

This patch try to enable global syntax with backward compatibility by trying to new global syntax firstle and fallback to legacy parsing.

For PCI device, BDF is retrived from the "id" attribute of bus section, parse from device name if "id" not available.

[1]:
https://www.dpdk.org/wp-content/uploads/sites/35/2018/10/am-07-DPDK-hotplug-20180905.pdf

Xueming Li (9):
devargs: fix data buffer storage type
devargs: fix memory leak on parsing error
devargs: fix memory leak in legacy parser
devargs: fix buffer data memory leak
kvargs: add get by key function
devargs: support new global device syntax
bus/pci: add new global device syntax support
common/mlx5: support device global syntax
net/mlx5: support new device global syntax

 app/test-pmd/config.c                        |  4 +--
 app/test-pmd/testpmd.c                       |  4 +--
 drivers/bus/pci/pci_common.c                 | 18 ++++++++--
 drivers/bus/vdev/vdev.c                      |  5 +--
 drivers/common/mlx5/mlx5_common_pci.c        |  6 +++-
 drivers/net/failsafe/failsafe_args.c         |  3 +-
 drivers/net/failsafe/failsafe_eal.c          |  2 +-
 drivers/net/mlx5/linux/mlx5_os.c             | 18 ++++++++--
 drivers/net/mlx5/mlx5.c                      |  6 +++-
 examples/multi_process/hotplug_mp/commands.c |  8 ++---
 examples/vdpa/main.c                         |  6 ++--
 lib/librte_eal/common/eal_common_dev.c       |  7 ++--
 lib/librte_eal/common/eal_common_devargs.c   | 36 ++++++++++++++++----
 lib/librte_eal/common/hotplug_mp.c           |  5 ++-
 lib/librte_eal/include/rte_dev.h             |  2 +-
 lib/librte_eal/include/rte_devargs.h         |  2 +-
 lib/librte_ethdev/rte_ethdev.c               |  5 +--
 lib/librte_kvargs/rte_kvargs.c               | 20 +++++++++++
 lib/librte_kvargs/rte_kvargs.h               | 14 ++++++++
 lib/librte_kvargs/version.map                |  1 +
 20 files changed, 134 insertions(+), 38 deletions(-)
Signature · 1 line
2.25.1