Skip to content

bnxt_en: Error recovery improvements.

Michael Chan netdev 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/15bnxt_en: Update firmware interface to 1.10.2.11.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h+203 -530 replies
2/15bnxt_en: Define macros for the various health register states.drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c+13 -40 replies
3/15bnxt_en: handle CRASH_NO_MASTER during bnxt_open()drivers/net/ethernet/broadcom/bnxt/bnxt.c+39 -280 replies
4/15bnxt_en: Retry sending the first message to firmware if it is under reset.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+42 -70 replies
5/15bnxt_en: Move reading VPD info after successful handshake with fw.drivers/net/ethernet/broadcom/bnxt/bnxt.c+3 -30 replies
6/15bnxt_en: Add an upper bound for all firmware command timeouts.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+3 -00 replies
7/15bnxt_en: log firmware debug notificationsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+8 -01 reply
8/15bnxt_en: attempt to reinitialize after aborted resetdrivers/net/ethernet/broadcom/bnxt/bnxt.c+27 -20 replies
9/15bnxt_en: Retry open if firmware is in reset.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+14 -20 replies
10/15bnxt_en: Add bnxt_fw_reset_timeout() helper.drivers/net/ethernet/broadcom/bnxt/bnxt.c+9 -60 replies
11/15bnxt_en: Add a new BNXT_STATE_NAPI_DISABLED flag to keep track of NAPI state.drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+4 -10 replies
12/15bnxt_en: Modify bnxt_disable_int_sync() to be called more than once.drivers/net/ethernet/broadcom/bnxt/bnxt.c+3 -00 replies
13/15bnxt_en: Improve firmware fatal error shutdown sequence.drivers/net/ethernet/broadcom/bnxt/bnxt.c+10 -30 replies
14/15bnxt_en: Consolidate firmware reset event logging.drivers/net/ethernet/broadcom/bnxt/bnxt.c+10 -70 replies
15/15bnxt_en: Do not process completion entries after fatal condition detected.drivers/net/ethernet/broadcom/bnxt/bnxt.c+8 -00 replies

Reviews trailers per patch

11 of 15 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEdwin PeerPavan ChebbiVasundhara VolamAndy GospodarekWillem de Bruijn
SeriesA-b
1/15
2/15R-b
3/15
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15
9/15
10/15R-b
11/15R-b R-b R-b R-b
12/15R-b R-b
13/15R-b R-b
14/15R-b
15/15R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 00/15] bnxt_en: Error recovery improvements.

This series contains a number of improvements in the area of error recovery. Most error recovery scenarios are tightly coordinated with the firmware. A number of patches add retry logic to establish connection with the firmware if there are indications that the firmware is still alive and will likely transition back to the normal state. Some patches speed up the recovery process and make it more reliable. There are some cleanup patches as well.

Edwin Peer (3):
bnxt_en: handle CRASH_NO_MASTER during bnxt_open()
bnxt_en: log firmware debug notifications
bnxt_en: attempt to reinitialize after aborted reset

Michael Chan (9):
bnxt_en: Update firmware interface to 1.10.2.11.
bnxt_en: Define macros for the various health register states.
bnxt_en: Retry sending the first message to firmware if it is under
reset.
bnxt_en: Add bnxt_fw_reset_timeout() helper.
bnxt_en: Add a new BNXT_STATE_NAPI_DISABLED flag to keep track of NAPI
state.
bnxt_en: Modify bnxt_disable_int_sync() to be called more than once.
bnxt_en: Improve firmware fatal error shutdown sequence.
bnxt_en: Consolidate firmware reset event logging.
bnxt_en: Do not process completion entries after fatal condition
detected.

Vasundhara Volam (3):
bnxt_en: Move reading VPD info after successful handshake with fw.
bnxt_en: Add an upper bound for all firmware command timeouts.
bnxt_en: Retry open if firmware is in reset.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 228 ++++++++++++----
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  22 ++
 .../net/ethernet/broadcom/bnxt/bnxt_devlink.c |   7 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 249 ++++++++++++++----
 4 files changed, 393 insertions(+), 113 deletions(-)
Signature · 1 line
2.18.1