Skip to content

acpi: Error Record Serialization Table, ERST, support for QEMU

Eric DeVolder qemu-devel 14 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest10 patches 1 replyIn review
  2. v1410 patches 10 repliesSuperseded
  3. v1310 patches 10 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v129 patches0 repliesSuperseded
v1110 patches6 repliesSuperseded
v1010 patches9 repliesSuperseded
v910 patches20 repliesSuperseded
v810 patches10 repliesSuperseded
v710 patches8 repliesSuperseded
v610 patches23 repliesSuperseded
v510 patches47 repliesSuperseded
v46 patches6 repliesSuperseded
v37 patches7 repliesSuperseded
v27 patches16 repliesSuperseded

Patches in v15 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ACPI ERST: bios-tables-test.c steps 1 and 2tests/data/acpi/microvm/ERST.pcie tests/data/acpi/pc/DSDT.acpierst tests/data/acpi/pc/ERST.acpierst +3 more+5 -00 replies
2/10ACPI ERST: specification for ERST supportdocs/specs/acpi_erst.rst+200 -01 reply
3/10ACPI ERST: PCI device_id for ERSTinclude/hw/pci/pci.h+1 -00 replies
4/10ACPI ERST: header file for ERSTinclude/hw/acpi/erst.h+19 -00 replies
5/10ACPI ERST: support for ACPI ERST featurehw/acpi/Kconfig hw/acpi/erst.c hw/acpi/meson.build +1 more+866 -00 replies
6/10ACPI ERST: build the ACPI ERST tablehw/acpi/erst.c+211 -00 replies
7/10ACPI ERST: create ACPI ERST table for pc/x86 machineshw/i386/acpi-build.c hw/i386/acpi-microvm.c include/hw/acpi/erst.h+35 -00 replies
8/10ACPI ERST: qtest for ERSTtests/qtest/erst-test.c tests/qtest/meson.build+174 -00 replies
9/10ACPI ERST: bios-tables-test testcasetests/qtest/bios-tables-test.c+54 -00 replies
10/10ACPI ERST: step 6 of bios-tables-test.ctests/data/acpi/microvm/ERST.pcie tests/data/acpi/pc/DSDT.acpierst tests/data/acpi/pc/ERST.acpierst +3 more+0 -50 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovAni Sinha
1/10A-b
2/10A-b
3/10A-b A-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [PATCH v15 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

This patchset introduces support for the ACPI Error Record Serialization Table, ERST.

For background and implementation information, please see docs/specs/acpi_erst.rst, which is patch 2/10.

---
v15: 28jan2022
- Changes to build_erst() and ACTION/VALUE context struct setup, per Michael.

v14: 26jan2022
- Changed build_erst() to utilize a context structure for generating accesses to ACTION and VALUE, per Michael Tsirkin.
- Other simplification per Ani Sinha.

v13: 24jan2022
- v12 erroneously omitted step 6 of bios-tables-test.c, this has step 6 included.
- No other changes to v12.

v12: 10jan2022
- Converted macros in build_erst() to uppert to follow coding style, as pointed out by Michael Tsirkin.
- And few items to help further simplify build_erst().

v11: 15dec2021
- Simplified build_erst() via feedback from Michael Tsirkin
- Addressed additional feedback from Ani Sinha

v10: 9dec2021
- Addressed additional feedback from Ani Sinha

v9: 2dec2021
- Addressed feedback from Ani Sinha

v8: 15oct2021
- Added Kconfig option for ERST, per Ani Sinha
- Fixed patch ordering, per Ani

v7: 7oct2021
- style improvements, per Igor
- use of endian accessors for storage header, per Igor
- a number of optimizations and improvements, per Igor
- updated spec for header, per Igor
- updated spec for rst format, per Michael Tsirkin
- updated spec for new record_size parameter Due to changes in the spec, I am not carrying the Acked-by from Ani Sinha.
- changes for and testing of migration to systems with differing ERST_RECORD_SIZE

v6: 5aug2021
- Fixed compile warning/error, per Michael Tsirkin
- Fixed mingw32 build error, per Michael
- Converted exchange buffer to MemoryBackend, per Igor
- Migrated test to PCI, per Igor
- Significantly reduced amount of copying, per Igor
- Corrections/enhancements to acpi_erst.txt, per Igor
- Many misc/other small items, per Igor

v5: 30jun2021
- Create docs/specs/acpi_erst.txt, per Igor
- Separate PCI BARs for registers and memory, per Igor
- Convert debugging to use trace infrastructure, per Igor
- Various other fixups, per Igor

v4: 11jun2021
- Converted to a PCI device, per Igor.
- Updated qtest.
- Rearranged patches, per Igor.

v3: 28may2021
- Converted to using a TYPE_MEMORY_BACKEND_FILE object rather than internal array with explicit file operations, per Igor.
- Changed the way the qdev and base address are handled, allowing ERST to be disabled at run-time. Also aligns better with other existing code.

v2: 8feb2021
- Added qtest/smoke test per Paolo Bonzini
- Split patch into smaller chunks, per Igor Mammedov
- Did away with use of ACPI packed structures, per Igor Mammedov

v1: 26oct2020
- initial post

---
Eric DeVolder (10):
ACPI ERST: bios-tables-test.c steps 1 and 2 ACPI ERST: specification for ERST support ACPI ERST: PCI device_id for ERST
ACPI ERST: header file for ERST
ACPI ERST: support for ACPI ERST feature ACPI ERST: build the ACPI ERST table
ACPI ERST: create ACPI ERST table for pc/x86 machines ACPI ERST: qtest for ERST
ACPI ERST: bios-tables-test testcase
ACPI ERST: step 6 of bios-tables-test.c

 docs/specs/acpi_erst.rst          |  200 +++++++
 hw/acpi/Kconfig                   |    6 +
 hw/acpi/erst.c                    | 1055 +++++++++++++++++++++++++++++++++++++
 hw/acpi/meson.build               |    1 +
 hw/acpi/trace-events              |   15 +
 hw/i386/acpi-build.c              |   15 +
 hw/i386/acpi-microvm.c            |   15 +
 include/hw/acpi/erst.h            |   24 +
 include/hw/pci/pci.h              |    1 +
 tests/data/acpi/microvm/ERST.pcie |  Bin 0 -> 912 bytes
 tests/data/acpi/pc/DSDT.acpierst  |  Bin 0 -> 5969 bytes
 tests/data/acpi/pc/ERST.acpierst  |  Bin 0 -> 912 bytes
 tests/data/acpi/q35/DSDT.acpierst |  Bin 0 -> 8306 bytes
 tests/data/acpi/q35/ERST.acpierst |  Bin 0 -> 912 bytes
 tests/qtest/bios-tables-test.c    |   54 ++
 tests/qtest/erst-test.c           |  172 ++++++
 tests/qtest/meson.build           |    2 +
 17 files changed, 1560 insertions(+)
 create mode 100644 docs/specs/acpi_erst.rst
 create mode 100644 hw/acpi/erst.c
 create mode 100644 include/hw/acpi/erst.h
 create mode 100644 tests/data/acpi/microvm/ERST.pcie
 create mode 100644 tests/data/acpi/pc/DSDT.acpierst
 create mode 100644 tests/data/acpi/pc/ERST.acpierst
 create mode 100644 tests/data/acpi/q35/DSDT.acpierst
 create mode 100644 tests/data/acpi/q35/ERST.acpierst
 create mode 100644 tests/qtest/erst-test.c
Signature · 1 line
1.8.3.1