app/testpmd: enable testpmd on Windows
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v16 Latest9 patches 3 repliesApplied
- v159 patches 0 repliesSuperseded
- v149 patches 12 repliesSuperseded
Earlier versions · 13
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v13 | 10 patches | 15 replies | Superseded | |
| v12 | 10 patches | 0 replies | Superseded | |
| v11 | 10 patches | 0 replies | Superseded | |
| v10 | 10 patches | 6 replies | Superseded | |
| v9 | 10 patches | 14 replies | Superseded | |
| v8 | 10 patches | 0 replies | Superseded | |
| v7 | 10 patches | 0 replies | Superseded | |
| v6 | 10 patches | 2 replies | Superseded | |
| v5 | 9 patches | 12 replies | Superseded | |
| v4 | 9 patches | 0 replies | Superseded | |
| v3 | 6 patches | 12 replies | Superseded | |
| v2 | 1 patch | 9 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Changes in v16 from the cover letter
- Manually change Patch #9 From: email address to a proper one
Patches in v16 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | lib: build libraries that testpmd depends onlib/ | +7 | 0 replies | |
| 2/9 | eal/windows: add necessary macroslib/ | +9 | 0 replies | |
| 3/9 | eal/windows: add device event stubslib/ lib/ | +34 | 0 replies | |
| 4/9 | eal/Windows: add clock_gettime on Windowslib/ | +33 | 0 replies | |
| 5/9 | app/testpmd: resolve name collisionsapp/ | +256 | 1 reply | |
| 6/9 | app/testpmd: fix parse_fec_mode return type nameapp/ app/ app/ | +6 | 1 reply | |
| 7/9 | app/testpmd: replace POSIX specific codeapp/ app/ app/ +5 more | +37 | 0 replies | |
| 8/9 | app/testpmd: fix unused function warningsapp/ | +41 | 0 replies | |
| 9/9 | app/testpmd: enable building testpmd on Windowsapp/ app/ app/ +12 more | +84 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Dmitry Kozlyuk | Pallavi Kadam | Tal Shnaiderman | Andrew Rybchenko |
|---|---|---|---|---|
| Series | T-b A-b | A-b | ||
| 1/9 | A-b | |||
| 2/9 | A-b | A-b | ||
| 3/9 | A-b | A-b | ||
| 4/9 | A-b | |||
| 5/9 | A-b | A-b | ||
| 6/9 | R-b | |||
| 7/9 | A-b | A-b | ||
| 8/9 | A-b | A-b | ||
| 9/9 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [dpdk-dev] [PATCH v16 0/9] app/testpmd: enable testpmd on Windows
This patchset is to enable testpmd on windows. It mainly includes:
- Enable building libraries on Windows that testpmd depends on
- Add necessary macros required by testpmd on Windows in rte_os_shim.h
- Add device event stubs for Windows
- Resolve name collisions with Windows types
- Add clock_gettime in testpmd on Windows
- Fix parse_fec_mode to return fec_capa instead of mode
- Replace POSIX specific codes
- Disable unsupported Apps build on Windows
- Enable testpmd build on Windows
Future work:
- Some issues discovered at validation need further investigations
* Perf inconsistency: TPUT fluctuated significantly from runs
* After traffic stop, port stats shows pps being 0 while bps not
* mempool allocation only succeed with native. Other methods failed at rte_mem_lock/VirtualLock.
- Hot-plug on Windows not supported yet
- Support mempool allocation native mode only for now
---
V16 changes:
- Manually change Patch #9 From: email address to a proper one
---
V15 changes:
- Remove unnecessary Signed-off-by
- Fix Patch #6 description to explain the root cause
- Remove a trailing whitespace in Patch #4
---
V14 changes:
- Use macros with arguments
- Add missing spaces around '&'
- Remove unnecessary constants
- Remove unnecessary returned result check on QueryPerformanceXXX
---
V13 changes:
- Resolve a patchset apply issue in patch2
---
V12 changes:
- Fix indentation
---
V11 changes:
- Add Acked-by from V9 and V10
- Fix an error at ifndef'ing err flow for MP_ALLOC_NATIVE
---
V10 changes:
- Remove unneeded newline in config.c
- Add Fixes: and Cc: Stable for parse_fec_mode fix
- More appropriate and granular commit messages
- Use US_PER_S
- Put signal inside ifndef
---
V9 changes:
- Add clock_gettime for Windows into eal in rte_os_shim.h
---
V8 changes:
- Fix pointer location for _clock_gettime in config.h
---
V7 changes:
- Resolve V6 patch set applying conflicts due to recent upstream merges of linux testpmd changes, lib\meson.build format change, lib path changes, and sources change in meson.build under app\
- Move Windows clock_gettime related code from config.c into config.h and leverage rte_os_shim.h for timespec_get
- Fix a "BAD_SIGN_OFF" warning for patch "[v6,09/10] app/testpmd:
fix unused function warnings"
---
V6 changes:
- Fix "unused function" compilation warning when neither i40e nor ixgbe presents
---
V5 changes:
- Remove macro trailing semicolon which missed to include in V4
---
V4 changes:
- Split previous patch into more granular patches
- Remove the bypass of rte_eal_cleanup at exit
- Move all added macros into rte_os_shim.h
- Remove redundant headers after the rte_os_shim patch merge
- Revert the mman APIs replacement to leave relevant part UNIX only
- Keep Windows library list the same structure and order as the Unix library list in lib meson.build
---
V3 changes:
- Split one patch into patchset
- Replace mman APIs with rte_mem_xxx APIs
- Use OS independant rte_rand
- Add device event stubs for Windows
- Disable unsupported Apps
---
V2 changes:
- Fix commit message log long line issue
- Fix coding style issues of pointer location
- Fix indentation issue
- Fix FreeBSD2101 compilation issue of AF_INET undeclared
---
Jie Zhou (9):
lib: build libraries that testpmd depends on eal/windows: add necessary macros eal/windows: add device event stubs eal/Windows: add clock_gettime on Windows app/testpmd: resolve name collisions app/testpmd: fix parse_fec_mode return type name app/testpmd: replace POSIX specific code app/testpmd: fix unused function warnings app/testpmd: enable building testpmd on Windows
app/meson.build | 4 - app/pdump/meson.build | 6 + app/proc-info/meson.build | 6 + app/test-acl/meson.build | 6 + app/test-bbdev/meson.build | 6 + app/test-cmdline/meson.build | 6 + app/test-compress-perf/meson.build | 6 + app/test-crypto-perf/meson.build | 6 + app/test-eventdev/meson.build | 6 + app/test-fib/meson.build | 6 + app/test-flow-perf/meson.build | 6 + app/test-pipeline/meson.build | 6 + app/test-pmd/cmdline.c | 12 +- app/test-pmd/cmdline_flow.c | 514 +++++++++++++------------- app/test-pmd/config.c | 86 ++--- app/test-pmd/csumonly.c | 2 +- app/test-pmd/icmpecho.c | 4 +- app/test-pmd/ieee1588fwd.c | 8 +- app/test-pmd/parameters.c | 11 +- app/test-pmd/testpmd.c | 21 +- app/test-pmd/testpmd.h | 5 +- app/test-regex/meson.build | 6 + app/test-sad/meson.build | 6 + app/test/meson.build | 6 + lib/eal/windows/eal_dev.c | 33 ++ lib/eal/windows/include/rte_os_shim.h | 42 +++ lib/eal/windows/meson.build | 1 + lib/meson.build | 7 + 28 files changed, 507 insertions(+), 327 deletions(-) create mode 100644 lib/eal/windows/eal_dev.c
Signature · 1 line
2.31.0.vfs.0.1