Skip to content

s390x: Testing SSCH, CSCH and HSCH for errors

Pierre Morel kvm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 13 repliesIn review
  2. v28 patches 42 repliesSuperseded
  3. v16 patches 18 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16s390x: lib: css: disabling a subchannellib/s390x/css.h lib/s390x/css_lib.c+64 -00 replies
2/16s390x: lib: css: SCSW bit definitionslib/s390x/css.h+23 -00 replies
3/16s390x: css: simplify skipping tests on no devices390x/css.c+14 -222 replies
4/16s390x: lib: css: separate wait for IRQ and check I/O completionlib/s390x/css.h lib/s390x/css_lib.c+20 -150 replies
5/16s390x: lib: css: add SCSW ctrl expectations to check I/O completionlib/s390x/css.h lib/s390x/css_lib.c s390x/css.c+20 -90 replies
6/16s390x: lib: css: checking I/O errorslib/s390x/css.h lib/s390x/css_lib.c+28 -20 replies
7/16s390x: css: testing ssch errorss390x/css.c+68 -40 replies
8/16s390x: css: ssch check for cpa zerolib/s390x/css.h lib/s390x/css_lib.c s390x/css.c+16 -20 replies
9/16s390x: css: ssch with mis aligned ORBs390x/css.c+21 -00 replies
10/16s390x: css: ssch checking addressing errorss390x/css.c s390x/unittests.cfg+85 -20 replies
11/16s390x: css: No support for MIDAWs390x/css.c+13 -03 replies
12/16s390x: css: Check ORB reserved bitss390x/css.c+21 -03 replies
13/16s390x: css: checking for CSS extensionslib/s390x/css.h s390x/css.c+33 -02 replies
14/16s390x: css: issuing SSCH when the channel is status pendinglib/s390x/css.h s390x/css.c+12 -02 replies
15/16s390x: css: testing halt subchannellib/s390x/css.h lib/s390x/css_lib.c s390x/css.c+71 -00 replies
16/16s390x: css: testing clear subchannels390x/css.c+64 -00 replies

Reviews trailers per patch

2 of 16 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckJanosch FrankClaudio ImbrendaThomas Huth
1/16R-b A-b
2/16R-b R-b R-b
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 00/16] s390x: Testing SSCH, CSCH and HSCH for errors

The goal of this series is to test some of the I/O instructions, SSCH, CSCH and HSCH for errors like invalid parameters, addressing, timing etc.
We can not test the sending of an instruction before the last instruction has been proceeded by QEMU due to the QEMU serialization but we can check the behavior of an instruction if it is started before the status of the last instruction is read.

To do this we first separate the waiting for the interruption and the checking of the IRB and enable the subchannel without an I/O ISC to avoid interruptions at this subchannel and second, we add an argument to the routine in charge to check the IRB representing the expected SCSW control field of the IRB.

We also need several other enhancements to the testing environment:

- definitions for the SCSW control bits
- a new function to disable a subchannel
- a macro to simplify skiping tests when no device is present (I know the warning about return in macro, can we accept it?)

In the new tests we assume that all the test preparation is working and use asserts for all function for which we do not expect a failure.

regards,
Pierre

PS: Sorry, I needed to modify patches 4 and 5 for which I already had RB or AB.
I removed them even I hope you will agree with my modifications.

Pierre Morel (16):
s390x: lib: css: disabling a subchannel
s390x: lib: css: SCSW bit definitions
s390x: css: simplify skipping tests on no device
s390x: lib: css: separate wait for IRQ and check I/O completion
s390x: lib: css: add SCSW ctrl expectations to check I/O completion
s390x: lib: css: checking I/O errors
s390x: css: testing ssch errors
s390x: css: ssch check for cpa zero
s390x: css: ssch with mis aligned ORB
s390x: css: ssch checking addressing errors
s390x: css: No support for MIDAW
s390x: css: Check ORB reserved bits
s390x: css: checking for CSS extensions
s390x: css: issuing SSCH when the channel is status pending
s390x: css: testing halt subchannel
s390x: css: testing clear subchannel

 lib/s390x/css.h     |  42 ++++-
 lib/s390x/css_lib.c | 138 ++++++++++++--
 s390x/css.c         | 425 +++++++++++++++++++++++++++++++++++++++++---
 s390x/unittests.cfg |   8 +-
 4 files changed, 565 insertions(+), 48 deletions(-)
Signature · 42 lines
2.17.1

log:

from v2:

- modified the patch 3 simplifying the check for no device
  to move the check once for all in the main
  (Thomas)

- modified the patch 4 separate wait for IRQ..
  to move the check for IRQ parameters inside the IRQ routine
  (Pierre)

- modified the patch 5 checking for expectations on I/O
  to return with success if the expectation is matched without
  further checks.
  (Pierre)

- rewords patch 5 commet and commit message
  (Connie)

- reworked patches on SSCH addressing memory
  (Claudio)


from v1:

- rework the buggy interrupt handling
  (Connie)

- identation and comments changes in "disabling subchannel"
  (Janosch)

- Bit definition naming
  (Connie)

- use get_ram_size() to get the maximal address
  (Janosch)

- better comments for SSCH (hopefully)
  (Pierre)