Skip to content

x86/kprobes: Fix and cleanup can_boost()

Masami Hiramatsu kernel-janitors lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/core branch of tip:

Get series with b4
b4 am 161666690060.1120877.4569379871114610764.stgit@devnote2

Versions newest first

  1. v1 Latest2 patches 0 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86/kprobes: Fix to check non boostable prefixes correctlyarch/x86/kernel/kprobes/core.c+12 -50 replies
2/2x86/kprobes: Fix to identify indirect jmp and others using range casearch/x86/kernel/kprobes/core.c+20 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH -tip 0/2] x86/kprobes: Fix and cleanup can_boost()

Hi,

Here are 2 bugfixes for the x86/kprobes, [1/2] fixes an old bug which tries to find instruction prefixes in insn->opcode (which should be never found) and misusing insn->attr. [2/2] fixes a new bug found by Coverity in the recent commit 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for single-step").
To fix the 2nd one, [2/2] also cleanup the switch-case with range cases, because that is much more clear what is not boostable.

Thank you,

---

Masami Hiramatsu (2):
x86/kprobes: Fix to check non boostable prefixes correctly x86/kprobes: Fix to identify indirect jmp and others using range case

 arch/x86/kernel/kprobes/core.c |   57 +++++++++++++++++++++-------------------
 1 file changed, 30 insertions(+), 27 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>