Skip to content

Introduce hba performance monitoring sysfs nodes

Can Guo linux-scsi lkml 4 versions – Applied

Status from this message: Applied to 5.14/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 6 repliesApplied
  2. v42 patches 5 repliesSuperseded
  3. v32 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v22 patches5 repliesSuperseded

Changes in v5 from the cover letter

- Use lrbp->compl_time_stamp as now in ufshcd_update_monitor()

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: ufs: Introduce hba performance monitor sysfs nodesdrivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+320 -03 replies
2/2scsi: ufs: Add support for hba performance monitorDocumentation/ABI/testing/sysfs-driver-ufs+126 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaejun ParkBean Huo
SeriesR-b
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] Introduce hba performance monitoring sysfs nodes

Add a new sysfs group which has nodes to monitor data/request transfer performance. This sysfs group has nodes showing total sectors/requests transferred, total busy time spent and max/min/avg/sum latencies. This group can be enhanced later to show more UFS driver layer performance data during runtime.

It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor # echo 4096 > monitor_chunk_size /sys/bus/platform/drivers/ufshcd/*/monitor # echo 1 > monitor_enable /sys/bus/platform/drivers/ufshcd/*/monitor # grep ^ /dev/null * monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928

Change since v4:
- Use lrbp->compl_time_stamp as now in ufshcd_update_monitor()

Change since v3:
- Rebased

Change since v2:
- Fixed a sparse error

Change since v1:
- Moved code from ufs-qcom.c to ufshcd.c

Can Guo (2):
scsi: ufs: Introduce hba performance monitor sysfs nodes
scsi: ufs: Add support for hba performance monitor

 Documentation/ABI/testing/sysfs-driver-ufs | 126 +++++++++++++++
 drivers/scsi/ufs/ufs-sysfs.c               | 237 +++++++++++++++++++++++++++++
 drivers/scsi/ufs/ufshcd.c                  |  62 ++++++++
 drivers/scsi/ufs/ufshcd.h                  |  21 +++
 4 files changed, 446 insertions(+)
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.