Skip to content

Complementary changes for error handling

Can Guo linux-arm-msm linux-scsi lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest10 patches 47 repliesIn review
  2. v39 patches 34 repliesSuperseded
  3. v26 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Split the first change in v2 into 2 changes (to address comments from Adrian)
- Removed the host_sem used in suspend/resume and use lock/unlock_system_sleep() in error handler (suggested by Bart).

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspendeddrivers/scsi/ufs/ufs-qcom.c drivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+20 -1813 replies
2/10scsi: ufs: Add flags pm_op_in_progress and is_sys_suspendeddrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+15 -16 replies
3/10scsi: ufs: Update the return value of supplier pm opsdrivers/scsi/ufs/ufshcd.c+2 -22 replies
4/10scsi: ufs: Enable IRQ after enabling clocks in error handling preparationdrivers/scsi/ufs/ufshcd.c+3 -21 reply
5/10scsi: ufs: Complete the cmd before returning in queuecommanddrivers/scsi/ufs/ufshcd.c+10 -91 reply
5/10scsi: ufs: Remove a redundant tag check in ufshcd_queuecommand()drivers/scsi/ufs/ufshcd.c+0 -91 reply
6/10scsi: ufs: Remove host_sem used in suspend/resumedrivers/scsi/ufs/ufshcd.c+7 -515 replies
7/10scsi: ufs: Simplify error handling preparationdrivers/scsi/ufs/ufshcd.c+30 -261 reply
8/10scsi: ufs: Update ufshcd_recover_pm_error()drivers/scsi/ufs/ufshcd.c+21 -280 replies
9/10scsi: ufs: Update the fast abort path in ufshcd_abort() for PM requestsdrivers/scsi/ufs/ufshcd.c+21 -153 replies
10/10scsi: ufs: Apply more limitations to user accessdrivers/scsi/ufs/ufs-debugfs.c drivers/scsi/ufs/ufs-sysfs.c drivers/scsi/ufs/ufs_bsg.c +2 more+101 -1274 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchBart Van Assche
1/10
2/10
3/10
4/10R-b
5/10R-b
5/10R-b
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/10] Complementary changes for error handling

Commit cb7e6f05fce67c965194ac04467e1ba7bc70b069 ("scsi: ufs: core: Enable power management for wlun") makes the UFS device W-LU the supplier, based on which we need to make some changes to accomodate error handling.

This series is tested by fault injections (to IRQ handler, UIC cmds and task abort where error handler can possibley be invoked) in all possible contexts, e.g., scaling, gating, runtime and system suspend/resume.

Below changes are tested as a whole and based on 5.14/scsi-staging.

Changes from v3:
- Split the first change in v2 into 2 changes (to address comments from Adrian)
- Removed the host_sem used in suspend/resume and use lock/unlock_system_sleep() in error handler (suggested by Bart).

Changes from v2:
- Added 3 more changes to this series.

Changes from v1:
- Rebased on series "Optimize host lock on TR send/compl paths and utilize UTRLCNR".
- Minor update to the 6th change.

Can Guo (10):
scsi: ufs: Rename flags pm_op_in_progress and is_sys_suspended
scsi: ufs: Add flags pm_op_in_progress and is_sys_suspended
scsi: ufs: Update the return value of supplier pm ops
scsi: ufs: Enable IRQ after enabling clocks in error handling
preparation
scsi: ufs: Remove a redundant tag check in ufshcd_queuecommand()
scsi: ufs: Remove host_sem used in suspend/resume
scsi: ufs: Simplify error handling preparation
scsi: ufs: Update ufshcd_recover_pm_error()
scsi: ufs: Update the fast abort path in ufshcd_abort() for PM
requests
scsi: ufs: Apply more limitations to user access

 drivers/scsi/ufs/ufs-debugfs.c |  27 +----
 drivers/scsi/ufs/ufs-qcom.c    |   2 +-
 drivers/scsi/ufs/ufs-sysfs.c   | 105 ++++++-----------
 drivers/scsi/ufs/ufs_bsg.c     |  16 +--
 drivers/scsi/ufs/ufshcd.c      | 262 ++++++++++++++++++++++-------------------
 drivers/scsi/ufs/ufshcd.h      |  25 +++-
 6 files changed, 212 insertions(+), 225 deletions(-)
Signature · 1 line
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.