Skip to content

RDMA: Use refcount_t for reference counting

Weihang Li linux-rdma 4 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 5 repliesApplied
  2. v313 patches 5 repliesSuperseded
  3. v217 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches8 repliesSuperseded

Changes in v4 from the cover letter

* Drop the rdmavt patch because the refcount_t is not suitable for the
logic.
* Link: https://patchwork.kernel.org/project/linux-rdma/cover/[email protected]/

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/12RDMA/core: Use refcount_t instead of atomic_t on refcount of iwcm_id_privatedrivers/infiniband/core/iwcm.c drivers/infiniband/core/iwcm.h+5 -60 replies
2/12RDMA/core: Use refcount_t instead of atomic_t on refcount of iwpm_admin_datadrivers/infiniband/core/iwpm_util.c drivers/infiniband/core/iwpm_util.h+9 -50 replies
3/12RDMA/core: Use refcount_t instead of atomic_t on refcount of ib_mad_snoop_privatedrivers/infiniband/core/mad_priv.h+1 -12 replies
4/12RDMA/core: Use refcount_t instead of atomic_t on refcount of mcast_memberdrivers/infiniband/core/multicast.c+6 -60 replies
5/12RDMA/core: Use refcount_t instead of atomic_t on refcount of mcast_portdrivers/infiniband/core/multicast.c+4 -40 replies
6/12RDMA/core: Use refcount_t instead of atomic_t on refcount of mcast_groupdrivers/infiniband/core/multicast.c+11 -62 replies
7/12RDMA/core: Use refcount_t instead of atomic_t on refcount of ib_uverbs_devicedrivers/infiniband/core/uverbs.h drivers/infiniband/core/uverbs_main.c+7 -70 replies
8/12RDMA/hns: Use refcount_t instead of atomic_t for CQ reference countingdrivers/infiniband/hw/hns/hns_roce_cq.c drivers/infiniband/hw/hns/hns_roce_device.h+5 -50 replies
9/12RDMA/hns: Use refcount_t instead of atomic_t for SRQ reference countingdrivers/infiniband/hw/hns/hns_roce_device.h drivers/infiniband/hw/hns/hns_roce_srq.c+5 -50 replies
10/12RDMA/hns: Use refcount_t instead of atomic_t for QP reference countingdrivers/infiniband/hw/hns/hns_roce_device.h drivers/infiniband/hw/hns/hns_roce_qp.c+7 -70 replies
11/12RDMA/cxgb4: Use refcount_t instead of atomic_t for reference countingdrivers/infiniband/hw/cxgb4/cq.c drivers/infiniband/hw/cxgb4/ev.c drivers/infiniband/hw/cxgb4/iw_cxgb4.h+8 -80 replies
12/12RDMA/ipoib: Use refcount_t instead of atomic_t for reference countingdrivers/infiniband/ulp/ipoib/ipoib.h drivers/infiniband/ulp/ipoib/ipoib_main.c+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 for-next 00/12] RDMA: Use refcount_t for reference counting

There are some refcnt in type of atomic_t in RDMA subsystem, almost all of them is wrote before the refcount_t is acheived in kernel. refcount_t is better than integer for reference counting, it will WARN on overflow/underflow and avoid use-after-free risks.

Changes since v3:
* Drop the rdmavt patch because the refcount_t is not suitable for the
logic.
* Link: https://patchwork.kernel.org/project/linux-rdma/cover/[email protected]/

Changes since v2:
* Drop i40iw related parts because this driver will be removed soon.
* Link: https://patchwork.kernel.org/project/linux-rdma/cover/[email protected]/

Changes since v1:
* Split these patches by variable granularity.
* Fix a warning on refcount of struct mcast_group.
* Add a patch on rdmavt.
* Drop "RDMA/hns: Use refcount_t APIs for HEM".
* Link: https://patchwork.kernel.org/project/linux-rdma/cover/[email protected]/

Weihang Li (12):
RDMA/core: Use refcount_t instead of atomic_t on refcount of
iwcm_id_private
RDMA/core: Use refcount_t instead of atomic_t on refcount of
iwpm_admin_data
RDMA/core: Use refcount_t instead of atomic_t on refcount of
ib_mad_snoop_private
RDMA/core: Use refcount_t instead of atomic_t on refcount of
mcast_member
RDMA/core: Use refcount_t instead of atomic_t on refcount of
mcast_port
RDMA/core: Use refcount_t instead of atomic_t on refcount of
mcast_group
RDMA/core: Use refcount_t instead of atomic_t on refcount of
ib_uverbs_device
RDMA/hns: Use refcount_t instead of atomic_t for CQ reference counting RDMA/hns: Use refcount_t instead of atomic_t for SRQ reference
counting
RDMA/hns: Use refcount_t instead of atomic_t for QP reference counting RDMA/cxgb4: Use refcount_t instead of atomic_t for reference counting RDMA/ipoib: Use refcount_t instead of atomic_t for reference counting

 drivers/infiniband/core/iwcm.c              |  9 ++++---
 drivers/infiniband/core/iwcm.h              |  2 +-
 drivers/infiniband/core/iwpm_util.c         | 12 ++++++----
 drivers/infiniband/core/iwpm_util.h         |  2 +-
 drivers/infiniband/core/mad_priv.h          |  2 +-
 drivers/infiniband/core/multicast.c         | 37 ++++++++++++++++-------------
 drivers/infiniband/core/uverbs.h            |  2 +-
 drivers/infiniband/core/uverbs_main.c       | 12 +++++-----
 drivers/infiniband/hw/cxgb4/cq.c            |  6 ++---
 drivers/infiniband/hw/cxgb4/ev.c            |  8 +++----
 drivers/infiniband/hw/cxgb4/iw_cxgb4.h      |  2 +-
 drivers/infiniband/hw/hns/hns_roce_cq.c     |  8 +++----
 drivers/infiniband/hw/hns/hns_roce_device.h |  6 ++---
 drivers/infiniband/hw/hns/hns_roce_qp.c     | 12 +++++-----
 drivers/infiniband/hw/hns/hns_roce_srq.c    |  8 +++----
 drivers/infiniband/ulp/ipoib/ipoib.h        |  4 ++--
 drivers/infiniband/ulp/ipoib/ipoib_main.c   |  8 +++----
 17 files changed, 74 insertions(+), 66 deletions(-)
Signature · 1 line
2.7.4