drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20
Status from this message: Pushed to drm-misc-next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest6 patches 12 repliesApplied
- v75 patches 9 repliesSuperseded
- v65 patches 2 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 5 patches | 5 replies | Superseded | |
| v4 | 4 patches | 10 replies | Superseded |
Changes in v8 from the cover letter
- Now using backlight_is_blank() to get the backlight blank status (Sam Ravnborg)
- Added a new patch #4 to fix the warnings for eDP panel description (Sam Ravnborg)
[1] https://lore.kernel.org/dri-devel/[email protected]/
[2] https://lore.kernel.org/dri-devel/[email protected]/
[3] https://lore.kernel.org/dri-devel/[email protected]/
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | drm/panel: add basic DP AUX backlight supportdrivers/ include/ | +119 | 4 replies | |
| 2/6 | drm/panel-simple: Support DP AUX backlightdrivers/ | +6 | 0 replies | |
| 3/6 | drm/panel-simple: Support for delays between GPIO & regulatordrivers/ | +28 | 0 replies | |
| 4/6 | drm/panel-simple: Update validation warnings for eDP panel descriptiondrivers/ | +2 | 5 replies | |
| 5/6 | dt-bindings: display: simple: Add Samsung ATNA33XC20Documentation/ | +2 | 0 replies | |
| 6/6 | drm/panel-simple: Add Samsung ATNA33XC20drivers/ | +33 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Douglas Anderson | Rob Herring | Lyude Paul |
|---|---|---|---|
| 1/6 | R-b | R-b | |
| 2/6 | R-b | ||
| 3/6 | R-b | ||
| 4/6 | R-b | ||
| 5/6 | R-b | A-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20
This series adds the support for the eDP panel that needs the backlight controlling over the DP AUX channel using DPCD registers of the panel as per the VESA's standard.
This series also adds support for the Samsung eDP AMOLED panel that needs DP AUX to control the backlight, and introduces new delays in the @panel_desc.delay to support this panel.
This patch series depends on the following two series:
- Doug's series [1], exposed the DP AUX channel to the panel-simple.
- Lyude's series [2], introduced new drm helper functions for DPCD backlight.
This series is the logical successor to the series [3].
Changes in v1:
- Created dpcd backlight helper with very basic functionality, added backlight registration in the ti-sn65dsi86 bridge driver.
Changes in v2:
- Created a new DisplayPort aux backlight driver and moved the code from drm_dp_aux_backlight.c (v1) to the new driver.
Changes in v3:
- Fixed module compilation (kernel test bot).
Changes in v4:
- Added basic DPCD backlight support in panel-simple.
- Added support for a new Samsung panel ATNA33XC20 that needs DPCD backlight controlling and has a requirement of delays between enable GPIO and regulator.
Changes in v5:
Addressed review suggestions from Douglas:
- Created a new API drm_panel_dp_aux_backlight() in drm_panel.c
- Moved DP AUX backlight functions from panel-simple.c to drm_panel.c
- panel-simple probe() calls drm_panel_dp_aux_backlight() to create backlight when the backlight phandle is not specified in panel DT and DP AUX channel is present.
- Added check for drm_edp_backlight_supported() before registering.
- Removed the @uses_dpcd_backlight flag from panel_desc as this should be auto-detected.
- Updated comments/descriptions.
Changes in v6:
- Rebased
- Updated wanrning messages, fixed word wrapping in comments.
- Fixed ordering of memory allocation
Changes in v7:
- Updated the disable_to_power_off and power_to_enable panel delays as discovered at <https://crrev.com/c/2966167> (Douglas)
Changes in v8:
- Now using backlight_is_blank() to get the backlight blank status (Sam Ravnborg)
- Added a new patch #4 to fix the warnings for eDP panel description (Sam Ravnborg)
[1] https://lore.kernel.org/dri-devel/[email protected]/
[2] https://lore.kernel.org/dri-devel/[email protected]/
[3] https://lore.kernel.org/dri-devel/[email protected]/
Rajeev Nandan (6):
drm/panel: add basic DP AUX backlight support drm/panel-simple: Support DP AUX backlight drm/panel-simple: Support for delays between GPIO & regulator drm/panel-simple: Update validation warnings for eDP panel description
dt-bindings: display: simple: Add Samsung ATNA33XC20 drm/panel-simple: Add Samsung ATNA33XC20
.../bindings/display/panel/panel-simple.yaml | 2 + drivers/gpu/drm/drm_panel.c | 108 +++++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 73 +++++++++++++- include/drm/drm_panel.h | 15 ++- 4 files changed, 190 insertions(+), 8 deletions(-)
Signature · 1 line
2.7.4