Skip to content

Add lookaside IPsec tests

Anoob Joseph dpdk-dev 5 versions – Applied

Status from this message: Applied to dpdk-next-crypto

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 1 replyApplied
  2. v45 patches 15 repliesSuperseded
  3. v35 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches0 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Fixed lack of return check with dev_configure_and_start() (comment from Akhil)
- Adjusted patch title and description (comment from Akhil)

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/5test/crypto: add lookaside IPsec casesapp/test/meson.build app/test/test.h app/test/test_cryptodev.c +4 more+846 -00 replies
2/5test/crypto: add combined mode IPsec casesapp/test/test_cryptodev.c app/test/test_cryptodev_security_ipsec.c app/test/test_cryptodev_security_ipsec.h+223 -90 replies
3/5test/crypto: add lookaside IPsec ICV corrupt test caseapp/test/test_cryptodev.c app/test/test_cryptodev_security_ipsec.c app/test/test_cryptodev_security_ipsec.h +1 more+38 -100 replies
4/5test/crypto: add IV gen cases for IPsecapp/test/test_cryptodev.c app/test/test_cryptodev_security_ipsec.c app/test/test_cryptodev_security_ipsec.h +1 more+73 -00 replies
5/5test/crypto: add UDP encapsulated IPsec test casesapp/test/test_cryptodev.c app/test/test_cryptodev_security_ipsec.c app/test/test_cryptodev_security_ipsec.h +1 more+49 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAkhil GoyalCiara PowerHemant Agrawal
1/5A-b A-b A-b
2/5A-b A-b
3/5A-b A-b A-b
4/5A-b A-b
5/5A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 0/5] Add lookaside IPsec tests

Add lookaside IPsec functional tests. Known vector tests and combined mode framework is added.

Known vectors are outbound vectors based on
https://datatracker.ietf.org/doc/html/draft-mcgrew-gcm-test-01

The vectors are updated to have sequence number as 1 & L4 checksum computed correctly. And they have following properties,
1. ESP
2. Tunnel mode
3. IPv4
4. IPv4 tunnel

Known vector tests for inbound operation would generate test vectors by reversing outbound known vectors. The input_text would become encrypted packet and output_text would be the plain packet. Tests would then validate the operation by comparing against plain packet.

Combined mode tests are used to test all IPsec features against all ciphers supported by the PMD. The framework is introduced to avoid testing with any specific algo, thereby making it mandatory to be supported. Also, testing with all supported combinations will help with increasing coverage as well.

Four test cases use combined mode,
1. Display algo coverage and basic in + out tests
2. Negative test for ICV corruption
3. IV generation
4. UDP encapsulation

IV generation test case compares IV generated for a batch of packets and returns failure if IV is repeated.

Upcoming additions,
1. AES-CBC-SHA1-HMAC known vectors & combined mode
2. IPv6
3. Transport
4. Mixed mode (IPv4-in-IPv6 etc, all combinations)

Tested with following PMDs
1. crypto_octeontx2
2. crypto_cn10k
3. crypto_cn9k

Changes in v5:
- Fixed lack of return check with dev_configure_and_start() (comment from Akhil)
- Adjusted patch title and description (comment from Akhil)

Changes in v4:
- Fixed lack of device stop in case capability check fails (comment from Ciara)
- Rebased and updated release notes

Changes in v3
- Added UDP encapsulation tests

Changes in v2
- Dropped outbound known vector tests as lookaside protocol would require IV generated by PMD. The tests would be introduced with spec change to allow user to specify IV.
- Added IV generation tests
- Minor fixes in combined mode tests to handle multiple packets

Anoob Joseph (2):
test/crypto: add lookaside IPsec cases
test/crypto: add combined mode IPsec cases

Tejasree Kondoj (3):
test/crypto: add lookaside IPsec ICV corrupt test case test/crypto: add IV gen cases for IPsec test/crypto: add UDP encapsulated IPsec test cases

 app/test/meson.build                               |   1 +
 app/test/test.h                                    |   6 +
 app/test/test_cryptodev.c                          | 355 ++++++++++++++++++
 app/test/test_cryptodev_security_ipsec.c           | 401 +++++++++++++++++++++
 app/test/test_cryptodev_security_ipsec.h           | 119 ++++++
 .../test_cryptodev_security_ipsec_test_vectors.h   | 321 +++++++++++++++++
 doc/guides/rel_notes/release_21_11.rst             |   7 +
 7 files changed, 1210 insertions(+)
 create mode 100644 app/test/test_cryptodev_security_ipsec.c
 create mode 100644 app/test/test_cryptodev_security_ipsec.h
 create mode 100644 app/test/test_cryptodev_security_ipsec_test_vectors.h
Signature · 1 line
2.7.4