tracing/boot: Add histogram syntax support in boot-time tracing
Get series with b4
b4 am 162856122550.203126.17607127017097781682.stgit@devnote2Versions newest first · linked by author and title
- v4 Latest10 patches 2 repliesIn review
- v2 posting 2/210 patches 3 repliesSuperseded
- v2 posting 1/29 patches 4 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 3 patches | 2 replies | Superseded |
Changes in v4 from the cover letter
[2/10] - Add 'const' qualifier for @str parameter of append_str_nospace(). [5/10] - Fix to add braces for if block.
[8/10] - Fix to remove spaces in the expression for the variables.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | tracing/boot: Fix a hist trigger dependency for boot time tracingkernel/ | +9 | 0 replies | |
| 2/10 | tracing/boot: Add per-event histogram action optionskernel/ | +231 | 0 replies | |
| 3/10 | tracing/boot: Support multiple handlers for per-event histogramkernel/ | +35 | 0 replies | |
| 4/10 | tracing/boot: Support multiple histograms for each eventkernel/ | +32 | 0 replies | |
| 5/10 | tracing/boot: Show correct histogram error commandkernel/ | +10 | 0 replies | |
| 6/10 | Documentation: tracing: Add histogram syntax to boot-time tracingDocumentation/ | +80 | 0 replies | |
| 7/10 | tools/bootconfig: Support per-group/all event enabling optiontools/ | +13 | 2 replies | |
| 8/10 | tools/bootconfig: Add histogram syntax support to bconf2ftrace.shtools/ tools/ | +90 | 0 replies | |
| 9/10 | tools/bootconfig: Use per-group/all enable option in ftrace2bconf scripttools/ | +18 | 0 replies | |
| 10/10 | bootconfig/tracing/ktest: Update ktest example for boot-time tracingtools/ tools/ | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH v4 00/10] tracing/boot: Add histogram syntax support in boot-time tracing
Hi,
Here is the 4th version of boot-time tracing to add histogram syntax extension with a bugfix related hist-trigger.
The last version is here (NOTE: the subject version was wrong)
https://lore.kernel.org/lkml/162852406891.143877.12110677006587392853.stgit@devnote2/
This version fixes build warnings and some issues;
Changes from v3:
[2/10] - Add 'const' qualifier for @str parameter of append_str_nospace(). [5/10] - Fix to add braces for if block.
[8/10] - Fix to remove spaces in the expression for the variables.
Changes from v2:
[1/10] - Use IS_ENABLED() instead of #ifdef and show an error. [2/10] - Allow var expression includes spaces. [4/10] - Fixes a build error when CONFIG_HIST_TRIGGERS=n. [10/10] - Newly added.
'Histogram' options
-------------------
Currently, the boot-time tracing only supports per-event actions for setting trigger actions. This is enough for short actions like 'traceon', 'traceoff', 'snapshot' etc. However, it is not good for the 'hist' trigger action because it is usually too long to write it in a single string especially if it has an 'onmatch' action.
Here is the new syntax.
ftrace[.instance.INSTANCE].event.GROUP.EVENT.hist[.N] {
keys = <KEY>[,...]
values = <VAL>[,...]
sort = <SORT-KEY>[,...]
size = <ENTRIES>
name = <HISTNAME>
var { <VAR> = <EXPR> ... }
pause|continue|clear
onmax|onchange[.M] { var = <VAR>, <ACTION> [= <PARAM>] }
onmatch[.M] { event = <EVENT>, <ACTION> [= <PARAM>] }
filter = <FILTER>
}Where <ACTION> is one of below;
trace = <EVENT>, <ARG1>[, ...]
save = <ARG1>[, ...]
snapshotAnd "N" and "M" are digit started strings for multiple histograms and actions.
For example,
initcall.initcall_finish.actions = "hist:keys=func:lat=common_timestamp.usecs-$ts0:onmatch(initcall.initcall_start).trace(initcall_latency,func,$lat)"
This can be written as below;
initcall.initcall_finish.hist {
keys = func
var.lat = common_timestamp.usecs-$ts0
onmatch {
event = initcall.initcall_start
trace = initcall_latency, func, $lat
}
}
Also, you can add comments for each options.
Thank you,
---
Masami Hiramatsu (10):
tracing/boot: Fix a hist trigger dependency for boot time tracing tracing/boot: Add per-event histogram action options tracing/boot: Support multiple handlers for per-event histogram tracing/boot: Support multiple histograms for each event tracing/boot: Show correct histogram error command
Documentation: tracing: Add histogram syntax to boot-time tracing tools/bootconfig: Support per-group/all event enabling option tools/bootconfig: Add histogram syntax support to bconf2ftrace.sh tools/bootconfig: Use per-group/all enable option in ftrace2bconf script bootconfig/tracing/ktest: Update ktest example for boot-time tracing
Documentation/trace/boottime-trace.rst | 85 +++++- kernel/trace/trace_boot.c | 302 ++++++++++++++++++++ tools/bootconfig/scripts/bconf2ftrace.sh | 101 +++++++ tools/bootconfig/scripts/ftrace2bconf.sh | 24 +- tools/bootconfig/scripts/xbc.sh | 4 .../ktest/examples/bootconfigs/boottrace.bconf | 20 + .../ktest/examples/bootconfigs/verify-boottrace.sh | 2 7 files changed, 513 insertions(+), 25 deletions(-)
Signature · 1 line
Masami Hiramatsu (Linaro) <[email protected]>