Skip to content

bnxt_en: Implement new driver APIs to send FW messages

Michael Chan netdev oe-kbuild-all 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (refs/heads/master):

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 2 repliesApplied 11/11
  2. v111 patches 2 repliesSuperseded

Patches in v2 All 11 applied

#Subject and filesSizeRepliesApplied
1/11bnxt_en: remove DMA mapping for KONG responsedrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h+7 -510 repliesApplied
2/11bnxt_en: Refactor the HWRM_VER_GET firmware callsdrivers/net/ethernet/broadcom/bnxt/bnxt.c+11 -60 repliesApplied
3/11bnxt_en: move HWRM API implementation into separate filedrivers/net/ethernet/broadcom/bnxt/Makefile drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h +10 more+407 -3570 repliesApplied
4/11bnxt_en: introduce new firmware message API based on DMA poolsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c +1 more+442 -1212 repliesApplied
5/11bnxt_en: discard out of sequence HWRM responsesdrivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c+17 -40 repliesApplied
6/11bnxt_en: add HWRM request assignment APIdrivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h+56 -00 repliesApplied
7/11bnxt_en: add support for HWRM request slicesdrivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h+120 -20 repliesApplied
8/11bnxt_en: use link_lock instead of hwrm_cmd_lock to protect link_infodrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c+7 -20 repliesApplied
9/11bnxt_en: update all firmware calls to use the new APIsdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +6 more+1953 -15380 repliesApplied
10/11bnxt_en: remove legacy HWRM interfacedrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c +1 more+1 -1060 repliesApplied
11/11bnxt_en: support multiple HWRM commands in flightdrivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c +1 more+113 -390 repliesApplied

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchScott BrandenMichael Chan
1/11
2/11
3/11
4/11
5/11R-b
6/11
7/11
8/11R-b
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/11] bnxt_en: Implement new driver APIs to send FW messages

The current driver APIs to send messages to the firmware allow only one outstanding message in flight. There is only one buffer for the firmware response for each firmware channel. To send a firmware message, all callers must take a mutex and it is released after the firmware response has been read. This scheme does not allow multiple firmware messages in flight. Firmware may take a long time to respond to some messages (e.g. NVRAM related ones) and this causes the mutex to be held for a long time, blocking other callers.

This patchset intoduces the new driver APIs to address the above shortcomings. The new APIs are compatible with new and old firmware. But the new deferred firmware response mechanism will require newer firmware in order to allow multiple outstanding firmware commands.

All callers are updated to use the new APIs.

v2: Patch 4 and patch 9 updated to fix issues reported by test robot

Edwin Peer (11):
bnxt_en: remove DMA mapping for KONG response
bnxt_en: Refactor the HWRM_VER_GET firmware calls
bnxt_en: move HWRM API implementation into separate file
bnxt_en: introduce new firmware message API based on DMA pools
bnxt_en: discard out of sequence HWRM responses
bnxt_en: add HWRM request assignment API
bnxt_en: add support for HWRM request slices
bnxt_en: use link_lock instead of hwrm_cmd_lock to protect link_info
bnxt_en: update all firmware calls to use the new APIs
bnxt_en: remove legacy HWRM interface
bnxt_en: support multiple HWRM commands in flight

 drivers/net/ethernet/broadcom/bnxt/Makefile   |    2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 2133 ++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  105 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c |  185 +-
 .../net/ethernet/broadcom/bnxt/bnxt_devlink.c |   81 +-
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  548 +++--
 .../net/ethernet/broadcom/bnxt/bnxt_hwrm.c    |  763 ++++++
 .../net/ethernet/broadcom/bnxt/bnxt_hwrm.h    |  145 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c |  130 +-
 .../net/ethernet/broadcom/bnxt/bnxt_sriov.c   |  455 ++--
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c  |  264 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |   31 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |   62 +-
 13 files changed, 2906 insertions(+), 1998 deletions(-)
 create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c
 create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h
Signature · 1 line
2.18.1