Skip to content

Cleanups for NFS fscache and convert from dfprintk to trace events

David Wysochanski linux-nfs 3 versions – New

Get series with b4
b4 am CALF+zOn4x6VQ434WgsUv1J=fKmY=WPJigBe=XS2Oni1D+ahf3w@mail.gmail.com

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 4 patches 0 repliesNew
  2. v2 posting 1/24 patches 2 repliesSuperseded
  3. v17 patches 1 replySuperseded

Changes in v2 from the cover letter

- Rebase on top of dhowells fscache-rewrite (v3) and Anna's linux-next to avoid future conflicts
- Fold in "NFS: Use nfs_i_fscache() consistently within NFS fscache code" to other patches
- Drop "NFS: Convert NFS fscache enable/disable dfprintks to tracepoints" since we can use fscache trace events
- Combine the last two patches into one:
NFS: Remove remaining dfprintks related to fscache cookies
NFS: Remove remaining usages of NFSDBG_FSCACHE
- Dropped Signed-off-by and Reviewed-by tags due to rebase

[1] https://marc.info/?l=linux-nfs&m=163718744111509&w=2
[2] https://marc.info/?l=linux-nfs&m=163974120915758&w=2
[3] https://marc.info/?l=linux-nfs&m=163967071213398&w=2

Patches in v2 posting 2/2 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter Fwd: [PATCH v2 0/4] Cleanups for NFS fscache and convert from dfprintk to trace events

FYI, these apply cleanly on top of linus tree now after the merge of dhowells fscache-rewrite
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8834147f9505661859ce44549bf601e2a06bba7c

I have rebased (no changes needed from the Dec post), did some final tests (unit and xfstests) and re-pushed to
https://github.com/DaveWysochanskiRH/kernel/tree/nfs-fscache-5.17-rc1

I am not sure if it is too late for the merge window or not, or how you handle such dependencies,
but wanted to let you know my status. If you want me to re-post or anything let me know.

Thanks.

---------- Forwarded message ---------
From: Dave Wysochanski <[email protected]>
Date: Fri, Dec 17, 2021 at 12:54 PM
Subject: [PATCH v2 0/4] Cleanups for NFS fscache and convert from dfprintk to trace events
To: Anna Schumaker <[email protected]>, David Howells <[email protected]>
Cc: <[email protected]>, <[email protected]>

This is a second version of a series posted previously [1] These ran into conflicts [2] with dhowell's fscache-rewrite patches [3], and they probably should go in his fscache-rewrite. Note that a couple patches have been either dropped or folded into other patches, so there's only 4 patches left from the original 7.

The patches are also at:
https://github.com/DaveWysochanskiRH/kernel/tree/fscache-rewrite-plus-nfs

Changes since v1
- Rebase on top of dhowells fscache-rewrite (v3) and Anna's linux-next to avoid future conflicts
- Fold in "NFS: Use nfs_i_fscache() consistently within NFS fscache code" to other patches
- Drop "NFS: Convert NFS fscache enable/disable dfprintks to tracepoints" since we can use fscache trace events
- Combine the last two patches into one:
NFS: Remove remaining dfprintks related to fscache cookies
NFS: Remove remaining usages of NFSDBG_FSCACHE
- Dropped Signed-off-by and Reviewed-by tags due to rebase

[1] https://marc.info/?l=linux-nfs&m=163718744111509&w=2
[2] https://marc.info/?l=linux-nfs&m=163974120915758&w=2
[3] https://marc.info/?l=linux-nfs&m=163967071213398&w=2

Dave Wysochanski (4):
NFS: Cleanup usage of nfs_inode in fscache interface and handle i_size
properly
NFS: Rename fscache read and write pages functions
NFS: Replace dfprintks with tracepoints in fscache read and write page
functions
NFS: Remove remaining dfprintks related to fscache and remove
NFSDBG_FSCACHE

 fs/nfs/fscache.c            | 53 +++++++++-----------------
 fs/nfs/fscache.h            | 45 ++++++++++------------
 fs/nfs/nfstrace.h           | 91 +++++++++++++++++++++++++++++++++++++++++++++
 fs/nfs/read.c               |  4 +-
 include/uapi/linux/nfs_fs.h |  2 +-
 5 files changed, 130 insertions(+), 65 deletions(-)

--
1.8.3.1