Skip to content

Kcontrol get/put cleanup in Tegra drivers

Sameer Pujar alsa-devel linux-tegra lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest16 patches 4 repliesIn review

Changes in v3 from the cover letter

-------
* Add fixes related to wrong value type as suggested by Takashi. Relevant drivers are updated as part of it.

* Use separate get/put callbacks for each mixer control. The common part is pushed to separate function wherever applicable, thus removing usage of strstr() calls. The return values are fixed as suggested.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16ASoC: tegra: Fix wrong value type in ADMAIFsound/soc/tegra/tegra210_admaif.c+2 -20 replies
2/16ASoC: tegra: Fix wrong value type in I2Ssound/soc/tegra/tegra210_i2s.c+24 -180 replies
3/16ASoC: tegra: Fix wrong value type in DMICsound/soc/tegra/tegra210_dmic.c+11 -120 replies
4/16ASoC: tegra: Fix wrong value type in DSPKsound/soc/tegra/tegra186_dspk.c+11 -120 replies
5/16ASoC: tegra: Fix wrong value type in SFCsound/soc/tegra/tegra210_sfc.c+12 -90 replies
6/16ASoC: tegra: Fix wrong value type in MVCsound/soc/tegra/tegra210_mvc.c+4 -40 replies
7/16ASoC: tegra: Fix kcontrol put callback in ADMAIFsound/soc/tegra/tegra210_admaif.c+109 -290 replies
8/16ASoC: tegra: Fix kcontrol put callback in I2Ssound/soc/tegra/tegra210_i2s.c+226 -760 replies
9/16ASoC: tegra: Fix kcontrol put callback in DMICsound/soc/tegra/tegra210_dmic.c+149 -340 replies
10/16ASoC: tegra: Fix kcontrol put callback in DSPKsound/soc/tegra/tegra186_dspk.c+146 -320 replies
11/16ASoC: tegra: Fix kcontrol put callback in AHUBsound/soc/tegra/tegra210_ahub.c+7 -40 replies
12/16ASoC: tegra: Fix kcontrol put callback in MVCsound/soc/tegra/tegra210_mvc.c+18 -42 replies
13/16ASoC: tegra: Fix kcontrol put callback in SFCsound/soc/tegra/tegra210_sfc.c+93 -310 replies
14/16ASoC: tegra: Fix kcontrol put callback in AMXsound/soc/tegra/tegra210_amx.c+3 -00 replies
15/16ASoC: tegra: Fix kcontrol put callback in ADXsound/soc/tegra/tegra210_adx.c+3 -00 replies
16/16ASoC: tegra: Fix kcontrol put callback in Mixersound/soc/tegra/tegra210_mixer.c+19 -70 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTakashi Iwai
SeriesR-b
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/16] Kcontrol get/put cleanup in Tegra drivers

There are two cleanups in the series:
1. Use correct value type for enum controls. This is suggested by Takashi during review of v2.

2. This series fixes kcontrol put callback in some of the Tegra drivers which are used on platforms based on Tegra210 and later. The callback is expected to return 1 whenever the HW update is done.

This idea is suggested by Jaroslav. Similar suggestion came from Mark during review of series [0] and drivers under this were updated to return 1, but missed to take care of duplicate updates. This series updates all concerned drivers to return proper values and duplicate updates are filtered out.

I have added 'Suggested-by" tags accordingly.

[0] https://lore.kernel.org/linux-arm-kernel/[email protected]/

Changelog
=========
v2->v3:
-------
* Add fixes related to wrong value type as suggested by Takashi. Relevant drivers are updated as part of it.

* Use separate get/put callbacks for each mixer control. The common part is pushed to separate function wherever applicable, thus removing usage of strstr() calls. The return values are fixed as suggested.

v1->v2:
-------
* ADMAIF, I2S, DMIC and DSPK drivers updated to take care of duplicate updates.
* Similarly new patches are added for AHUB, MVC, SFC, AMX, ADX and Mixer drivers.

Sameer Pujar (16):
ASoC: tegra: Fix wrong value type in ADMAIF
ASoC: tegra: Fix wrong value type in I2S
ASoC: tegra: Fix wrong value type in DMIC
ASoC: tegra: Fix wrong value type in DSPK
ASoC: tegra: Fix wrong value type in SFC
ASoC: tegra: Fix wrong value type in MVC
ASoC: tegra: Fix kcontrol put callback in ADMAIF
ASoC: tegra: Fix kcontrol put callback in I2S
ASoC: tegra: Fix kcontrol put callback in DMIC
ASoC: tegra: Fix kcontrol put callback in DSPK
ASoC: tegra: Fix kcontrol put callback in AHUB
ASoC: tegra: Fix kcontrol put callback in MVC
ASoC: tegra: Fix kcontrol put callback in SFC
ASoC: tegra: Fix kcontrol put callback in AMX
ASoC: tegra: Fix kcontrol put callback in ADX
ASoC: tegra: Fix kcontrol put callback in Mixer

 sound/soc/tegra/tegra186_dspk.c   | 181 ++++++++++++++++++-----
 sound/soc/tegra/tegra210_admaif.c | 140 ++++++++++++++----
 sound/soc/tegra/tegra210_adx.c    |   3 +
 sound/soc/tegra/tegra210_ahub.c   |  11 +-
 sound/soc/tegra/tegra210_amx.c    |   3 +
 sound/soc/tegra/tegra210_dmic.c   | 184 +++++++++++++++++++-----
 sound/soc/tegra/tegra210_i2s.c    | 296 +++++++++++++++++++++++++++++---------
 sound/soc/tegra/tegra210_mixer.c  |  26 +++-
 sound/soc/tegra/tegra210_mvc.c    |  30 ++--
 sound/soc/tegra/tegra210_sfc.c    | 123 ++++++++++++----
 10 files changed, 780 insertions(+), 217 deletions(-)
Signature · 1 line
2.7.4