DFU: Update dfu_alt_info parser etc.
Get series with b4
b4 am 163876946986.38238.10896882043017582609.stgit@localhostVersions newest first
- v1 Latest5 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | DFU: Do not copy the entity name over the buffer sizedrivers/ | +1 | 1 reply | |
| 2/5 | DFU: Accept redundant spaces and tabs in dfu_alt_infodrivers/ drivers/ drivers/ +3 more | +37 | 0 replies | |
| 3/5 | DFU: Check the number of arguments and argument string strictlydrivers/ drivers/ drivers/ +5 more | +154 | 0 replies | |
| 4/5 | doc: usage: DFU: Fix dfu_alt_info documentdoc/ | +40 | 0 replies | |
| 5/5 | cmd/dfu: Enable 'dfu list' command without DFU_OVER_USBcmd/ | +3 | 2 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by.
| Patch | Ilias Apalodimas |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] DFU: Update dfu_alt_info parser etc.
Hi,
This series is improving DFU subsystem. This improves dfu_alt_info parser and fixing documents etc.
When I was debuging my patch for updating dfu_alt_info on the DeveloperBox platform, I found that dfu_alt_info parser doesn't accept redundant spaces and tabs. Also the dfu.rst description seems wrong. Moreover, there is no way to check whether the parser parses the dfu_alt_info correctly.
These patches fixes such issues. [1/5] is just for avoiding buffer overrun, [2/5] and [3/5] improves dfu_alt_info parser to accept redundant spaces and tabs, and check the number of arguments strictly so that the parser (and user) can notice any unexpected parameters. [4/5] fixes the documents (there seems some wrong description maybe coming from copy&paste). [5/5] allows user to run 'dfu list' even if the platform doesn't support DFU_OVER_USB.
Thank you,
---
Masami Hiramatsu (5):
DFU: Do not copy the entity name over the buffer size
DFU: Accept redundant spaces and tabs in dfu_alt_info
DFU: Check the number of arguments and argument string strictly
doc: usage: DFU: Fix dfu_alt_info document
cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB
cmd/dfu.c | 6 +++-- doc/usage/dfu.rst | 57 ++++++++++++++++++++++++++++++++++-------------- drivers/dfu/dfu.c | 37 ++++++++++++++++++++++++------- drivers/dfu/dfu_mmc.c | 55 +++++++++++++++++++++++++++------------------- drivers/dfu/dfu_mtd.c | 34 +++++++++++++++++++---------- drivers/dfu/dfu_nand.c | 34 ++++++++++++++++++----------- drivers/dfu/dfu_ram.c | 24 ++++++++++---------- drivers/dfu/dfu_sf.c | 34 ++++++++++++++++++----------- drivers/dfu/dfu_virt.c | 5 +++- include/dfu.h | 33 ++++++++++++++++++---------- 10 files changed, 205 insertions(+), 114 deletions(-)
--
Masami Hiramatsu <[email protected]>