Skip to content

rockchip: fix serial output on rk3036

Heiko Stuebner linux-clk linux-rockchip 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 1 replySuperseded
  3. v10 of 4 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- use a direct register write, instead of using clock apis

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clk: rockchip: add "," to mux_pll_src_apll_dpll_gpll_usb480m_p on rk3036drivers/clk/rockchip/clk-rk3036.c+1 -10 replies
2/2clk: rockchip: Make uartpll a child of the gpll on rk3036drivers/clk/rockchip/clk-rk3036.c+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] rockchip: fix serial output on rk3036

Recent changes to the 8250-dw variant revealed issues concerning how the clock rates are handled on the rk3036 uart.

For one, there was an error in the clock declaration, but also the shared uart-pll-select-mux also as default got supplied from the apll that also supplies the cpu and thus gets frequency scaled.

The patches in this series remedy this and make the debug uart function again on 4.10 + current merge window.

As for the merge-path, I've now tested all Rockchip socs I have access to (3036, 3288, 3368, 3399) and didn't find any more clock-related issues with the merge-window as of today. So if no other subtle issue turns up this week, these should be all fixes for the 4.11 cycle.
So these 2 patches could be picked up by clock-maintainers directly if so desired, or I can send a pull request after the merge-window closes and we're save to say that nothing else broke.

changes in v3:
- use a direct register write, instead of using clock apis

changes in v2:
- Fixes tag for the missing ","
- do reparenting in the driver itself
- drop clock-id addition, as they're not needed for the fix anymore

Heiko Stuebner (2):
clk: rockchip: add "," to mux_pll_src_apll_dpll_gpll_usb480m_p on

    rk3036

clk: rockchip: Make uartpll a child of the gpll on rk3036

 drivers/clk/rockchip/clk-rk3036.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Signature · 1 line
2.11.0

Read the cover letter in its thread