Skip to content

add virtio_blk device support to vdpa/ifc

Andy Pei dpdk-dev 10 versions – Applied

Status from this message: Applied to dpdk-next-virtio/main.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest13 patches 5 repliesApplied
  2. v913 patches 16 repliesSuperseded
  3. v813 patches 23 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v718 patches30 repliesSuperseded
v616 patches14 repliesSuperseded
v516 patches2 repliesSuperseded
v416 patches1 replySuperseded
v315 patches10 repliesSuperseded
v215 patches2 repliesSuperseded
v115 patches0 repliesSuperseded

Changes in v10 from the cover letter

fix typo.
add more NULL pointer check.
fix a error handler.

Patches in v10 Applied

#Subject and filesSizeRepliesApplied
1/13vdpa/ifc: add support for virtio blk devicedrivers/vdpa/ifc/base/ifcvf.h drivers/vdpa/ifc/ifcvf_vdpa.c+102 -150 replies
2/13vhost: add vDPA ops for blk devicelib/vhost/vdpa_driver.h+6 -20 replies
3/13vhost: add vhost msg support for get/set configlib/vhost/vhost_user.c lib/vhost/vhost_user.h+98 -01 reply
4/13vdpa/ifc: add blk ops for ifc devicedrivers/vdpa/ifc/base/ifcvf.h drivers/vdpa/ifc/ifcvf_vdpa.c+99 -12 replies
5/13vdpa/ifc: add vDPA interrupt relay for blk devicedrivers/vdpa/ifc/ifcvf_vdpa.c+8 -10 replies
6/13vdpa/ifc: add block device SW live-migrationdrivers/vdpa/ifc/base/ifcvf.h drivers/vdpa/ifc/ifcvf_vdpa.c+39 -40 replies
7/13vhost: add API to get vDPA device typedoc/guides/prog_guide/vhost_lib.rst doc/guides/rel_notes/release_22_07.rst lib/vhost/rte_vhost.h +3 more+74 -00 replies
8/13vdpa/ifc: add get device type ops to ifc driverdrivers/vdpa/ifc/ifcvf_vdpa.c+25 -00 replies
9/13examples/vdpa: add virtio blk supportexamples/vdpa/main.c examples/vdpa/vdpa_blk_compact.h+106 -00 replies
10/13usertools: add support for virtio blk deviceusertools/dpdk-devbind.py+4 -10 replies
11/13vdpa/ifc: add log for config space of virtio blkdrivers/vdpa/ifc/ifcvf_vdpa.c+34 -00 replies
12/13vdpa/ifc: add interrupt handling for config spacedrivers/vdpa/ifc/ifcvf_vdpa.c+120 -10 replies
13/13vdpa/ifc/base: access correct register for blk devicedrivers/vdpa/ifc/base/ifcvf.c+27 -70 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchChenbo XiaMaxime Coquelin
1/13R-b
2/13R-b R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13R-b
9/13R-b
10/13A-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc

This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops.
Add example to vdpa to support virtio_blk device.
To support blk device live migration, some modification to vhost lib. Perform dev_conf op only under VHOST_USER_SET_VRING_CALL msg.

v10:
fix typo.
add more NULL pointer check.
fix a error handler.

v9:
fix some naming issue.
add more NULL pointer check.
close open file when errors occur.

v8:
delete some redundant code.
fix some commit log.

v7:
Check on expected fd num in new vhost msg handler. Sanity check on vhost msg size.
Fix typo.
Add commit log to help understand code. Remove duplicated code.
Add new API to get vDPA device type.

v6:
fix some commit log.
add vhost socket in log output to make it more user-friendly. when driver ops fail, just output some log, do not break message handler. check vhost msg size in msg handler.
v5:
fix some coding style issues.
v4:
add args "isblk" to vdpa example to specify a block device, fix some issue in example.
Make sure code specify for block device does not affect net device.
v3:
Fix some compile issues.
v2:
Fix some coding style issues.

Andy Pei (13):
vdpa/ifc: add support for virtio blk device
vhost: add vDPA ops for blk device
vhost: add vhost msg support for get/set config vdpa/ifc: add blk ops for ifc device vdpa/ifc: add vDPA interrupt relay for blk device vdpa/ifc: add block device SW live-migration
vhost: add API to get vDPA device type vdpa/ifc: add get device type ops to ifc driver examples/vdpa: add virtio blk support
usertools: add support for virtio blk device vdpa/ifc: add log for config space of virtio blk vdpa/ifc: add interrupt handling for config space vdpa/ifc/base: access correct register for blk device

 doc/guides/prog_guide/vhost_lib.rst    |   5 +
 doc/guides/rel_notes/release_22_07.rst |   4 +
 drivers/vdpa/ifc/base/ifcvf.c          |  34 ++-
 drivers/vdpa/ifc/base/ifcvf.h          |  27 ++-
 drivers/vdpa/ifc/ifcvf_vdpa.c          | 420 +++++++++++++++++++++++++++++++--
 examples/vdpa/main.c                   |  56 +++++
 examples/vdpa/vdpa_blk_compact.h       |  50 ++++
 lib/vhost/rte_vhost.h                  |  17 ++
 lib/vhost/socket.c                     |  44 ++++
 lib/vhost/vdpa_driver.h                |  11 +-
 lib/vhost/version.map                  |   1 +
 lib/vhost/vhost_user.c                 |  85 +++++++
 lib/vhost/vhost_user.h                 |  13 +
 usertools/dpdk-devbind.py              |   5 +-
 14 files changed, 741 insertions(+), 31 deletions(-)
 create mode 100644 examples/vdpa/vdpa_blk_compact.h
Signature · 1 line
1.8.3.1