RFC: exynos multiplatform support
Get series with b4
b4 am 1652797.OtavYkpUqK@flatronVersions newest first
- v1 Latest0 of 23 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 23 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/23] RFC: exynos multiplatform support
Quoted 70 lines · On Wednesday 06 of March 2013 13:34:26 Thierry Reding wrote:
Quoted 64 lines · Arnd Bergmann
Quoted 8 lines · Tomasz Figa
Quoted 5 lines · On Tuesday 05 of March 2013 19:19:02 Arnd Bergmann wrote:
If none of these are needed for DT-based systems, we should probably
build that code conditionally based on theCONFIG_EXYNOS_ATAGSsymbol
I introduced.Yes, none of them are needed for DT-based systems.
Ah, good. I'll try to make more code conditional then.
Quoted 40 lines
Quoted 2 lines
How are you planning to solve this? Do you want to have a combined driver that registers both a clocksource and a pwm?
Let's start with a quick introduction to the s3c-pwm hardware. Each channel has its own timer value, compare and reload value registers, so
they don't need any extra locking. However there are additional shared
configuration registers, containing things such as start and reload bits for all channels, prescaler and main divisor values, etc. Those registers needs synchronization.Now there are several possible approaches:
1) A brute force one - two separate drivers, based on the fact that the
clocksource driver will be used only on uniprocessor systems, so a simple
_irqsavewhen accessing a shared register in both will guarantee correct synchronization.2) Two separate drivers with some synchronized shared code accessing
registers (
_start,_stop,_set_reload,_set_prescaler,_set_divisor,
etc.; all using a shared spinlock).3) Single driver registering PWM channels, clocksource and clock event
device. This does not seem like a bad idea, since the whole code for
configuration of the PWM block would reside in one location and there
would be no redundancy. However there is a question where such driver
should be placed -drivers/clocksource,drivers/pwm, or maybe somewhere
else?Quoted 5 lines
Personally I wanted to go with first option, which would require least
amount of changes to existing code, at a cost of some code duplication
(but some PWM code is duplicated already).I would prefer option 3. That is also easier to implement with a straightforward DT binding that defines a single node with the clock registers. The location doesn't have an obvious answer, but I would probably put them into
drivers/clocksourceif the PWM maintainer agrees.Quoted 5 lines
Option 2 would probably come down to having a trivial MFD driver exposing a regmap. You can probably reuse
drivers/mfd/syscon.cfor this and make the node compatible with "syscon" to designate the clock registers as a system-wide resource, making the other device nodes register-less.
Quoted 5 lines
I think option 2 is the standard method if one hardware block provides several logical devices. I find it to be a pretty nice solution to this problem. We also have precedent in the PWM subsystem. The TWL chips for instance use it to create a platform device which is later driven by a PWM driver.
I prefer this option over 3), because current driver files could be easily reused (just cleaned up and moved into appropriate directories), which would minimize the amount of needed changes.
Another reason for having two separate drivers is that on Exynos SoCs the PWM block is not used for timers at all, just for PWM outputs, so the whole part responsible for clocksource would be useless.
Best regards,
Tomasz