Skip to content

DMA mapping changes for SCSI core

John Garry linux-doc linux-ide linux-iommu linux-scsi lkml 6 versions – Applied

Status from this message: applied to the dma-mapping tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 8 repliesApplied
  2. v55 patches 14 repliesSuperseded
  3. v45 patches 12 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches16 repliesSuperseded
v24 patches1 replySuperseded
v14 patches14 repliesSuperseded

Changes in v6 from the cover letter

- Rebase to Linux 5.19-rc6
- Add Martin's tags to unmodified patches (thanks!)
- Apply DMA opt limit to max_sectors in sd driver, and not max_hw_sectors

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/6dma-mapping: Add dma_opt_mapping_size()Documentation/core-api/dma-api.rst include/linux/dma-map-ops.h include/linux/dma-mapping.h +1 more+32 -00 replies
2/6dma-iommu: Add iommu_dma_opt_mapping_size()drivers/iommu/dma-iommu.c drivers/iommu/iova.c include/linux/iova.h+13 -00 replies
3/6scsi: core: Cap shost max_sectors according to DMA limits only oncedrivers/scsi/hosts.c drivers/scsi/scsi_lib.c+5 -40 replies
4/6scsi: sd: Allow max_sectors be capped at DMA optimal size limitdrivers/scsi/sd.c include/scsi/scsi_host.h+3 -06 replies
5/6scsi: scsi_transport_sas: Cap shost opt_sectors according to DMA optimal limitdrivers/scsi/scsi_transport_sas.c+6 -01 reply
6/6ata: libata-scsi: Cap ata_device->max_sectors according to shost->max_sectorsdrivers/ata/libata-scsi.c+1 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalMartin K. PetersenRobin Murphy
1/6R-b A-b
2/6R-b A-b A-b
3/6R-b A-b
4/6R-b A-b
5/6R-b
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/6] DMA mapping changes for SCSI core

As reported in [0], DMA mappings whose size exceeds the IOMMU IOVA caching limit may see a big performance hit.

This series introduces a new DMA mapping API, dma_opt_mapping_size(), so that drivers may know this limit when performance is a factor in the mapping.

The SCSI SAS transport code is modified only to use this limit. For now I did not want to touch other hosts as I have a concern that this change could cause a performance regression.

I also added a patch for libata-scsi as it does not currently honour the shost max_sectors limit.

[0] https://lore.kernel.org/linux-iommu/[email protected]/

Changes since v5:
- Rebase to Linux 5.19-rc6
- Add Martin's tags to unmodified patches (thanks!)
- Apply DMA opt limit to max_sectors in sd driver, and not max_hw_sectors

Changes since v4:
- tweak libata and other patch titles
- Add Robin's tag (thanks!)
- Clarify description of new DMA mapping API

Changes since v3:
- Apply max DMA optimial limit to SAS hosts only
Note: Even though "scsi: core: Cap shost max_sectors only once when adding" is a subset of a previous patch I did not transfer the RB tags
- Rebase on v5.19-rc4

John Garry (6):
dma-mapping: Add dma_opt_mapping_size()
dma-iommu: Add iommu_dma_opt_mapping_size()
scsi: core: Cap shost max_sectors according to DMA limits only once
scsi: sd: Allow max_sectors be capped at DMA optimal size limit
scsi: scsi_transport_sas: Cap shost opt_sectors according to DMA
optimal limit
ata: libata-scsi: Cap ata_device->max_sectors according to

    shost->max_sectors
 Documentation/core-api/dma-api.rst | 14 ++++++++++++++
 drivers/ata/libata-scsi.c          |  1 +
 drivers/iommu/dma-iommu.c          |  6 ++++++
 drivers/iommu/iova.c               |  5 +++++
 drivers/scsi/hosts.c               |  5 +++++
 drivers/scsi/scsi_lib.c            |  4 ----
 drivers/scsi/scsi_transport_sas.c  |  6 ++++++
 drivers/scsi/sd.c                  |  2 ++
 include/linux/dma-map-ops.h        |  1 +
 include/linux/dma-mapping.h        |  5 +++++
 include/linux/iova.h               |  2 ++
 include/scsi/scsi_host.h           |  1 +
 kernel/dma/mapping.c               | 12 ++++++++++++
 13 files changed, 60 insertions(+), 4 deletions(-)
Signature · 1 line
2.35.3