Skip to content

Take devlink lock on mlx4 and mlx5 callbacks

Moshe Shemesh netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 0 repliesApplied 9/9
  2. v19 patches 6 repliesSuperseded

Patches in v2 All 9 applied

#Subject and filesSizeRepliesApplied
1/9net: devlink: remove region snapshot ID tracking dependency on devlink->locknet/core/devlink.c+33 -310 repliesApplied
2/9net: devlink: remove region snapshots list dependency on devlink->locknet/core/devlink.c+29 -120 repliesApplied
3/9net/mlx5: Move fw reset unload to mlx5_fw_reset_complete_reloaddrivers/net/ethernet/mellanox/mlx5/core/devlink.c drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c+13 -80 repliesApplied
4/9net/mlx5: Lock mlx5 devlink reload callbacksdrivers/net/ethernet/mellanox/mlx5/core/dev.c drivers/net/ethernet/mellanox/mlx5/core/devlink.c drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +3 more+79 -500 repliesApplied
5/9net/mlx4: Use devl_ API for devlink region create / destroydrivers/net/ethernet/mellanox/mlx4/crdump.c drivers/net/ethernet/mellanox/mlx4/main.c+17 -100 repliesApplied
6/9net/mlx4: Use devl_ API for devlink port register / unregisterdrivers/net/ethernet/mellanox/mlx4/main.c+12 -40 repliesApplied
7/9net/mlx4: Lock mlx4 devlink reload callbackdrivers/net/ethernet/mellanox/mlx4/catas.c drivers/net/ethernet/mellanox/mlx4/main.c+37 -130 repliesApplied
8/9net/mlx5: Lock mlx5 devlink health recovery callbackdrivers/net/ethernet/mellanox/mlx5/core/health.c drivers/net/ethernet/mellanox/mlx5/core/main.c+13 -30 repliesApplied
9/9devlink: Hold the instance lock in health callbacksdrivers/net/ethernet/mellanox/mlx5/core/health.c net/core/devlink.c+15 -230 repliesApplied

Reviews trailers per patch

6 of 9 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoTariq Toukan
1/9
2/9
3/9R-b
4/9R-b
5/9R-b R-b
6/9R-b R-b
7/9R-b R-b
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/9] Take devlink lock on mlx4 and mlx5 callbacks

Prepare mlx4 and mlx5 drivers to have all devlink callbacks called with devlink instance locked. Change mlx4 driver to use devl_ API where needed to have devlink reload callbacks locked. Change mlx5 driver to use devl_ API where needed to have devlink reload and devlink health callbacks locked.

As mlx5 is the only driver which needed changes to enable calling health callbacks with devlink instance locked, this patchset also removes DEVLINK_NL_FLAG_NO_LOCK flag from devlink health callbacks.

This patchset will be followed by a patchset that will remove DEVLINK_NL_FLAG_NO_LOCK flag from devlink and will remove devlink_mutex.

Jiri Pirko (2):
net: devlink: remove region snapshot ID tracking dependency on

    devlink->lock

net: devlink: remove region snapshots list dependency on devlink->lock

Moshe Shemesh (7):
net/mlx5: Move fw reset unload to mlx5_fw_reset_complete_reload net/mlx5: Lock mlx5 devlink reload callbacks net/mlx4: Use devl_ API for devlink region create / destroy net/mlx4: Use devl_ API for devlink port register / unregister net/mlx4: Lock mlx4 devlink reload callback
net/mlx5: Lock mlx5 devlink health recovery callback
devlink: Hold the instance lock in health callbacks

 drivers/net/ethernet/mellanox/mlx4/catas.c    |   5 +
 drivers/net/ethernet/mellanox/mlx4/crdump.c   |  20 +--
 drivers/net/ethernet/mellanox/mlx4/main.c     |  44 +++++-
 drivers/net/ethernet/mellanox/mlx5/core/dev.c |  19 +--
 .../net/ethernet/mellanox/mlx5/core/devlink.c |  59 +++++---
 .../net/ethernet/mellanox/mlx5/core/eswitch.c |  18 +--
 .../ethernet/mellanox/mlx5/core/fw_reset.c    |  10 +-
 .../net/ethernet/mellanox/mlx5/core/health.c  |   4 +
 .../net/ethernet/mellanox/mlx5/core/main.c    |  38 ++++-
 .../ethernet/mellanox/mlx5/core/mlx5_core.h   |   2 +
 .../net/ethernet/mellanox/mlx5/core/sriov.c   |   6 +
 net/core/devlink.c                            | 135 ++++++++++--------
 12 files changed, 227 insertions(+), 133 deletions(-)
Signature · 1 line
2.18.2