Skip to content

add imx93 adc support

[email protected] linux-arm-kernel linux-devicetree linux-iio 6 versions – Applied

Status from this message: Applied,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 3 repliesApplied
  2. v53 patches 5 repliesSuperseded
  3. v43 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches2 repliesSuperseded
v23 patches5 repliesSuperseded
v13 patches7 repliesSuperseded

Changes in v6 from the cover letter

-Change the Copyright to 2023
-Power down the ADC if imx93_adc_calibration() if meet issue. -Add new error label in probe (error_adc_power_down)
-Add back the pm_runtime_get_sync(dev) in imx93_adc_remove().
Though in imx93_adc_remove(), already in pm runtime resume due to the useage of autosuspend logic. But call this pm_runtime_get_sync(dev) will make the code logic more clear and will make the runtime pm counter balance after pm_runtime_put_noidle(dev).

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3iio: adc: add imx93 adc supportMAINTAINERS drivers/iio/adc/Kconfig drivers/iio/adc/Makefile +1 more+498 -11 reply
2/3dt-bindings: iio: adc: Add NXP IMX93 ADCDocumentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml+81 -01 reply
3/3arm64: dts: imx93: add ADC supportarch/arm64/boot/dts/freescale/imx93-11x11-evk.dts arch/arm64/boot/dts/freescale/imx93.dtsi+25 -01 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] add imx93 adc support

From: Haibo Chen <[email protected]>

V6:
-Change the Copyright to 2023
-Power down the ADC if imx93_adc_calibration() if meet issue. -Add new error label in probe (error_adc_power_down)
-Add back the pm_runtime_get_sync(dev) in imx93_adc_remove().
Though in imx93_adc_remove(), already in pm runtime resume due to the useage of autosuspend logic. But call this pm_runtime_get_sync(dev) will make the code logic more clear and will make the runtime pm counter balance after pm_runtime_put_noidle(dev).

V5:
-For ADC driver, use dev_err_probe() to replace dev_err() in dev_err_probe(). -Add imx93_adc_power_down() in the probe error path.
-Re-order the function in imx93_adc_remove(), make them inverse in probe(). -Remove the pm_runtime_get_sync(dev) in imx93_adc_remove(), because this driver
enable the pm_runtime autosuspend feature, and config the delay as 50ms. So when called imx93_adc_remove(), this device still in runtime resume state, no need to force resume the device back.
-no changes for binding doc and dts.

V4:
For ADC driver, re-define the ADC status show the relation to specific register bit. Redo the imx93_adc_remove(), change the return error sequence in imx93_adc_read_raw(), and use a direct string for indio_dev->name.
For dt-bings, change the commit title and add maintainer's reviewed by tag For dts, no change.

V3:
For dt-bings, add some change according to review comments, and pass dt_binding_check. For dts, add #io-channel-cells = <1>; to pass dtbs_check
For ADC driver, no change.

V2:
For ADC driver, add change according to matainer's commets.

Haibo Chen (3):
iio: adc: add imx93 adc support
dt-bindings: iio: adc: Add NXP IMX93 ADC
arm64: dts: imx93: add ADC support

 .../bindings/iio/adc/nxp,imx93-adc.yaml       |  81 +++
 MAINTAINERS                                   |   4 +-
 .../boot/dts/freescale/imx93-11x11-evk.dts    |  12 +
 arch/arm64/boot/dts/freescale/imx93.dtsi      |  13 +
 drivers/iio/adc/Kconfig                       |  10 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/imx93_adc.c                   | 484 ++++++++++++++++++
 7 files changed, 604 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
 create mode 100644 drivers/iio/adc/imx93_adc.c
Signature · 1 line
2.34.1