Skip to content

remoteproc: core: do pm relax when in

Maria Yu linux-remoteproc lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest1 patch 1 replyIn review
  2. v52 patches 9 repliesSuperseded
  3. v41 patch 26 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v31 patch0 repliesSuperseded
v21 patch2 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1remoteproc: core: do pm_relax when in RPROC_OFFLINE statedrivers/remoteproc/remoteproc_core.c+8 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/1] remoteproc: core: do pm relax when in

If the remote processor is offline, no need to recover anything, and pm_relax is needed to be called.

summary from some discussion points:

pm_stay_awake() is needed to stop and reverse the suspend process that is currently underway.

RPROC_OFFLINE state indicate there is no recovery process is in progress and no chance to do the pm_relax. Because when recovering from crash, rproc->lock is held and state is RPROC_CRASHED -> RPROC_OFFLINE -> RPROC_RUNNING, and then unlock rproc->lock.
When the state is in RPROC_OFFLINE it means separate request of rproc_stop was done and no need to hold the wakeup source in crash handler to recover any more.

Changelog
===
V6
---
Address the comments.
Drop the allocate ordered workqueue change.

V5
---
Use goto out instead of directly call pm_relax and return. Suggested by Mathieu.
Add new change with allocate ordered workqueue for allow only 1 active work.

V4
---
Add pm relax when in RPROC_OFFLINE.

previous discussion here:
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/linux-remoteproc/[email protected]/T/#t

Maria Yu (1):
remoteproc: core: do pm_relax when in RPROC_OFFLINE state

 drivers/remoteproc/remoteproc_core.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1