Skip to content

bbdev ACC200 PMD

Nicolas Chautru dpdk-dev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest16 patches 14 repliesIn review
  2. v1116 patches 3 repliesSuperseded
  3. v1016 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v914 patches16 repliesSuperseded
v814 patches0 repliesSuperseded
v714 patches3 repliesSuperseded
v614 patches10 repliesSuperseded
v514 patches0 repliesSuperseded
v414 patches27 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16baseband/acc100: remove unused registersdrivers/baseband/acc100/acc100_pf_enum.h+0 -9390 replies
2/16baseband/acc100: refactor to segregate common codeapp/test-bbdev/test_bbdev_perf.c drivers/baseband/acc100/acc100_pmd.h drivers/baseband/acc100/acc101_pmd.h +4 more+1982 -17311 reply
3/16baseband/acc: rename directory from acc100 to accMAINTAINERS app/test-bbdev/meson.build app/test-bbdev/test_bbdev_perf.c +11 more+6 -60 replies
4/16baseband/acc: introduce PMD for ACC200MAINTAINERS doc/guides/bbdevs/acc200.rst doc/guides/bbdevs/features/acc200.ini +6 more+458 -19 replies
5/16baseband/acc: add HW register definitions for ACC200drivers/baseband/acc/acc200_pf_enum.h drivers/baseband/acc/acc200_pmd.h drivers/baseband/acc/acc200_vf_enum.h+354 -00 replies
6/16baseband/acc: add info get function for ACC200drivers/baseband/acc/acc200_pmd.h drivers/baseband/acc/rte_acc200_pmd.c+232 -03 replies
7/16baseband/acc: add queue configuration for ACC200drivers/baseband/acc/acc_common.h drivers/baseband/acc/rte_acc200_pmd.c+391 -10 replies
8/16baseband/acc: add LDPC processing functionsdrivers/baseband/acc/acc_common.h drivers/baseband/acc/rte_acc200_pmd.c+1348 -50 replies
9/16baseband/acc: add LTE processing functionsdrivers/baseband/acc/rte_acc200_pmd.c+813 -50 replies
10/16baseband/acc: add support for FFT operationsdrivers/baseband/acc/rte_acc200_pmd.c+233 -20 replies
11/16baseband/acc: support interruptdrivers/baseband/acc/rte_acc200_pmd.c+299 -30 replies
12/16baseband/acc: add device status and vf2pf commsdrivers/baseband/acc/rte_acc200_pmd.c+30 -00 replies
13/16baseband/acc: add PF configure companion functionapp/test-bbdev/test_bbdev_perf.c drivers/baseband/acc/acc100_pmd.h drivers/baseband/acc/acc200_cfg.h +7 more+585 -220 replies
14/16baseband/acc: simplify meson dependencydrivers/baseband/acc/meson.build+1 -10 replies
15/16baseband/acc: add helper function for descriptor indexdrivers/baseband/acc/acc_common.h drivers/baseband/acc/rte_acc100_pmd.c drivers/baseband/acc/rte_acc200_pmd.c+132 -1570 replies
16/16test-bbdev: unit test capability extensionapp/test-bbdev/test_bbdev_perf.c app/test-bbdev/test_bbdev_vector.c app/test-bbdev/test_bbdev_vector.h +2 more+1282 -171 reply

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchMaxime CoquelinBruce RichardsonHernan Vargas
1/16R-b
2/16R-b A-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16A-b
14/16R-b
15/16
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/16] bbdev ACC200 PMD

v12: Rebase between commits notably to avoid interim build issue and test
vector format issue raised by Akhil. Thanks.
v11: Fixed clang compilation error introduced in v10 16/16. Thanks
v10: Update of patch 13 to expose a single configuration API for the ACC devices.
New commit 15 to refactor PMD code using helper functions for the descriptor
index management and improve readability.
New commit 16 to extend bbdev-test capability to support new
operations and capabilities in the new PMD.
Formatting fixes. Note that the checkpatch warning are False-Alarms.
Thanks
v9: I had missed a compilation error in debug mode.
v8: Rebased to latest and fixed related compilation error. Added acc200.ini and updated rel_notes.
Formatting improvement in comments, docs and commit message.
v7: Additional update in commits 9,10,11 based on review from Maxime.
v5/v6:Updates based on Maxime reviews of v4/v5. Thanks.
v4: Rebase suggested by Maxime to split first commit and update the order within the series. No functional change.
v3: Putting together ACC100 and ACC200 PMDs in common acc directory based on previous discussion on v2.
v2: Includes now code refactory to have common structures and code reused with the parallel ACC1XX serie PMD which can be shared moving forward.
v1: This is targeting 22.11 and includes the PMD for the new serie integrated accelerator on Intel Xeon SPR-EEC.

Nic Chautru (16):
baseband/acc100: remove unused registers baseband/acc100: refactor to segregate common code baseband/acc: rename directory from acc100 to acc baseband/acc: introduce PMD for ACC200 baseband/acc: add HW register definitions for ACC200 baseband/acc: add info get function for ACC200 baseband/acc: add queue configuration for ACC200 baseband/acc: add LDPC processing functions baseband/acc: add LTE processing functions baseband/acc: add support for FFT operations baseband/acc: support interrupt
baseband/acc: add device status and vf2pf comms baseband/acc: add PF configure companion function baseband/acc: simplify meson dependency baseband/acc: add helper function for descriptor index
test-bbdev: unit test capability extension

 MAINTAINERS                                   |    5 +-
 app/test-bbdev/meson.build                    |    4 +-
 app/test-bbdev/test_bbdev_perf.c              |  624 ++-
 app/test-bbdev/test_bbdev_vector.c            |  182 +
 app/test-bbdev/test_bbdev_vector.h            |    1 +
 app/test-bbdev/test_vectors/fft_150.data      |  474 ++
 app/test-bbdev/test_vectors/fft_byp_28.data   |  102 +
 doc/guides/bbdevs/acc200.rst                  |  257 ++
 doc/guides/bbdevs/features/acc200.ini         |   14 +
 doc/guides/bbdevs/features/default.ini        |    1 +
 doc/guides/bbdevs/index.rst                   |    1 +
 doc/guides/rel_notes/release_22_11.rst        |    6 +
 drivers/baseband/acc/acc100_pf_enum.h         |  147 +
 drivers/baseband/acc/acc100_pmd.h             |  177 +
 .../baseband/{acc100 => acc}/acc100_vf_enum.h |    0
 drivers/baseband/{acc100 => acc}/acc101_pmd.h |   10 -
 drivers/baseband/acc/acc200_cfg.h             |   32 +
 drivers/baseband/acc/acc200_pf_enum.h         |  108 +
 drivers/baseband/acc/acc200_pmd.h             |  196 +
 drivers/baseband/acc/acc200_vf_enum.h         |   83 +
 drivers/baseband/acc/acc_common.h             | 1422 ++++++
 drivers/baseband/acc/meson.build              |    8 +
 .../baseband/{acc100 => acc}/rte_acc100_pmd.c | 1894 +++-----
 drivers/baseband/acc/rte_acc200_pmd.c         | 3821 +++++++++++++++++
 drivers/baseband/acc/rte_acc_cfg.h            |   49 +
 .../rte_acc_common_cfg.h}                     |   66 +-
 drivers/baseband/{acc100 => acc}/version.map  |    2 +-
 drivers/baseband/acc100/acc100_pf_enum.h      | 1086 -----
 drivers/baseband/acc100/acc100_pmd.h          |  624 ---
 drivers/baseband/acc100/meson.build           |    8 -
 drivers/baseband/meson.build                  |    2 +-
 31 files changed, 8331 insertions(+), 3075 deletions(-)
 create mode 100644 app/test-bbdev/test_vectors/fft_150.data
 create mode 100644 app/test-bbdev/test_vectors/fft_byp_28.data
 create mode 100644 doc/guides/bbdevs/acc200.rst
 create mode 100644 doc/guides/bbdevs/features/acc200.ini
 create mode 100644 drivers/baseband/acc/acc100_pf_enum.h
 create mode 100644 drivers/baseband/acc/acc100_pmd.h
 rename drivers/baseband/{acc100 => acc}/acc100_vf_enum.h (100%)
 rename drivers/baseband/{acc100 => acc}/acc101_pmd.h (76%)
 create mode 100644 drivers/baseband/acc/acc200_cfg.h
 create mode 100644 drivers/baseband/acc/acc200_pf_enum.h
 create mode 100644 drivers/baseband/acc/acc200_pmd.h
 create mode 100644 drivers/baseband/acc/acc200_vf_enum.h
 create mode 100644 drivers/baseband/acc/acc_common.h
 create mode 100644 drivers/baseband/acc/meson.build
 rename drivers/baseband/{acc100 => acc}/rte_acc100_pmd.c (69%)
 create mode 100644 drivers/baseband/acc/rte_acc200_pmd.c
 create mode 100644 drivers/baseband/acc/rte_acc_cfg.h
 rename drivers/baseband/{acc100/rte_acc100_cfg.h => acc/rte_acc_common_cfg.h} (55%)
 rename drivers/baseband/{acc100 => acc}/version.map (69%)
 delete mode 100644 drivers/baseband/acc100/acc100_pf_enum.h
 delete mode 100644 drivers/baseband/acc100/acc100_pmd.h
 delete mode 100644 drivers/baseband/acc100/meson.build
Signature · 1 line
2.37.1