Skip to content

ufs: core: Always read the descriptors with max length

Arthur Simchaev linux-scsi lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 1 replyIn review
  2. v54 patches 7 repliesApplied
  3. v44 patches 10 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v34 patches4 repliesSuperseded
v2 posting 2/20 of 4 patches0 repliesSuperseded
v2 posting 1/24 patches4 repliesSuperseded
v14 patches0 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ufs: core: Remove redundant wb checkdrivers/ufs/core/ufshcd.c+0 -41 reply
2/4ufs: core: Remove redundant desc_size variable from hbadrivers/ufs/core/ufs_bsg.c drivers/ufs/core/ufshcd-priv.h drivers/ufs/core/ufshcd.c +3 more+15 -750 replies
3/4ufs: core: Remove len parameter from ufshcd_set_active_icc_lvldrivers/ufs/core/ufshcd.c+2 -40 replies
4/4ufs: core: Remove ufshcd_map_desc_id_to_length functiondrivers/ufs/core/ufs_bsg.c drivers/ufs/core/ufshcd.c+11 -130 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBart Van AsscheBean HuoStanley Chu
1/4R-b R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/4] ufs: core: Always read the descriptors with max length

v5--v6:
Add Bart's "Reviewed-by" to patch 2 and 4

v4--v5:
Change patch 2 according to Bart's comment

v3--v4:
Add "Reviewed-by" to patch's commits
Use kzalloc instead of kmalloc in drivers/ufs/core/ufshcd.c - patch 2/4

v2--v3:
Based on Bean's comments:
1)Use kzalloc instead of kmalloc in ufshcd_set_active_icc_lvl - patch 2/4 2)Delete UFS_RPMB_UNIT definition - patch 2/4
3)Delete len description - patch 3/4

v1--v2:
Fix argument warning in ufshpb.c

Read any descriptor with a maximum size of QUERY_DESC_MAX_SIZE. According to the spec the device rerurns the actual size. Thus can improve code readability and save CPU cycles.
While at it, cleanup few leftovers around the descriptor size parameter.

Arthur Simchaev (4):
ufs:core: Remove redundant wb check
ufs:core: Remove redundant desc_size variable from hba
ufs: core: Remove len parameter from ufshcd_set_active_icc_lvl
ufs: core: Remove ufshcd_map_desc_id_to_length function

 drivers/ufs/core/ufs_bsg.c     |   7 +--
 drivers/ufs/core/ufshcd-priv.h |   3 --
 drivers/ufs/core/ufshcd.c      | 100 ++++++++++-------------------------------
 drivers/ufs/core/ufshpb.c      |   5 +--
 include/ufs/ufshcd.h           |   1 -
 5 files changed, 26 insertions(+), 90 deletions(-)
Signature · 1 line
2.7.4