bpf, sockmap: Fix some issues with using apply_bytes
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyApplied 4/4
- v24 patches 1 replySuperseded
- v1 posting 3/34 patches 8 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 posting 2/3 | 0 of 4 patches | 0 replies | Superseded | |
| v1 posting 1/3 | 2 of 4 patches | 3 replies | Superseded |
Changes in v3 from the cover letter
*Patch 2: Rename 'flags', modify based on Jakub Sitnicki's patch
Patches in v3 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | bpf, sockmap: Fix repeated calls to sock_put() when msg has more_datanet/ | +2 | 0 replies | Applied |
| 2/4 | bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytesinclude/ include/ net/ +2 more | +19 | 0 replies | Applied |
| 3/4 | bpf, sockmap: Fix data loss caused by using apply_bytes on ingress redirectnet/ | +4 | 0 replies | Applied |
| 4/4 | selftests/bpf: Add ingress tests for txmsg with apply_bytestools/ | +18 | 0 replies | Applied |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jakub Sitnicki |
|---|---|
| Series | A-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf v3 0/4] bpf, sockmap: Fix some issues with using apply_bytes
Patch 1~3 fixes three issues with using apply_bytes when redirecting. Patch 4 adds ingress tests for txmsg with apply_bytes in selftests.
Thanks to John Fastabend and Jakub Sitnicki for correct solution.
---
Changes in v3:
*Patch 2: Rename 'flags', modify based on Jakub Sitnicki's patch
Changes in v2:
*Patch 2: Clear psock->flags explicitly before releasing the sock lock
Pengcheng Yang (4):
bpf, sockmap: Fix repeated calls to sock_put() when msg has more_data bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes bpf, sockmap: Fix data loss caused by using apply_bytes on ingress
redirect
selftests/bpf: Add ingress tests for txmsg with apply_bytes
include/linux/skmsg.h | 1 + include/net/tcp.h | 4 ++-- net/core/skmsg.c | 9 ++++++--- net/ipv4/tcp_bpf.c | 19 ++++++++++++------- net/tls/tls_sw.c | 6 ++++-- tools/testing/selftests/bpf/test_sockmap.c | 18 ++++++++++++++++++ 6 files changed, 43 insertions(+), 14 deletions(-)
Signature · 1 line
1.8.3.1