Skip to content

package/pkg-download: restore user's original umask for the whole download process

Luca Pesce via buildroot buildroot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1package/pkg-download: restore user's original umask for the whole download processMakefile package/pkg-download.mk+20 -32 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/1] package/pkg-download: restore user's original umask for the whole download process

Hi Yann, all,
this is the revised patch based on Yann's suggestion from this thread:
https://lists.buildroot.org/pipermail/buildroot/2022-December/656833.html

There is one more thing to it, though: the original user's umask is saved only if it is more permissive than BR minimum requirement (0022). This is to guarantee that the download process can always create files/dirs just as before. The logic of this check is a bit tricky, and requires bitwise operations on octal numbers... I had to do it in shell :(

Regards,
Luca

Luca Pesce (1):
package/pkg-download: restore user's original umask for the whole
download process

 Makefile                | 17 ++++++++++++++++-
 package/pkg-download.mk |  6 ++++--
 2 files changed, 20 insertions(+), 3 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot