Skip to content

add rte_thread_set_name API for rte_thread_t

Tyler Retzlaff dpdk-dev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest4 patches 6 repliesIn review
  2. v94 patches 2 repliesSuperseded
  3. v84 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v75 patches8 repliesSuperseded
v65 patches4 repliesSuperseded
v54 patches4 repliesSuperseded
v44 patches2 repliesSuperseded
v34 patches0 repliesSuperseded
v24 patches8 repliesSuperseded

Changes in v10 from the cover letter

* change intended deprecation of rte_thread_setname

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4eal: add thread set name API operating on rte threaddrivers/net/mlx5/mlx5_hws_cnt.c drivers/vdpa/mlx5/mlx5_vdpa_event.c lib/eal/common/eal_common_thread.c +7 more+106 -160 replies
2/4eal: remove thread getname APIlib/eal/common/eal_common_trace.c lib/eal/freebsd/eal_thread.c lib/eal/include/rte_lcore.h +2 more+14 -430 replies
3/4eal: set thread name on Windows worker threadslib/eal/windows/eal.c+7 -00 replies
4/4eal: deprecation notice for rte thread setname APIdoc/guides/rel_notes/deprecation.rst+5 -05 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMorten BrørupDavid MarchandJerin JacobThomas Monjalon
SeriesSeries-acked-by
1/4A-b
2/4A-b A-b
3/4A-b
4/4A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t

v10:
* change intended deprecation of rte_thread_setname

    from 23.03 to 23.07

v9:
* fix typo in v8 deprecation notice picked up by ci

v8:
* document that no implementation or internal implementation failure is a noop for rte_thread_set_name
* update commit message to indicate windows now provides an implementation for rte_thread_set_name
* remove '_' from thread_name in comment
* squish drivers/mlx5 patch into patch 1 as requested
* clarify rte_thread_setname anticipated deprecation and removal releases in deprecation notice
* group deprecation notice with other eal deprecation notices

v7:
* don't dereference thread_name after successful completion of mbsrtowcs. (fixes NULL dereference on Windows).

v6:
* clean up commit descriptions
* add patch to set worker thread name on windows
* remove __rte_deprecated from rte_thread_setname

v5:
* rename rte_thread_getname -> thread_get_name

v4:
* retain and move rte_thread_getname function to the single site of use

v3:
* fix coding style error
* move remove of rte_thread_getname to patch #2

v2:
* initial series provided get/set for lcore thread id, those additions have been removed as per discussion. including unit test
* add a single api rte_thread_set_name does not fail but emits debug logging if the internal implementation is aware of in-exact use of the name or failure to set the name
* adapt mlx5 driver to avoid use of deprecated API

Tyler Retzlaff (4):
eal: add thread set name API operating on rte thread
eal: remove thread getname API
eal: set thread name on Windows worker threads
eal: deprecation notice for rte thread setname API

 doc/guides/rel_notes/deprecation.rst |  5 +++++
 drivers/net/mlx5/mlx5_hws_cnt.c      |  3 ++-
 drivers/vdpa/mlx5/mlx5_vdpa_event.c  |  3 +--
 lib/eal/common/eal_common_thread.c   |  8 ++-----
 lib/eal/common/eal_common_trace.c    | 15 ++++++++++++-
 lib/eal/freebsd/eal.c                |  3 +--
 lib/eal/freebsd/eal_thread.c         | 20 +++++++++--------
 lib/eal/include/rte_lcore.h          | 17 --------------
 lib/eal/include/rte_thread.h         | 20 +++++++++++++++++
 lib/eal/linux/eal.c                  |  6 +----
 lib/eal/linux/eal_thread.c           | 29 +++++++++++++++---------
 lib/eal/version.map                  |  4 +++-
 lib/eal/windows/eal.c                |  7 ++++++
 lib/eal/windows/rte_thread.c         | 43 ++++++++++++++++++++++++++++++++++++
 14 files changed, 128 insertions(+), 55 deletions(-)
Signature · 1 line
1.8.3.1