Skip to content

multipath: persistent reservation fixes

Benjamin Marzinski dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6multipathd: make pr registration consistentmultipathd/main.c+29 -140 replies
2/6libmultipath: make prflag an enumlibmpathpersist/mpath_persist_int.c libmultipath/structs.h multipathd/cli_handlers.c +1 more+24 -171 reply
3/6multipathd: handle no active paths in update_map_prlibmpathpersist/mpath_persist_int.c libmultipath/structs.h multipathd/cli_handlers.c +1 more+24 -50 replies
4/6multipathd: add missing newline to cli_del_map replymultipathd/cli_handlers.c+1 -10 replies
5/6libmultipath: skip extra vector work in remove_mapslibmultipath/structs_vec.c+2 -40 replies
6/6libmultipath: orphan paths if coalesce_paths frees newmplibmultipath/configure.c+5 -20 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMartin Wilck
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [dm-devel] [PATCH 0/6] multipath: persistent reservation fixes

The first three patches fix issues with multipathd's persistent reservation handling. As long as mpathpersist is run on a multipath device while multipathd is montioring it, everything works fine. But if new paths to that device appear or first become active while multipathd isn't running or the multipath device doesn't exist, multipathd might not register keys to those paths when it starts up or adds the multipath device.

These patches also fix an issue where, if there are no active paths for multipathd to use for checking registered keys on device creation, it will treat the device as if there are no registered keys.

The other three patches fix issues I found while looking into the persistent reservation problems.

Benjamin Marzinski (6):
multipathd: make pr registration consistent
libmultipath: make prflag an enum
multipathd: handle no active paths in update_map_pr
multipathd: add missing newline to cli_del_map reply
libmultipath: skip extra vector work in remove_maps
libmultipath: orphan paths if coalesce_paths frees newmp

 libmpathpersist/mpath_persist_int.c | 10 ++++-
 libmultipath/configure.c            |  7 +++-
 libmultipath/structs.h              |  9 ++++-
 libmultipath/structs_vec.c          |  6 +--
 multipathd/cli_handlers.c           | 20 +++++-----
 multipathd/main.c                   | 60 ++++++++++++++++++++---------
 6 files changed, 77 insertions(+), 35 deletions(-)
Signature · 6 lines
2.17.2

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel