Skip to content

enable use of the MSVC compiler

Tyler Retzlaff dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 2 repliesIn review
  2. v44 patches 9 repliesSuperseded
  3. v34 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches2 repliesSuperseded
v13 patches6 repliesSuperseded

Changes in v5 from the cover letter

* Clean up comments in config/meson.build for project arguments and dpdk_conf defines when is_ms_compiler
* Restore incorrectly removed enabled_apps = [] in v4

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4build: unblock the use of the MSVC compilerconfig/meson.build config/x86/meson.build lib/meson.build+31 -150 replies
2/4build: determine execution environment at config timeconfig/meson.build lib/eal/meson.build+8 -80 replies
3/4build: limit what is built when using MSVC compilerapp/meson.build drivers/meson.build lib/meson.build +1 more+20 -00 replies
4/4build: enable MSVC specific compiler optionsconfig/meson.build+16 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBruce Richardson
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] enable use of the MSVC compiler

Introduce minimum changes to the build system to allow use of the MSVC compiler.

This change is intended to enable a phased approach to allowing DPDK to built with MSVC. Building with MSVC removes barriers to enterprise customers use of DPDK who have constraints around security policy, compliance and functional requirements.

v5:
* Clean up comments in config/meson.build for project arguments and dpdk_conf defines when is_ms_compiler
* Restore incorrectly removed enabled_apps = [] in v4

v4:
* Remove conditional if cc.get_id() != 'msvc' for assignment of objdump and binutils_avx512_check in anticipation of merge of patch from David Marchand
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]
Note:
I'm aware that none of the shell scripts here are usable on the windows build, it's a gap we hope to fill in the future for now we hap hazardly rely on the linux builds.
* Remove enabled_apps = [] apps when skipping apps/meson.build for is_ms_compiler in anticipation of merge of patch from David Marchand
https://patchwork.dpdk.org/project/dpdk/patch/[email protected]
* Rebase series and include 'log' library as it is now required by kvargs and telemetry libs
* Move 2 comments into block scope ehre they apply
Note:
There are no requirements specifically for msvc compiler beyond those that would cause build to fail when the currently experimental options are used. when i know the final version of the compiler needed it will be documented in the windows quick start guide.

v3:
* enable compilation with C11 optional atomics
* enable compilation with C23 typeof operator
* disable microsoft secure crt checks (dpdk code fails)
* force use of intrinsics

v2:
* moved checks to skip drivers, apps, usertools directories in to <dir>/meson.build file and removed conditional check from root meson.build (patch 3/3)

Tyler Retzlaff (4):
build: unblock the use of the MSVC compiler
build: determine execution environment at config time
build: limit what is built when using MSVC compiler
build: enable MSVC specific compiler options

 app/meson.build        |  4 ++++
 config/meson.build     | 47 +++++++++++++++++++++++++++++++++++++++--------
 config/x86/meson.build | 10 ++++++----
 drivers/meson.build    |  4 ++++
 lib/eal/meson.build    |  8 --------
 lib/meson.build        | 21 ++++++++++++++++++---
 usertools/meson.build  |  4 ++++
 7 files changed, 75 insertions(+), 23 deletions(-)
Signature · 1 line
1.8.3.1