Skip to content

use rte optional stdatomic API

Tyler Retzlaff dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest19 patches 6 repliesIn review
  2. v219 patches 17 repliesSuperseded
  3. v121 patches 0 repliesSuperseded

Changes in v3 from the cover letter

* add missing atomic specification on head variable
in struct rte_ring_headtail
* adapt to use rte_atomic_xxx stdatomic API in rte_ring_c11_pvt.h
* split comma operator statement into 2 statements

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19power: use rte optional stdatomic APIlib/power/power_acpi_cpufreq.c lib/power/power_cppc_cpufreq.c lib/power/power_pstate_cpufreq.c+46 -430 replies
2/19bbdev: use rte optional stdatomic APIlib/bbdev/rte_bbdev.c lib/bbdev/rte_bbdev.h+4 -41 reply
3/19eal: use rte optional stdatomic APIlib/eal/common/eal_common_launch.c lib/eal/common/eal_common_mcfg.c lib/eal/common/eal_common_proc.c +13 more+152 -1490 replies
4/19eventdev: use rte optional stdatomic APIdrivers/event/cnxk/cnxk_tim_worker.h lib/eventdev/rte_event_timer_adapter.c lib/eventdev/rte_event_timer_adapter.h+36 -360 replies
5/19gpudev: use rte optional stdatomic APIlib/gpudev/gpudev.c lib/gpudev/gpudev_driver.h+4 -40 replies
6/19ipsec: use rte optional stdatomic APIlib/ipsec/ipsec_sqn.h lib/ipsec/sa.h+2 -21 reply
7/19mbuf: use rte optional stdatomic APIlib/mbuf/rte_mbuf.h lib/mbuf/rte_mbuf_core.h+13 -120 replies
8/19mempool: use rte optional stdatomic APIlib/mempool/rte_mempool.h+2 -20 replies
9/19rcu: use rte optional stdatomic APIlib/rcu/rte_rcu_qsbr.c lib/rcu/rte_rcu_qsbr.h+58 -580 replies
10/19pdump: use rte optional stdatomic APIlib/pdump/rte_pdump.c lib/pdump/rte_pdump.h+11 -110 replies
11/19stack: use rte optional stdatomic APIlib/stack/rte_stack.h lib/stack/rte_stack_lf_c11.h lib/stack/rte_stack_lf_generic.h+22 -220 replies
12/19telemetry: use rte optional stdatomic APIlib/telemetry/telemetry.c+9 -90 replies
13/19vhost: use rte optional stdatomic APIlib/vhost/vdpa.c lib/vhost/vhost.c lib/vhost/vhost.h +3 more+84 -701 reply
14/19cryptodev: use rte optional stdatomic APIlib/cryptodev/rte_cryptodev.c lib/cryptodev/rte_cryptodev.h+20 -181 reply
15/19distributor: use rte optional stdatomic APIlib/distributor/distributor_private.h lib/distributor/rte_distributor.c+29 -290 replies
16/19ethdev: use rte optional stdatomic APIlib/ethdev/ethdev_driver.h lib/ethdev/ethdev_private.c lib/ethdev/rte_ethdev.c +2 more+32 -320 replies
17/19hash: use rte optional stdatomic APIlib/hash/rte_cuckoo_hash.c lib/hash/rte_cuckoo_hash.h+61 -610 replies
18/19timer: use rte optional stdatomic APIlib/timer/rte_timer.c lib/timer/rte_timer.h+28 -280 replies
19/19ring: use rte optional stdatomic APIdrivers/net/mlx5/mlx5_hws_cnt.h lib/ring/rte_ring_c11_pvt.h lib/ring/rte_ring_core.h +4 more+71 -630 replies

Reviews trailers per patch

4 of 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaxime CoquelinDavid MarchandAkhil Goyal
SeriesA-b
1/19
2/19R-b
3/19
4/19
5/19
6/19A-b
7/19
8/19
9/19
10/19
11/19
12/19
13/19R-b
14/19A-b
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/19] use rte optional stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API.

v3:
* add missing atomic specification on head variable
in struct rte_ring_headtail
* adapt to use rte_atomic_xxx stdatomic API in rte_ring_c11_pvt.h
* split comma operator statement into 2 statements

v2:
* add #include <rte_stdatomic.h> to rte_mbuf_core.h
* remove first two patches which were fixes that have been merged in another series

Tyler Retzlaff (19):
power: use rte optional stdatomic API
bbdev: use rte optional stdatomic API
eal: use rte optional stdatomic API
eventdev: use rte optional stdatomic API
gpudev: use rte optional stdatomic API
ipsec: use rte optional stdatomic API
mbuf: use rte optional stdatomic API
mempool: use rte optional stdatomic API
rcu: use rte optional stdatomic API
pdump: use rte optional stdatomic API
stack: use rte optional stdatomic API
telemetry: use rte optional stdatomic API
vhost: use rte optional stdatomic API
cryptodev: use rte optional stdatomic API
distributor: use rte optional stdatomic API
ethdev: use rte optional stdatomic API
hash: use rte optional stdatomic API
timer: use rte optional stdatomic API
ring: use rte optional stdatomic API

 drivers/event/cnxk/cnxk_tim_worker.h   |   4 +-
 drivers/net/mlx5/mlx5_hws_cnt.h        |   4 +-
 lib/bbdev/rte_bbdev.c                  |   6 +-
 lib/bbdev/rte_bbdev.h                  |   2 +-
 lib/cryptodev/rte_cryptodev.c          |  22 +++---
 lib/cryptodev/rte_cryptodev.h          |  16 ++---
 lib/distributor/distributor_private.h  |   4 +-
 lib/distributor/rte_distributor.c      |  54 +++++++--------
 lib/eal/common/eal_common_launch.c     |  10 +--
 lib/eal/common/eal_common_mcfg.c       |   2 +-
 lib/eal/common/eal_common_proc.c       |  14 ++--
 lib/eal/common/eal_common_thread.c     |  26 +++----
 lib/eal/common/eal_common_trace.c      |   8 +--
 lib/eal/common/eal_common_trace_ctf.c  |   4 +-
 lib/eal/common/eal_memcfg.h            |   2 +-
 lib/eal/common/eal_private.h           |   4 +-
 lib/eal/common/eal_trace.h             |   4 +-
 lib/eal/common/rte_service.c           | 122 ++++++++++++++++-----------------
 lib/eal/freebsd/eal.c                  |  20 +++---
 lib/eal/include/rte_epoll.h            |   3 +-
 lib/eal/linux/eal.c                    |  26 +++----
 lib/eal/linux/eal_interrupts.c         |  42 ++++++------
 lib/eal/ppc/include/rte_atomic.h       |   6 +-
 lib/eal/windows/rte_thread.c           |   8 ++-
 lib/ethdev/ethdev_driver.h             |  16 ++---
 lib/ethdev/ethdev_private.c            |   6 +-
 lib/ethdev/rte_ethdev.c                |  24 +++----
 lib/ethdev/rte_ethdev.h                |  16 ++---
 lib/ethdev/rte_ethdev_core.h           |   2 +-
 lib/eventdev/rte_event_timer_adapter.c |  66 +++++++++---------
 lib/eventdev/rte_event_timer_adapter.h |   2 +-
 lib/gpudev/gpudev.c                    |   6 +-
 lib/gpudev/gpudev_driver.h             |   2 +-
 lib/hash/rte_cuckoo_hash.c             | 116 +++++++++++++++----------------
 lib/hash/rte_cuckoo_hash.h             |   6 +-
 lib/ipsec/ipsec_sqn.h                  |   2 +-
 lib/ipsec/sa.h                         |   2 +-
 lib/mbuf/rte_mbuf.h                    |  20 +++---
 lib/mbuf/rte_mbuf_core.h               |   5 +-
 lib/mempool/rte_mempool.h              |   4 +-
 lib/pdump/rte_pdump.c                  |  14 ++--
 lib/pdump/rte_pdump.h                  |   8 +--
 lib/power/power_acpi_cpufreq.c         |  33 ++++-----
 lib/power/power_cppc_cpufreq.c         |  25 +++----
 lib/power/power_pstate_cpufreq.c       |  31 +++++----
 lib/rcu/rte_rcu_qsbr.c                 |  48 ++++++-------
 lib/rcu/rte_rcu_qsbr.h                 |  68 +++++++++---------
 lib/ring/rte_ring_c11_pvt.h            |  47 +++++++------
 lib/ring/rte_ring_core.h               |  12 ++--
 lib/ring/rte_ring_generic_pvt.h        |  16 +++--
 lib/ring/rte_ring_hts_elem_pvt.h       |  22 +++---
 lib/ring/rte_ring_peek_elem_pvt.h      |   6 +-
 lib/ring/rte_ring_rts_elem_pvt.h       |  27 ++++----
 lib/stack/rte_stack.h                  |   2 +-
 lib/stack/rte_stack_lf_c11.h           |  24 +++----
 lib/stack/rte_stack_lf_generic.h       |  18 ++---
 lib/telemetry/telemetry.c              |  18 ++---
 lib/timer/rte_timer.c                  |  50 +++++++-------
 lib/timer/rte_timer.h                  |   6 +-
 lib/vhost/vdpa.c                       |   3 +-
 lib/vhost/vhost.c                      |  42 ++++++------
 lib/vhost/vhost.h                      |  39 ++++++-----
 lib/vhost/vhost_user.c                 |   6 +-
 lib/vhost/virtio_net.c                 |  58 +++++++++-------
 lib/vhost/virtio_net_ctrl.c            |   6 +-
 65 files changed, 684 insertions(+), 653 deletions(-)
Signature · 1 line
1.8.3.1