Skip to content

use abstracted bit count functions

Tyler Retzlaff dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 4 repliesIn review
  2. v25 patches 1 replySuperseded
  3. v15 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* add missing include of rte_bitops.h
* add 2 patches to cover use of __builtin_popcountl

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7distributor: use abstracted bit count functionslib/distributor/rte_distributor_single.c+1 -10 replies
2/7hash: use abstracted bit count functionslib/hash/rte_cuckoo_hash.c+8 -80 replies
3/7member: use abstracted bit count functionslib/member/rte_member_vbf.c lib/member/rte_member_x86.h+9 -90 replies
4/7rcu: use abstracted bit count functionslib/rcu/rte_rcu_qsbr.c lib/rcu/rte_rcu_qsbr.h+3 -30 replies
5/7table: use abstracted bit count functionslib/table/rte_lru_arm64.h lib/table/rte_swx_table_em.c lib/table/rte_table_hash_ext.c +1 more+8 -70 replies
6/7distributor: use abstracted bit count functionslib/distributor/rte_distributor_single.c+1 -10 replies
7/7hash: use abstracted bit count functionslib/hash/rte_cuckoo_hash.c+2 -21 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchMorten Brørup
SeriesSeries-acked-by
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] use abstracted bit count functions

The first set of conversions missed the long 'l' versions of the builtins that were being used. This series completes the conversion of remaining libraries from __builtin_ctzl, __builtin_clzl and __builtin_popcountl.

v3:
* add missing include of rte_bitops.h
* add 2 patches to cover use of __builtin_popcountl

v2:
* be explicit and use appropriate 32-bit and 64-bit leading and trailing counting functions depending on the type of the expression passed as an argument to the builtin.

Tyler Retzlaff (7):
distributor: use abstracted bit count functions
hash: use abstracted bit count functions
member: use abstracted bit count functions
rcu: use abstracted bit count functions
table: use abstracted bit count functions
distributor: use abstracted bit count functions
hash: use abstracted bit count functions

 lib/distributor/rte_distributor_single.c |  4 ++--
 lib/hash/rte_cuckoo_hash.c               | 20 ++++++++++----------
 lib/member/rte_member_vbf.c              | 12 ++++++------
 lib/member/rte_member_x86.h              |  6 +++---
 lib/rcu/rte_rcu_qsbr.c                   |  4 ++--
 lib/rcu/rte_rcu_qsbr.h                   |  2 +-
 lib/table/rte_lru_arm64.h                |  3 ++-
 lib/table/rte_swx_table_em.c             |  4 ++--
 lib/table/rte_table_hash_ext.c           |  4 ++--
 lib/table/rte_table_hash_lru.c           |  4 ++--
 10 files changed, 32 insertions(+), 31 deletions(-)
Signature · 1 line
1.8.3.1