Skip to content

RFC netfilter: bpf: support prog update

D. Wythe bpf lkml netdev netfilter-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 RFC Latest2 patches 5 repliesIn review
  2. v4 RFC2 patches 1 replySuperseded
  3. v3 RFC2 patches 6 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC2 patches4 repliesSuperseded
v1 RFC2 patches2 repliesSuperseded

Changes in v5 from the cover letter

1. fix error retval check on cmpxhcg

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2netfilter: bpf: support prog updatenet/netfilter/nf_bpf_link.c+34 -160 replies
2/2selftests/bpf: Add netfilter link prog update testtools/testing/selftests/bpf/prog_tests/netfilter_link_update_prog.c tools/testing/selftests/bpf/progs/test_netfilter_link_update_prog.c+107 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [RFC nf-next v5 0/2] netfilter: bpf: support prog update

From: "D. Wythe" <[email protected]>

This patches attempt to implements updating of progs within bpf netfilter link, allowing user update their ebpf netfilter prog in hot update manner.

Besides, a corresponding test case has been added to verify whether the update works.
--
v1:
1. remove unnecessary context, access the prog directly via rcu.
2. remove synchronize_rcu(), dealloc the nf_link via kfree_rcu.
3. check the dead flag during the update.
--
v1->v2:
1. remove unnecessary nf_prog, accessing nf_link->link.prog in direct. --
v2->v3:
1. access nf_link->link.prog via rcu_dereference_raw to avoid warning. --
v3->v4:
1. remove mutex for link update, as it is unnecessary and can be replaced by atomic operations.
--
v4->v5:
1. fix error retval check on cmpxhcg

D. Wythe (2):
netfilter: bpf: support prog update selftests/bpf: Add netfilter link prog update test

 net/netfilter/nf_bpf_link.c                        | 50 ++++++++-----
 .../bpf/prog_tests/netfilter_link_update_prog.c    | 83 ++++++++++++++++++++++
 .../bpf/progs/test_netfilter_link_update_prog.c    | 24 +++++++
 3 files changed, 141 insertions(+), 16 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/netfilter_link_update_prog.c
 create mode 100644 tools/testing/selftests/bpf/progs/test_netfilter_link_update_prog.c
Signature · 1 line
1.8.3.1