Skip to content

remove __typeof__ from expansion of per lcore macros

Tyler Retzlaff dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v23 patches 1 replySuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

* provide notice in release_24_03.rst about change in macro expansion.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3eal: provide type to per lcore macrolib/eal/common/eal_common_errno.c+1 -10 replies
2/3crypto/ipsec_mb: provide type to per lcore macrodrivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h+1 -10 replies
3/3eal: remove typeof from per lcore macrosdoc/guides/rel_notes/release_24_03.rst lib/eal/include/rte_per_lcore.h+9 -41 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBruce RichardsonMorten Brørup
1/3A-b
2/3A-b
3/3A-b Series-acked-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] remove __typeof__ from expansion of per lcore macros

The design of the macros requires a type to be provided to the macro.

By expanding the type parameter inside of typeof it also inadvertently allows an expression to be used which appears not to have been intended after evaluating the parameter name and existing macro use.

Technically this is an API break but only for applications that were using these macros outside of the original design intent.

v3:
* provide notice in release_24_03.rst about change in macro expansion.
v2:
* add additional patch to adjust usage for crypto/ipsec_mb

Tyler Retzlaff (3):
eal: provide type to per lcore macro crypto/ipsec_mb: provide type to per lcore macro
eal: remove typeof from per lcore macros

 doc/guides/rel_notes/release_24_03.rst       | 5 +++++
 drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +-
 lib/eal/common/eal_common_errno.c            | 2 +-
 lib/eal/include/rte_per_lcore.h              | 8 ++++----
 4 files changed, 11 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.3.1