Skip to content

use C11 alignof

Tyler Retzlaff dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest21 patches 2 repliesIn review
  2. v19 patches 6 repliesSuperseded

Changes in v2 from the cover letter

* expand series to replace use in entire source tree, now includes app, drivers, examples in addition to lib.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21ring: use C11 alignoflib/ring/rte_ring.c+2 -10 replies
2/21mbuf: use C11 alignoflib/mbuf/rte_mbuf_dyn.c+2 -10 replies
3/21ethdev: use C11 alignoflib/ethdev/ethdev_driver.c lib/ethdev/rte_flow.c+4 -20 replies
4/21eventdev: use C11 alignoflib/eventdev/rte_eventdev.c+2 -10 replies
5/21stack: use C11 alignoflib/stack/rte_stack.c+2 -10 replies
6/21node: use C11 alignoflib/node/node_private.h+3 -10 replies
7/21pdcp: use C11 alignoflib/pdcp/rte_pdcp.c+3 -10 replies
8/21reorder: use C11 alignoflib/reorder/rte_reorder.c+2 -10 replies
9/21security: use C11 alignoflib/security/rte_security.c+3 -20 replies
10/21test: use C11 alignofapp/test/test_distributor.c app/test/test_graph.c app/test/test_mbuf.c +1 more+13 -80 replies
11/21examples: use C11 alignofexamples/bbdev_app/main.c examples/rxtx_callbacks/main.c+4 -20 replies
12/21app/eventdev: use C11 alignofapp/test-eventdev/test_order_common.c+4 -20 replies
13/21drivers/bus: use C11 alignofdrivers/bus/dpaa/dpaa_bus.c drivers/bus/fslmc/fslmc_bus.c+4 -20 replies
14/21event/sw: use C11 alignofdrivers/event/sw/sw_evdev_selftest.c+2 -10 replies
15/21net/bnxt: use C11 alignofdrivers/net/bnxt/bnxt_ethdev.c+2 -11 reply
16/21net/iavf: use C11 alignofdrivers/net/iavf/iavf_ethdev.c drivers/net/iavf/iavf_ipsec_crypto.c drivers/net/iavf/iavf_testpmd.c+7 -30 replies
17/21net/nfp: use C11 alignofdrivers/net/nfp/nfp_ipsec.c+3 -10 replies
18/21net/sfc: use C11 alignofdrivers/net/sfc/sfc_dp.c+3 -20 replies
19/21net/virtio: use C11 alignofdrivers/net/virtio/virtio_rxtx.c+4 -30 replies
20/21net/vmxnet3: use C11 alignofdrivers/net/vmxnet3/vmxnet3_ethdev.c+2 -10 replies
21/21devtools: forbid direct use of compiler alignof and typeofdevtools/checkpatches.sh+16 -00 replies

Reviews trailers per patch

10 of 21 patches have a Reviewed-by or Acked-by.

PatchMorten BrørupChengwen FengAnoob JosephVolodymyr FialkoAkhil GoyalAjit Khaparde
1/21A-b A-b
2/21A-b A-b
3/21A-b A-b
4/21A-b A-b
5/21A-b A-b
6/21A-b A-b
7/21A-b A-b A-b
8/21A-b A-b A-b
9/21A-b A-b A-b
10/21
11/21
12/21
13/21
14/21
15/21A-b
16/21
17/21
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/21] use C11 alignof

Replace use of __alignof__(T) and __alignof__(e) with C11 alignof(T) and alignof(typeof(e)) respectively to improve portability of the code between toolchains.

v2:
* expand series to replace use in entire source tree, now includes app, drivers, examples in addition to lib.

Tyler Retzlaff (21):
ring: use C11 alignof
mbuf: use C11 alignof
ethdev: use C11 alignof
eventdev: use C11 alignof
stack: use C11 alignof
node: use C11 alignof
pdcp: use C11 alignof
reorder: use C11 alignof
security: use C11 alignof
test: use C11 alignof
examples: use C11 alignof
app/eventdev: use C11 alignof
drivers/bus: use C11 alignof
event/sw: use C11 alignof
net/bnxt: use C11 alignof
net/iavf: use C11 alignof
net/nfp: use C11 alignof
net/sfc: use C11 alignof
net/virtio: use C11 alignof
net/vmxnet3: use C11 alignof
devtools: forbid direct use of compiler alignof and typeof

 app/test-eventdev/test_order_common.c |  6 ++++--
 app/test/test_distributor.c           |  3 ++-
 app/test/test_graph.c                 |  3 ++-
 app/test/test_mbuf.c                  |  9 +++++----
 app/test/test_ring_stress_impl.h      |  6 ++++--
 devtools/checkpatches.sh              | 16 ++++++++++++++++
 drivers/bus/dpaa/dpaa_bus.c           |  3 ++-
 drivers/bus/fslmc/fslmc_bus.c         |  3 ++-
 drivers/event/sw/sw_evdev_selftest.c  |  3 ++-
 drivers/net/bnxt/bnxt_ethdev.c        |  3 ++-
 drivers/net/iavf/iavf_ethdev.c        |  3 ++-
 drivers/net/iavf/iavf_ipsec_crypto.c  |  4 +++-
 drivers/net/iavf/iavf_testpmd.c       |  3 ++-
 drivers/net/nfp/nfp_ipsec.c           |  4 +++-
 drivers/net/sfc/sfc_dp.c              |  5 +++--
 drivers/net/virtio/virtio_rxtx.c      |  7 ++++---
 drivers/net/vmxnet3/vmxnet3_ethdev.c  |  3 ++-
 examples/bbdev_app/main.c             |  3 ++-
 examples/rxtx_callbacks/main.c        |  3 ++-
 lib/ethdev/ethdev_driver.c            |  3 ++-
 lib/ethdev/rte_flow.c                 |  3 ++-
 lib/eventdev/rte_eventdev.c           |  3 ++-
 lib/mbuf/rte_mbuf_dyn.c               |  3 ++-
 lib/node/node_private.h               |  4 +++-
 lib/pdcp/rte_pdcp.c                   |  4 +++-
 lib/reorder/rte_reorder.c             |  3 ++-
 lib/ring/rte_ring.c                   |  3 ++-
 lib/security/rte_security.c           |  5 +++--
 lib/stack/rte_stack.c                 |  3 ++-
 29 files changed, 87 insertions(+), 37 deletions(-)
Signature · 1 line
1.8.3.1